{"thread":{"id":"52004","subject":"[PATCH 0/1] Make the description of git stash save clearer","startedAt":"2019-10-10T10:06:44Z","lastAt":"2019-10-11T05:30:08Z","messageCount":4,"participants":["Johannes Schindelin via GitGitGadget","Thomas Gummerer","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"383784","messageId":"pull.384.git.gitgitgadget@gmail.com","threadId":"52004","inReplyTo":null,"subject":"[PATCH 0/1] Make the description of git stash save clearer","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-10T10:06:40Z","receivedAt":"2019-10-10T10:06:44Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"This is an attempt to revive the discussion started in \nhttps://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t\n\nJohannes Schindelin (1):\n doc(stash): clarify the description of `save`\n\n Documentation/git-stash.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\n\nbase-commit: 70bf0b755af4d1e66da25b7805cac0e481a082e4\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-384%2Fdscho%2Fclarify-stash-doc-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-384/dscho/clarify-stash-doc-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/384\n-- \ngitgitgadget\n"},{"id":"383785","messageId":"572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget@gmail.com","threadId":"52004","inReplyTo":"pull.384.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] doc(stash): clarify the description of `save`","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-10-10T10:06:41Z","receivedAt":"2019-10-10T10:06:45Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe original phrasing of this paragraph made at least one person stumble\nover the word \"from\" (thinking that it was a typo and \"from\" was\nintended), and other readers chimed in, agreeing that it was confusing:\nhttps://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t\n\nLet's rewrite that paragraph for clarity.\n\nInspired-by-a-patch-by: Catalin Criste \nSigned-off-by: Johannes Schindelin \n---\n Documentation/git-stash.txt | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 8fbe12c66c..53e1a1205d 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use\n save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []::\n \n \tThis option is deprecated in favour of 'git stash push'. It\n-\tdiffers from \"stash push\" in that it cannot take pathspecs,\n-\tand any non-option arguments form the message.\n+\tdiffers from \"stash push\" in that it cannot take pathspecs.\n+\tInstead, all non-option arguments are concatenated to form the stash\n+\tmessage.\n \n list []::\n \n-- \ngitgitgadget\n"},{"id":"383787","messageId":"20191010102828.GA12497@cat","threadId":"52004","inReplyTo":"572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc(stash): clarify the description of `save`","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2019-10-10T10:28:28Z","receivedAt":"2019-10-10T10:28:33Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 10/10, Johannes Schindelin via GitGitGadget wrote:\n> From: Johannes Schindelin \n> \n> The original phrasing of this paragraph made at least one person stumble\n> over the word \"from\" (thinking that it was a typo and \"from\" was\n> intended), and other readers chimed in, agreeing that it was confusing:\n> https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t\n> \n> Let's rewrite that paragraph for clarity.\n> \n> Inspired-by-a-patch-by: Catalin Criste \n> Signed-off-by: Johannes Schindelin \n\nThanks for picking this thread up again, I had already forgotten about\nit. The updated wording sounds like an improvement to me.\n\n> ---\n> Documentation/git-stash.txt | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\n> index 8fbe12c66c..53e1a1205d 100644\n> --- a/Documentation/git-stash.txt\n> +++ b/Documentation/git-stash.txt\n> @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use\n> save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []::\n> \n> \tThis option is deprecated in favour of 'git stash push'. It\n> -\tdiffers from \"stash push\" in that it cannot take pathspecs,\n> -\tand any non-option arguments form the message.\n> +\tdiffers from \"stash push\" in that it cannot take pathspecs.\n> +\tInstead, all non-option arguments are concatenated to form the stash\n> +\tmessage.\n> \n> list []::\n> \n> -- \n> gitgitgadget\n"},{"id":"383868","messageId":"xmqq36fzj1d4.fsf@gitster-ct.c.googlers.com","threadId":"52004","inReplyTo":"20191010102828.GA12497@cat","subject":"Re: [PATCH 1/1] doc(stash): clarify the description of `save`","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-10-11T05:29:59Z","receivedAt":"2019-10-11T05:30:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Gummerer writes:\n\n> On 10/10, Johannes Schindelin via GitGitGadget wrote:\n>> From: Johannes Schindelin \n>> \n>> The original phrasing of this paragraph made at least one person stumble\n>> over the word \"from\" (thinking that it was a typo and \"from\" was\n>> intended), and other readers chimed in, agreeing that it was confusing:\n>> https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t\n>> \n>> Let's rewrite that paragraph for clarity.\n>> \n>> Inspired-by-a-patch-by: Catalin Criste \n>> Signed-off-by: Johannes Schindelin \n>\n> Thanks for picking this thread up again, I had already forgotten about\n> it. The updated wording sounds like an improvement to me.\n\nTo me too. I would have just done s/form/become/ out of laziness\nand aiming for conciseness, but the new and separate sentence is\ngood, too.\n\nThanks, both.\n\n>\n>> ---\n>> Documentation/git-stash.txt | 5 +++--\n>> 1 file changed, 3 insertions(+), 2 deletions(-)\n>> \n>> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\n>> index 8fbe12c66c..53e1a1205d 100644\n>> --- a/Documentation/git-stash.txt\n>> +++ b/Documentation/git-stash.txt\n>> @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use\n>> save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] []::\n>> \n>> \tThis option is deprecated in favour of 'git stash push'. It\n>> -\tdiffers from \"stash push\" in that it cannot take pathspecs,\n>> -\tand any non-option arguments form the message.\n>> +\tdiffers from \"stash push\" in that it cannot take pathspecs.\n>> +\tInstead, all non-option arguments are concatenated to form the stash\n>> +\tmessage.\n>> \n>> list []::\n>> \n>> -- \n>> gitgitgadget\n"}]}