{"thread":{"id":"52002","subject":"[PATCH] Makefile: respect $(V) in %.cocci.patch target","startedAt":"2019-10-09T20:43:52Z","lastAt":"2019-10-10T12:00:34Z","messageCount":2,"participants":["Denton Liu","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"383764","messageId":"977b19bcf3ef34395288933eb0090b6d9c58864f.1570653788.git.liu.denton@gmail.com","threadId":"52002","inReplyTo":null,"subject":"[PATCH] Makefile: respect $(V) in %.cocci.patch target","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-10-09T20:43:46Z","receivedAt":"2019-10-09T20:43:52Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"When the %.cocci.patch target was defined in 63f0a758a0 (add coccicheck\nmake target, 2016-09-15), it included a mechanism to suppress the noisy\noutput, similar to the $(QUIET_<x>) family of variables.\n\nIn the case where one wants to inspect the output hidden by\n$(QUIET_<x>), one could define $(V) for verbose output. In the\n%.cocci.patch target, this was not implemented.\n\nMove the output suppression into the $(QUIET_SPATCH) variable which is\nused like the other $(QUIET_<x>) variables. While we're at it, change\nthe number of spaces printed from 5 to 4, like the other variables\nthere.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n Makefile | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex c99361e719..ae45bfc429 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1890,6 +1890,7 @@ ifndef V\n \tQUIET_SP       = @echo '   ' SP $<;\n \tQUIET_HDR      = @echo '   ' HDR $(<:hcc=h);\n \tQUIET_RC       = @echo '   ' RC $@;\n+\tQUIET_SPATCH   = @echo '   ' SPATCH $<;\n \tQUIET_SUBDIR0  = +@subdir=\n \tQUIET_SUBDIR1  = ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \\\n \t\t\t $(MAKE) $(PRINT_DIR) -C $$subdir\n@@ -2818,7 +2819,7 @@ FOUND_C_SOURCES = $(filter %.c,$(shell $(FIND_SOURCE_FILES)))\n COCCI_SOURCES = $(filter-out $(THIRD_PARTY_SOURCES),$(FOUND_C_SOURCES))\n \n %.cocci.patch: %.cocci $(COCCI_SOURCES)\n-\t@echo '    ' SPATCH $<; \\\n+\t$(QUIET_SPATCH) \\\n \tif test $(SPATCH_BATCH_SIZE) = 0; then \\\n \t\tlimit=; \\\n \telse \\\n-- \n2.23.0.746.g72fc0fc0b9\n\n"},{"id":"383794","messageId":"nycvar.QRO.7.76.6.1910101359530.46@tvgsbejvaqbjf.bet","threadId":"52002","inReplyTo":"977b19bcf3ef34395288933eb0090b6d9c58864f.1570653788.git.liu.denton@gmail.com","subject":"Re: [PATCH] Makefile: respect $(V) in %.cocci.patch target","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-10-10T12:00:14Z","receivedAt":"2019-10-10T12:00:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Denton,\n\nOn Wed, 9 Oct 2019, Denton Liu wrote:\n\n> When the %.cocci.patch target was defined in 63f0a758a0 (add coccicheck\n> make target, 2016-09-15), it included a mechanism to suppress the noisy\n> output, similar to the $(QUIET_<x>) family of variables.\n>\n> In the case where one wants to inspect the output hidden by\n> $(QUIET_<x>), one could define $(V) for verbose output. In the\n> %.cocci.patch target, this was not implemented.\n>\n> Move the output suppression into the $(QUIET_SPATCH) variable which is\n> used like the other $(QUIET_<x>) variables. While we're at it, change\n> the number of spaces printed from 5 to 4, like the other variables\n> there.\n>\n> Signed-off-by: Denton Liu <liu.denton@gmail.com>\n> ---\n\nLooks obviously correct to me.\n\nThanks,\nDscho\n\n>  Makefile | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/Makefile b/Makefile\n> index c99361e719..ae45bfc429 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1890,6 +1890,7 @@ ifndef V\n>  \tQUIET_SP       = @echo '   ' SP $<;\n>  \tQUIET_HDR      = @echo '   ' HDR $(<:hcc=h);\n>  \tQUIET_RC       = @echo '   ' RC $@;\n> +\tQUIET_SPATCH   = @echo '   ' SPATCH $<;\n>  \tQUIET_SUBDIR0  = +@subdir=\n>  \tQUIET_SUBDIR1  = ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \\\n>  \t\t\t $(MAKE) $(PRINT_DIR) -C $$subdir\n> @@ -2818,7 +2819,7 @@ FOUND_C_SOURCES = $(filter %.c,$(shell $(FIND_SOURCE_FILES)))\n>  COCCI_SOURCES = $(filter-out $(THIRD_PARTY_SOURCES),$(FOUND_C_SOURCES))\n>\n>  %.cocci.patch: %.cocci $(COCCI_SOURCES)\n> -\t@echo '    ' SPATCH $<; \\\n> +\t$(QUIET_SPATCH) \\\n>  \tif test $(SPATCH_BATCH_SIZE) = 0; then \\\n>  \t\tlimit=; \\\n>  \telse \\\n> --\n> 2.23.0.746.g72fc0fc0b9\n>\n>\n"}]}