{"thread":{"id":"51892","subject":"[PATCH] promisor-remote.h: drop extern from function declaration","startedAt":"2019-09-21T00:03:53Z","lastAt":"2019-09-21T00:03:53Z","messageCount":1,"participants":["Denton Liu"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"382716","messageId":"96a3cee1dd4700a9e033f545db5891e4fa8c073d.1569024025.git.liu.denton@gmail.com","threadId":"51892","inReplyTo":null,"subject":"[PATCH] promisor-remote.h: drop extern from function declaration","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-09-21T00:03:48Z","receivedAt":"2019-09-21T00:03:53Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"During the creation of this file, each time a new function declaration\nwas introduced, it included an `extern`. However, starting from\n554544276a (*.[ch]: remove extern from function declarations using\nspatch, 2019-04-29), we've been actively trying to prevent externs from\nbeing used in function declarations because they're unnecessary.\n\nRemove these spurious `extern`s.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n\nThis patch should be placed on the tip of cc/multi-promisor.\n\nI wonder if there's any way we can automate this check...\n\n promisor-remote.h | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/promisor-remote.h b/promisor-remote.h\nindex 8200dfc940..c60aaa5cce 100644\n--- a/promisor-remote.h\n+++ b/promisor-remote.h\n@@ -15,17 +15,17 @@ struct promisor_remote {\n \tconst char name[FLEX_ARRAY];\n };\n \n-extern void promisor_remote_reinit(void);\n-extern struct promisor_remote *promisor_remote_find(const char *remote_name);\n-extern int has_promisor_remote(void);\n-extern int promisor_remote_get_direct(struct repository *repo,\n-\t\t\t\t      const struct object_id *oids,\n-\t\t\t\t      int oid_nr);\n+void promisor_remote_reinit(void);\n+struct promisor_remote *promisor_remote_find(const char *remote_name);\n+int has_promisor_remote(void);\n+int promisor_remote_get_direct(struct repository *repo,\n+\t\t\t       const struct object_id *oids,\n+\t\t\t       int oid_nr);\n \n /*\n  * This should be used only once from setup.c to set the value we got\n  * from the extensions.partialclone config option.\n  */\n-extern void set_repository_format_partial_clone(char *partial_clone);\n+void set_repository_format_partial_clone(char *partial_clone);\n \n #endif /* PROMISOR_REMOTE_H */\n-- \n2.23.0.565.g1cc52d20df\n\n"}]}