{"thread":{"id":"51891","subject":"[PATCH] t4038: Remove non-portable '-a' option passed to test_cmp","startedAt":"2019-09-20T22:11:22Z","lastAt":"2019-09-23T16:52:23Z","messageCount":2,"participants":["CB Bailey","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"382714","messageId":"20190920220601.8090-1-cb@hashpling.org","threadId":"51891","inReplyTo":null,"subject":"[PATCH] t4038: Remove non-portable '-a' option passed to test_cmp","fromName":"CB Bailey","fromEmail":"cb@hashpling.org","sentAt":"2019-09-20T22:06:01Z","receivedAt":"2019-09-20T22:11:22Z","isPatch":true,"sender":{"key":"cb@hashpling.org","avatar":null},"body":"From: CB Bailey <cbailey32@bloomberg.net>\n\nSigned-off-by: CB Bailey <cbailey32@bloomberg.net>\n---\n t/t4038-diff-combined.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh\nindex d4afe12554..b9d876efa2 100755\n--- a/t/t4038-diff-combined.sh\n+++ b/t/t4038-diff-combined.sh\n@@ -509,7 +509,7 @@ test_expect_success FUNNYNAMES '--combined-all-paths and --raw and funny names'\n test_expect_success FUNNYNAMES '--combined-all-paths and --raw -and -z and funny names' '\n \tprintf \"aaf8087c3cbd4db8e185a2d074cf27c53cfb75d7\\0::100644 100644 100644 f00c965d8307308469e537302baa73048488f162 088bd5d92c2a8e0203ca8e7e4c2a5c692f6ae3f7 333b9c62519f285e1854830ade0fe1ef1d40ee1b RR\\0file\\twith\\ttabs\\0i\\tam\\ttabbed\\0fickle\\tnaming\\0\" >expect &&\n \tgit diff-tree -c -M --raw --combined-all-paths -z HEAD >actual &&\n-\ttest_cmp -a expect actual\n+\ttest_cmp expect actual\n '\n \n test_expect_success FUNNYNAMES '--combined-all-paths and --cc and funny names' '\n-- \n2.23.0.1.g68c7121409\n\n"},{"id":"382773","messageId":"CABPp-BFF1Vqa7QoH6s1Vf6QtXcBoy1v7XzSsLjOTOCVh4GL3vg@mail.gmail.com","threadId":"51891","inReplyTo":"20190920220601.8090-1-cb@hashpling.org","subject":"Re: [PATCH] t4038: Remove non-portable '-a' option passed to test_cmp","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2019-09-23T16:52:10Z","receivedAt":"2019-09-23T16:52:23Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Fri, Sep 20, 2019 at 3:07 PM CB Bailey <cb@hashpling.org> wrote:\n>\n> From: CB Bailey <cbailey32@bloomberg.net>\n>\n> Signed-off-by: CB Bailey <cbailey32@bloomberg.net>\n> ---\n>  t/t4038-diff-combined.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh\n> index d4afe12554..b9d876efa2 100755\n> --- a/t/t4038-diff-combined.sh\n> +++ b/t/t4038-diff-combined.sh\n> @@ -509,7 +509,7 @@ test_expect_success FUNNYNAMES '--combined-all-paths and --raw and funny names'\n>  test_expect_success FUNNYNAMES '--combined-all-paths and --raw -and -z and funny names' '\n>         printf \"aaf8087c3cbd4db8e185a2d074cf27c53cfb75d7\\0::100644 100644 100644 f00c965d8307308469e537302baa73048488f162 088bd5d92c2a8e0203ca8e7e4c2a5c692f6ae3f7 333b9c62519f285e1854830ade0fe1ef1d40ee1b RR\\0file\\twith\\ttabs\\0i\\tam\\ttabbed\\0fickle\\tnaming\\0\" >expect &&\n>         git diff-tree -c -M --raw --combined-all-paths -z HEAD >actual &&\n> -       test_cmp -a expect actual\n> +       test_cmp expect actual\n>  '\n\nThis will mean slightly less useful diagnostic output should the test\never fail on a platform that does support diff -a, but that's a small\nprice to pay to make sure the test is portable.  If anyone does ever\nsee this test fail, they can go in and inspect further themselves.\n\nThanks for the fix.\n"}]}