{"thread":{"id":"51885","subject":"[PATCH] doc: MyFirstContribution: fix cmd placement instructions","startedAt":"2019-09-19T18:47:33Z","lastAt":"2019-09-26T21:42:07Z","messageCount":5,"participants":["Pedro Sousa","Emily Shaffer","Philip Oakley"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"382603","messageId":"20190919184634.8869-1-pedroteosousa@gmail.com","threadId":"51885","inReplyTo":null,"subject":"[PATCH] doc: MyFirstContribution: fix cmd placement instructions","fromName":"Pedro Sousa","fromEmail":"pedroteosousa@gmail.com","sentAt":"2019-09-19T18:46:34Z","receivedAt":"2019-09-19T18:47:33Z","isPatch":true,"sender":{"key":"pedroteosousa@gmail.com","avatar":null},"body":"Using the pull command instead of push is more accurate when giving\ninstructions on placing the psuh command in alphabetical order.\n\nSigned-off-by: Pedro Sousa \n---\n Documentation/MyFirstContribution.txt | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\nindex f867037..fb15af8 100644\n--- a/Documentation/MyFirstContribution.txt\n+++ b/Documentation/MyFirstContribution.txt\n@@ -97,7 +97,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n ----\n \n We'll also need to add the declaration of psuh; open up `builtin.h`, find the\n-declaration for `cmd_push`, and add a new line for `psuh` immediately before it,\n+declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,\n in order to keep the declarations sorted:\n \n ----\n@@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n }\n ----\n \n-Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added\n+Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added\n to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in\n alphabetical order. Once you've done so, move to the top-level directory and\n build simply with `make`. Also add the `DEVELOPER=1` variable to turn on\n@@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string\n with the command name, a function pointer to the command implementation, and a\n setup option flag. For now, let's keep mimicking `push`. Find the line where\n `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new\n-line in alphabetical order.\n+line in alphabetical order (immediately before `cmd_pull`).\n \n The options are documented in `builtin.h` under \"Adding a new built-in.\" Since\n we hope to print some data about the user's current workspace context later,\n@@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.\n \n `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as\n untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,\n-which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and\n+which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and\n add an entry for your new command in alphabetical order:\n \n ----\n-- \n2.9.3\n\n"},{"id":"382610","messageId":"20190919204627.GB116396@google.com","threadId":"51885","inReplyTo":"20190919184634.8869-1-pedroteosousa@gmail.com","subject":"Re: [PATCH] doc: MyFirstContribution: fix cmd placement instructions","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2019-09-19T20:46:27Z","receivedAt":"2019-09-19T20:46:35Z","isPatch":true,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"Thanks for sending this. I guess I don't know the alphabet very well :)\n\nA different color we could paint the bikeshed would be to write \"add a\nnew line for `psuh` immediately after it\" in these places instead. But I\nhave no preference whatsoever.\n\n - Emily\n\nReviewed-by: Emily Shaffer \n\nOn Thu, Sep 19, 2019 at 03:46:34PM -0300, Pedro Sousa wrote:\n> Using the pull command instead of push is more accurate when giving\n> instructions on placing the psuh command in alphabetical order.\n> \n> Signed-off-by: Pedro Sousa \n> ---\n> Documentation/MyFirstContribution.txt | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\n> index f867037..fb15af8 100644\n> --- a/Documentation/MyFirstContribution.txt\n> +++ b/Documentation/MyFirstContribution.txt\n> @@ -97,7 +97,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n> ----\n> \n> We'll also need to add the declaration of psuh; open up `builtin.h`, find the\n> -declaration for `cmd_push`, and add a new line for `psuh` immediately before it,\n> +declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,\n> in order to keep the declarations sorted:\n> \n> ----\n> @@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n> }\n> ----\n> \n> -Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added\n> +Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added\n> to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in\n> alphabetical order. Once you've done so, move to the top-level directory and\n> build simply with `make`. Also add the `DEVELOPER=1` variable to turn on\n> @@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string\n> with the command name, a function pointer to the command implementation, and a\n> setup option flag. For now, let's keep mimicking `push`. Find the line where\n> `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new\n> -line in alphabetical order.\n> +line in alphabetical order (immediately before `cmd_pull`).\n> \n> The options are documented in `builtin.h` under \"Adding a new built-in.\" Since\n> we hope to print some data about the user's current workspace context later,\n> @@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.\n> \n> `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as\n> untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,\n> -which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and\n> +which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and\n> add an entry for your new command in alphabetical order:\n> \n> ----\n> -- \n> 2.9.3\n> \n"},{"id":"382648","messageId":"bba245d1-2828-e356-6f78-6a0bb47cc7e1@iee.email","threadId":"51885","inReplyTo":"20190919204627.GB116396@google.com","subject":"Re: [PATCH] doc: MyFirstContribution: fix cmd placement instructions","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2019-09-20T09:42:40Z","receivedAt":"2019-09-20T09:42:47Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 19/09/2019 21:46, Emily Shaffer wrote:\n> Thanks for sending this. I guess I don't know the alphabet very well :)\n>\n> A different color we could paint the bikeshed would be to write \"add a\n> new line for `psuh` immediately after it\" in these places instead. But I\n> have no preference whatsoever.\n>\n> - Emily\n>\n> Reviewed-by: Emily Shaffer \n>\n> On Thu, Sep 19, 2019 at 03:46:34PM -0300, Pedro Sousa wrote:\n>> Using the pull command instead of push is more accurate when giving\n>> instructions on placing the psuh command in alphabetical order.\n>>\n>> Signed-off-by: Pedro Sousa \n>> ---\n>> Documentation/MyFirstContribution.txt | 8 ++++----\n>> 1 file changed, 4 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\n>> index f867037..fb15af8 100644\n>> --- a/Documentation/MyFirstContribution.txt\n>> +++ b/Documentation/MyFirstContribution.txt\n>> @@ -97,7 +97,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n>> ----\n>> \n>> We'll also need to add the declaration of psuh; open up `builtin.h`, find the\n>> -declaration for `cmd_push`, and add a new line for `psuh` immediately before it,\n>> +declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,\nMaybe feature the \"alphabetical\" sort order (i.e. include the word \nhere), so that other see it (use of alphabetical sorting) that little \nmore obviously in the tutorial material.\nPhilip\n>> in order to keep the declarations sorted:\n>> \n>> ----\n>> @@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n>> }\n>> ----\n>> \n>> -Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added\n>> +Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added\n>> to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in\n>> alphabetical order. Once you've done so, move to the top-level directory and\n>> build simply with `make`. Also add the `DEVELOPER=1` variable to turn on\n>> @@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string\n>> with the command name, a function pointer to the command implementation, and a\n>> setup option flag. For now, let's keep mimicking `push`. Find the line where\n>> `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new\n>> -line in alphabetical order.\n>> +line in alphabetical order (immediately before `cmd_pull`).\n>> \n>> The options are documented in `builtin.h` under \"Adding a new built-in.\" Since\n>> we hope to print some data about the user's current workspace context later,\n>> @@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.\n>> \n>> `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as\n>> untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,\n>> -which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and\n>> +which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and\n>> add an entry for your new command in alphabetical order:\n>> \n>> ----\n>> -- \n>> 2.9.3\n>>\n\n"},{"id":"383015","messageId":"20190926190522.3424-1-pedroteosousa@gmail.com","threadId":"51885","inReplyTo":"20190919184634.8869-1-pedroteosousa@gmail.com","subject":"[PATCH v2] doc: MyFirstContribution: fix cmd placement instructions","fromName":"Pedro Sousa","fromEmail":"pedroteosousa@gmail.com","sentAt":"2019-09-26T19:05:22Z","receivedAt":"2019-09-26T19:05:45Z","isPatch":true,"sender":{"key":"pedroteosousa@gmail.com","avatar":null},"body":"Using the pull command instead of push is more accurate when giving\ninstructions on placing the psuh command in alphabetical order.\n\nSigned-off-by: Pedro Sousa \n---\nChanges since v1: Addressed Philip's comments on making alphabetical\nsort instructions more explicit\n\n Documentation/MyFirstContribution.txt | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\nindex f867037..5e9b808 100644\n--- a/Documentation/MyFirstContribution.txt\n+++ b/Documentation/MyFirstContribution.txt\n@@ -97,8 +97,8 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n ----\n \n We'll also need to add the declaration of psuh; open up `builtin.h`, find the\n-declaration for `cmd_push`, and add a new line for `psuh` immediately before it,\n-in order to keep the declarations sorted:\n+declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,\n+in order to keep the declarations alphabetically sorted:\n \n ----\n int cmd_psuh(int argc, const char **argv, const char *prefix);\n@@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n }\n ----\n \n-Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added\n+Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added\n to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in\n alphabetical order. Once you've done so, move to the top-level directory and\n build simply with `make`. Also add the `DEVELOPER=1` variable to turn on\n@@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string\n with the command name, a function pointer to the command implementation, and a\n setup option flag. For now, let's keep mimicking `push`. Find the line where\n `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new\n-line in alphabetical order.\n+line in alphabetical order (immediately before `cmd_pull`).\n \n The options are documented in `builtin.h` under \"Adding a new built-in.\" Since\n we hope to print some data about the user's current workspace context later,\n@@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.\n \n `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as\n untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,\n-which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and\n+which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and\n add an entry for your new command in alphabetical order:\n \n ----\n-- \n2.9.3\n\n"},{"id":"383038","messageId":"0a52455d-9859-587e-9c88-bf47676b9b28@iee.email","threadId":"51885","inReplyTo":"20190926190522.3424-1-pedroteosousa@gmail.com","subject":"Re: [PATCH v2] doc: MyFirstContribution: fix cmd placement instructions","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2019-09-26T21:42:03Z","receivedAt":"2019-09-26T21:42:07Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 26/09/2019 20:05, Pedro Sousa wrote:\n> Using the pull command instead of push is more accurate when giving\n> instructions on placing the psuh command in alphabetical order.\n>\n> Signed-off-by: Pedro Sousa \n> ---\n> Changes since v1: Addressed Philip's comments on making alphabetical\n> sort instructions more explicit\n\nLGTM. Thanks.\nPhilip\n>\n> Documentation/MyFirstContribution.txt | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt\n> index f867037..5e9b808 100644\n> --- a/Documentation/MyFirstContribution.txt\n> +++ b/Documentation/MyFirstContribution.txt\n> @@ -97,8 +97,8 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n> ----\n> \n> We'll also need to add the declaration of psuh; open up `builtin.h`, find the\n> -declaration for `cmd_push`, and add a new line for `psuh` immediately before it,\n> -in order to keep the declarations sorted:\n> +declaration for `cmd_pull`, and add a new line for `psuh` immediately before it,\n> +in order to keep the declarations alphabetically sorted:\n> \n> ----\n> int cmd_psuh(int argc, const char **argv, const char *prefix);\n> @@ -123,7 +123,7 @@ int cmd_psuh(int argc, const char **argv, const char *prefix)\n> }\n> ----\n> \n> -Let's try to build it. Open `Makefile`, find where `builtin/push.o` is added\n> +Let's try to build it. Open `Makefile`, find where `builtin/pull.o` is added\n> to `BUILTIN_OBJS`, and add `builtin/psuh.o` in the same way next to it in\n> alphabetical order. Once you've done so, move to the top-level directory and\n> build simply with `make`. Also add the `DEVELOPER=1` variable to turn on\n> @@ -149,7 +149,7 @@ a `cmd_struct` to the `commands[]` array. `struct cmd_struct` takes a string\n> with the command name, a function pointer to the command implementation, and a\n> setup option flag. For now, let's keep mimicking `push`. Find the line where\n> `cmd_push` is registered, copy it, and modify it for `cmd_psuh`, placing the new\n> -line in alphabetical order.\n> +line in alphabetical order (immediately before `cmd_pull`).\n> \n> The options are documented in `builtin.h` under \"Adding a new built-in.\" Since\n> we hope to print some data about the user's current workspace context later,\n> @@ -167,7 +167,7 @@ Check it out! You've got a command! Nice work! Let's commit this.\n> \n> `git status` reveals modified `Makefile`, `builtin.h`, and `git.c` as well as\n> untracked `builtin/psuh.c` and `git-psuh`. First, let's take care of the binary,\n> -which should be ignored. Open `.gitignore` in your editor, find `/git-push`, and\n> +which should be ignored. Open `.gitignore` in your editor, find `/git-pull`, and\n> add an entry for your new command in alphabetical order:\n> \n> ----\n\n"}]}