{"thread":{"id":"51863","subject":"[PATCH] gitk: rename zh_CN.po to zh_cn.po","startedAt":"2019-09-17T08:52:50Z","lastAt":"2019-09-17T22:14:37Z","messageCount":3,"participants":["Denton Liu","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"382475","messageId":"6feff2e73e1c4ca838efcabe90e0978a4d88cb7d.1568710294.git.liu.denton@gmail.com","threadId":"51863","inReplyTo":null,"subject":"[PATCH] gitk: rename zh_CN.po to zh_cn.po","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-09-17T08:52:06Z","receivedAt":"2019-09-17T08:52:50Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"When running make from a clean environment, all of the *.po files should\nbe converted into *.msg files. After that, when make is run without any\nchanges, make should not do anything.\n\nAfter beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11),\nzh_CN.po was introduced. When make was run, a zh_cn.msg file was\ngenerated (notice the lowercase). However, since make is case-sensitive,\nit expects zh_CN.po to generate a zh_CN.msg file so make will keep\nreattempting to generate a zh_CN.msg so successive make invocations\nresult in\n\n    Generating catalog po/zh_cn.msg\n    msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/\n    317 translated messages.\n\nhappening continuously.\n\nRename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg\nfile, it will realize that it was successfully generated and only run\nonce.\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\n po/{zh_CN.po => zh_cn.po} | 0\n 1 file changed, 0 insertions(+), 0 deletions(-)\n rename po/{zh_CN.po => zh_cn.po} (100%)\n\ndiff --git a/po/zh_CN.po b/po/zh_cn.po\nsimilarity index 100%\nrename from po/zh_CN.po\nrename to po/zh_cn.po\n-- \n2.23.0.248.g3a9dd8fb08\n\n"},{"id":"382510","messageId":"xmqq36guamym.fsf@gitster-ct.c.googlers.com","threadId":"51863","inReplyTo":"6feff2e73e1c4ca838efcabe90e0978a4d88cb7d.1568710294.git.liu.denton@gmail.com","subject":"Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-09-17T16:48:01Z","receivedAt":"2019-09-17T16:48:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Denton Liu <liu.denton@gmail.com> writes:\n\n> When running make from a clean environment, all of the *.po files should\n> be converted into *.msg files. After that, when make is run without any\n> changes, make should not do anything.\n>\n> After beffae768a (gitk: Add Chinese (zh_CN) translation, 2017-03-11),\n> zh_CN.po was introduced. When make was run, a zh_cn.msg file was\n> generated (notice the lowercase). However, since make is case-sensitive,\n> it expects zh_CN.po to generate a zh_CN.msg file so make will keep\n> reattempting to generate a zh_CN.msg so successive make invocations\n> result in\n>\n>     Generating catalog po/zh_cn.msg\n>     msgfmt --statistics --tcl po/zh_cn.po -l zh_cn -d po/\n>     317 translated messages.\n>\n> happening continuously.\n>\n> Rename zh_CN.po to zh_cn.po so that when make generates the zh_cn.msg\n> file, it will realize that it was successfully generated and only run\n> once.\n\nTrue, and it is not just that.  The install target would fail\nbecause it cannot find zh_CN.msg, I think.\n\n> Signed-off-by: Denton Liu <liu.denton@gmail.com>\n> ---\n>  po/{zh_CN.po => zh_cn.po} | 0\n>  1 file changed, 0 insertions(+), 0 deletions(-)\n>  rename po/{zh_CN.po => zh_cn.po} (100%)\n>\n> diff --git a/po/zh_CN.po b/po/zh_cn.po\n> similarity index 100%\n> rename from po/zh_CN.po\n> rename to po/zh_cn.po\n\nThis would make this in line with pt_{pt,br}.po, existing locales\nwith country code in them.\n\nReviewed-by: Junio C Hamano <gitster@pobox.com>\n"},{"id":"382524","messageId":"xmqqlfum7epn.fsf@gitster-ct.c.googlers.com","threadId":"51863","inReplyTo":"xmqq36guamym.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] gitk: rename zh_CN.po to zh_cn.po","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-09-17T22:14:28Z","receivedAt":"2019-09-17T22:14:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n> This would make this in line with pt_{pt,br}.po, existing locales\n> with country code in them.\n>\n> Reviewed-by: Junio C Hamano <gitster@pobox.com>\n\nPaul, I've applied this to a clone of gitk locally and merged it\n(resutling in 2a4ac71ffb that should be reachable from 'master'), as\nit was breaking my \"install\" tests.\n\nThanks.\n"}]}