{"thread":{"id":"51822","subject":"[PATCH 0/1] Fix perl error \"unescaped left brace in regex\" for paranoid update hook","startedAt":"2019-09-10T06:39:38Z","lastAt":"2019-09-12T08:57:08Z","messageCount":6,"participants":["Dominic Winkler via GitGitGadget","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"382117","messageId":"pull.335.git.gitgitgadget@gmail.com","threadId":"51822","inReplyTo":null,"subject":"[PATCH 0/1] Fix perl error \"unescaped left brace in regex\" for paranoid update hook","fromName":"Dominic Winkler via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-10T06:39:34Z","receivedAt":"2019-09-10T06:39:38Z","isPatch":true,"sender":{"key":"name:Dominic Winkler","avatar":null},"body":"A literal \"{\" should now be escaped in a pattern starting from perl versions\n>= v5.26. In perl v5.22, using a literal { in a regular expression was\ndeprecated, and will emit a warning if it isn't escaped: {. In v5.26, this\nwon't just warn, it'll cause a syntax error.\n\n(see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n\nSigned-off-by: Dominic Winkler d.winkler@flexarts.at [d.winkler@flexarts.at]\n\nDominic Winkler (1):\n Fix perl error \"unescaped left brace in regex\" for paranoid update\n hook\n\n contrib/hooks/update-paranoid | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-335%2Fflexarts%2Fmaint-update-paranoid-perlv5.26-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-335/flexarts/maint-update-paranoid-perlv5.26-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/335\n-- \ngitgitgadget\n"},{"id":"382118","messageId":"2743caa22e60c5ddc04d388f21a04500d7bcac1f.1568097573.git.gitgitgadget@gmail.com","threadId":"51822","inReplyTo":"pull.335.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] Fix perl error \"unescaped left brace in regex\" for paranoid update hook","fromName":"Dominic Winkler via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-10T06:39:35Z","receivedAt":"2019-09-10T06:39:38Z","isPatch":true,"sender":{"key":"name:Dominic Winkler","avatar":null},"body":"From: Dominic Winkler \n\nA literal \"{\" should now be escaped in a pattern starting from perl\nversions >= v5.26. In perl v5.22, using a literal { in a regular\nexpression was deprecated, and will emit a warning if it isn't escaped: \\{.\nIn v5.26, this won't just warn, it'll cause a syntax error.\n\n(see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n\nSigned-off-by: Dominic Winkler \n---\n contrib/hooks/update-paranoid | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid\nindex d18b317b2f..fc0a242a4e 100755\n--- a/contrib/hooks/update-paranoid\n+++ b/contrib/hooks/update-paranoid\n@@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R'\n \n RULE:\n \tforeach (@$rules) {\n-\t\twhile (/\\${user\\.([a-z][a-zA-Z0-9]+)}/) {\n+\t\twhile (/\\$\\{user\\.([a-z][a-zA-Z0-9]+)}/) {\n \t\t\tmy $k = lc $1;\n \t\t\tmy $v = $data{\"user.$k\"};\n \t\t\tnext RULE unless defined $v;\n \t\t\tnext RULE if @$v != 1;\n \t\t\tnext RULE unless defined $v->[0];\n-\t\t\ts/\\${user\\.$k}/$v->[0]/g;\n+\t\t\ts/\\$\\{user\\.$k}/$v->[0]/g;\n \t\t}\n \n \t\tif (/^([AMD ]+)\\s+of\\s+([^\\s]+)\\s+for\\s+([^\\s]+)\\s+diff\\s+([^\\s]+)$/) {\n-- \ngitgitgadget\n"},{"id":"382187","messageId":"nycvar.QRO.7.76.6.1909112326490.5377@tvgsbejvaqbjf.bet","threadId":"51822","inReplyTo":"2743caa22e60c5ddc04d388f21a04500d7bcac1f.1568097573.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] Fix perl error \"unescaped left brace in regex\" for paranoid update hook","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-09-11T21:28:26Z","receivedAt":"2019-09-11T21:28:46Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Dominic,\n\nall looks good, with one exception: the Subject should start with\n`:`, i.e. in this instance something like this would be better:\n\ncontrib/hooks: escape left brace in regex in the paranoid update hook\n\nCiao,\nJohannes\n\nOn Mon, 9 Sep 2019, Dominic Winkler via GitGitGadget wrote:\n\n> From: Dominic Winkler \n>\n> A literal \"{\" should now be escaped in a pattern starting from perl\n> versions >= v5.26. In perl v5.22, using a literal { in a regular\n> expression was deprecated, and will emit a warning if it isn't escaped: \\{.\n> In v5.26, this won't just warn, it'll cause a syntax error.\n>\n> (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n>\n> Signed-off-by: Dominic Winkler \n> ---\n> contrib/hooks/update-paranoid | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid\n> index d18b317b2f..fc0a242a4e 100755\n> --- a/contrib/hooks/update-paranoid\n> +++ b/contrib/hooks/update-paranoid\n> @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R'\n>\n> RULE:\n> \tforeach (@$rules) {\n> -\t\twhile (/\\${user\\.([a-z][a-zA-Z0-9]+)}/) {\n> +\t\twhile (/\\$\\{user\\.([a-z][a-zA-Z0-9]+)}/) {\n> \t\t\tmy $k = lc $1;\n> \t\t\tmy $v = $data{\"user.$k\"};\n> \t\t\tnext RULE unless defined $v;\n> \t\t\tnext RULE if @$v != 1;\n> \t\t\tnext RULE unless defined $v->[0];\n> -\t\t\ts/\\${user\\.$k}/$v->[0]/g;\n> +\t\t\ts/\\$\\{user\\.$k}/$v->[0]/g;\n> \t\t}\n>\n> \t\tif (/^([AMD ]+)\\s+of\\s+([^\\s]+)\\s+for\\s+([^\\s]+)\\s+diff\\s+([^\\s]+)$/) {\n> --\n> gitgitgadget\n>\n"},{"id":"382188","messageId":"pull.335.v2.git.gitgitgadget@gmail.com","threadId":"51822","inReplyTo":"pull.335.git.gitgitgadget@gmail.com","subject":"[PATCH v2 0/1] Fix perl error \"unescaped left brace in regex\" for paranoid update hook","fromName":"Dominic Winkler via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-11T21:47:21Z","receivedAt":"2019-09-11T21:47:26Z","isPatch":true,"sender":{"key":"name:Dominic Winkler","avatar":null},"body":"A literal \"{\" should now be escaped in a pattern starting from perl versions\n>= v5.26. In perl v5.22, using a literal { in a regular expression was\ndeprecated, and will emit a warning if it isn't escaped: {. In v5.26, this\nwon't just warn, it'll cause a syntax error.\n\n(see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n\nSigned-off-by: Dominic Winkler d.winkler@flexarts.at [d.winkler@flexarts.at]\n\nDominic Winkler (1):\n contrib/hooks: escape left brace in regex in the paranoid update hook\n\n contrib/hooks/update-paranoid | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-335%2Fflexarts%2Fmaint-update-paranoid-perlv5.26-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-335/flexarts/maint-update-paranoid-perlv5.26-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/335\n\nRange-diff vs v1:\n\n 1: 2743caa22e ! 1: 0d762cfb50 Fix perl error \"unescaped left brace in regex\" for paranoid update hook\n @@ -1,6 +1,6 @@\n Author: Dominic Winkler \n \n - Fix perl error \"unescaped left brace in regex\" for paranoid update hook\n + contrib/hooks: escape left brace in regex in the paranoid update hook\n \n A literal \"{\" should now be escaped in a pattern starting from perl\n versions >= v5.26. In perl v5.22, using a literal { in a regular\n\n-- \ngitgitgadget\n"},{"id":"382189","messageId":"0d762cfb503fef081af9aa3cb0fe373863237745.1568238440.git.gitgitgadget@gmail.com","threadId":"51822","inReplyTo":"pull.335.v2.git.gitgitgadget@gmail.com","subject":"[PATCH v2 1/1] contrib/hooks: escape left brace in regex in the paranoid update hook","fromName":"Dominic Winkler via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-11T21:47:22Z","receivedAt":"2019-09-11T21:47:27Z","isPatch":true,"sender":{"key":"name:Dominic Winkler","avatar":null},"body":"From: Dominic Winkler \n\nA literal \"{\" should now be escaped in a pattern starting from perl\nversions >= v5.26. In perl v5.22, using a literal { in a regular\nexpression was deprecated, and will emit a warning if it isn't escaped: \\{.\nIn v5.26, this won't just warn, it'll cause a syntax error.\n\n(see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n\nSigned-off-by: Dominic Winkler \n---\n contrib/hooks/update-paranoid | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid\nindex d18b317b2f..fc0a242a4e 100755\n--- a/contrib/hooks/update-paranoid\n+++ b/contrib/hooks/update-paranoid\n@@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R'\n \n RULE:\n \tforeach (@$rules) {\n-\t\twhile (/\\${user\\.([a-z][a-zA-Z0-9]+)}/) {\n+\t\twhile (/\\$\\{user\\.([a-z][a-zA-Z0-9]+)}/) {\n \t\t\tmy $k = lc $1;\n \t\t\tmy $v = $data{\"user.$k\"};\n \t\t\tnext RULE unless defined $v;\n \t\t\tnext RULE if @$v != 1;\n \t\t\tnext RULE unless defined $v->[0];\n-\t\t\ts/\\${user\\.$k}/$v->[0]/g;\n+\t\t\ts/\\$\\{user\\.$k}/$v->[0]/g;\n \t\t}\n \n \t\tif (/^([AMD ]+)\\s+of\\s+([^\\s]+)\\s+for\\s+([^\\s]+)\\s+diff\\s+([^\\s]+)$/) {\n-- \ngitgitgadget\n"},{"id":"382205","messageId":"nycvar.QRO.7.76.6.1909121055580.47@tvgsbejvaqbjf.bet","threadId":"51822","inReplyTo":"0d762cfb503fef081af9aa3cb0fe373863237745.1568238440.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 1/1] contrib/hooks: escape left brace in regex in the paranoid update hook","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-09-12T08:56:46Z","receivedAt":"2019-09-12T08:57:08Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Dominic,\n\nOn Wed, 11 Sep 2019, Dominic Winkler via GitGitGadget wrote:\n\n> From: Dominic Winkler \n>\n> A literal \"{\" should now be escaped in a pattern starting from perl\n> versions >= v5.26. In perl v5.22, using a literal { in a regular\n> expression was deprecated, and will emit a warning if it isn't escaped: \\{.\n> In v5.26, this won't just warn, it'll cause a syntax error.\n>\n> (see https://metacpan.org/pod/release/RJBS/perl-5.22.0/pod/perldelta.pod)\n>\n> Signed-off-by: Dominic Winkler \n\nThank you for addressing my concern so promptly. I am far from a Perl\nexpert, so take this with a train of salt: the patch now looks good to\nme!\n\nCiao,\nJohannes\n\n> ---\n> contrib/hooks/update-paranoid | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/contrib/hooks/update-paranoid b/contrib/hooks/update-paranoid\n> index d18b317b2f..fc0a242a4e 100755\n> --- a/contrib/hooks/update-paranoid\n> +++ b/contrib/hooks/update-paranoid\n> @@ -302,13 +302,13 @@ $op = 'U' if ($op eq 'R'\n>\n> RULE:\n> \tforeach (@$rules) {\n> -\t\twhile (/\\${user\\.([a-z][a-zA-Z0-9]+)}/) {\n> +\t\twhile (/\\$\\{user\\.([a-z][a-zA-Z0-9]+)}/) {\n> \t\t\tmy $k = lc $1;\n> \t\t\tmy $v = $data{\"user.$k\"};\n> \t\t\tnext RULE unless defined $v;\n> \t\t\tnext RULE if @$v != 1;\n> \t\t\tnext RULE unless defined $v->[0];\n> -\t\t\ts/\\${user\\.$k}/$v->[0]/g;\n> +\t\t\ts/\\$\\{user\\.$k}/$v->[0]/g;\n> \t\t}\n>\n> \t\tif (/^([AMD ]+)\\s+of\\s+([^\\s]+)\\s+for\\s+([^\\s]+)\\s+diff\\s+([^\\s]+)$/) {\n> --\n> gitgitgadget\n>\n"}]}