{"thread":{"id":"51820","subject":"[PATCH 1/1] doc: small formatting fix","startedAt":"2019-09-09T23:21:06Z","lastAt":"2019-09-12T18:06:22Z","messageCount":9,"participants":["Cameron Steffen via GitGitGadget","Derrick Stolee","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"382106","messageId":"5248e3332c90e91c1c6a911090d331f005789014.1568071262.git.gitgitgadget@gmail.com","threadId":"51820","inReplyTo":"pull.330.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] doc: small formatting fix","fromName":"Cameron Steffen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-09T23:21:03Z","receivedAt":"2019-09-09T23:21:06Z","isPatch":true,"sender":{"key":"cam.steffen94@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5565418?v=4"},"body":"From: Cameron Steffen <cam.steffen94@gmail.com>\n\nmove an incorrectly placed backtick\n\nSigned-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n---\n Documentation/pretty-formats.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\nindex 079598307a..b87e2e83e6 100644\n--- a/Documentation/pretty-formats.txt\n+++ b/Documentation/pretty-formats.txt\n@@ -208,7 +208,7 @@ endif::git-rev-list[]\n '%GP':: show the fingerprint of the primary key whose subkey was used\n \tto sign a signed commit\n '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2\n-\tminutes ago`}; the format follows the rules described for the\n+\tminutes ago}`; the format follows the rules described for the\n \t`-g` option. The portion before the `@` is the refname as\n \tgiven on the command line (so `git log -g refs/heads/master`\n \twould yield `refs/heads/master@{0}`).\n-- \ngitgitgadget\n"},{"id":"382107","messageId":"pull.330.git.gitgitgadget@gmail.com","threadId":"51820","inReplyTo":null,"subject":"[PATCH 0/1] doc: small formatting fix","fromName":"Cameron Steffen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-09T23:21:02Z","receivedAt":"2019-09-09T23:21:07Z","isPatch":true,"sender":{"key":"cam.steffen94@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5565418?v=4"},"body":"Edit: I need permission to submit please\n\nCameron Steffen (1):\n  doc: small formatting fix\n\n Documentation/pretty-formats.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/330\n-- \ngitgitgadget\n"},{"id":"382157","messageId":"2f301b94-f8da-3a36-8d3b-08593ceb1a5a@gmail.com","threadId":"51820","inReplyTo":"pull.330.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] doc: small formatting fix","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2019-09-11T11:49:07Z","receivedAt":"2019-09-11T11:49:10Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote:\n> Edit: I need permission to submit please\n\nHi Cameron.\n\nWhen using GitGitGadget, your PR description becomes your cover letter on the mailing list. This is a great place for you to describe how you discovered this problem and if you have looked elsewhere for similar issues to fix up.\n\nThanks,\n-Stolee\n> \n> Cameron Steffen (1):\n>   doc: small formatting fix\n> \n>  Documentation/pretty-formats.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> \n> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/330\n> \n"},{"id":"382158","messageId":"56b90e69-a1b2-fcaa-d300-8962565ef87b@gmail.com","threadId":"51820","inReplyTo":"5248e3332c90e91c1c6a911090d331f005789014.1568071262.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc: small formatting fix","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2019-09-11T11:50:22Z","receivedAt":"2019-09-11T11:50:26Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 9/9/2019 7:21 PM, Cameron Steffen via GitGitGadget wrote:\n> From: Cameron Steffen <cam.steffen94@gmail.com>\n> \n> move an incorrectly placed backtick\n\nThe change below is simple enough, but we prefer using full sentences in the commit messages. This includes capitalization and punctuation.\n\nThanks,\n-Stolee\n \n> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n> ---\n>  Documentation/pretty-formats.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index 079598307a..b87e2e83e6 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -208,7 +208,7 @@ endif::git-rev-list[]\n>  '%GP':: show the fingerprint of the primary key whose subkey was used\n>  \tto sign a signed commit\n>  '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2\n> -\tminutes ago`}; the format follows the rules described for the\n> +\tminutes ago}`; the format follows the rules described for the\n>  \t`-g` option. The portion before the `@` is the refname as\n>  \tgiven on the command line (so `git log -g refs/heads/master`\n>  \twould yield `refs/heads/master@{0}`).\n> \n"},{"id":"382163","messageId":"pull.330.v2.git.gitgitgadget@gmail.com","threadId":"51820","inReplyTo":"pull.330.git.gitgitgadget@gmail.com","subject":"[PATCH v2 0/1] doc: small formatting fix","fromName":"Cameron Steffen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-11T14:52:50Z","receivedAt":"2019-09-11T14:52:54Z","isPatch":true,"sender":{"key":"cam.steffen94@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5565418?v=4"},"body":"Move a closing backtick that was placed one character too soon.\n\nCameron Steffen (1):\n  doc: minor formatting fix\n\n Documentation/pretty-formats.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/330\n\nRange-diff vs v1:\n\n 1:  5248e3332c ! 1:  8e64007452 doc: small formatting fix\n     @@ -1,8 +1,8 @@\n      Author: Cameron Steffen <cam.steffen94@gmail.com>\n      \n     -    doc: small formatting fix\n     +    doc: minor formatting fix\n      \n     -    move an incorrectly placed backtick\n     +    Move a closing backtick that was placed one character too soon.\n      \n          Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n      \n\n-- \ngitgitgadget\n"},{"id":"382164","messageId":"8e6400745275e0af317552e73384101e5745a667.1568213570.git.gitgitgadget@gmail.com","threadId":"51820","inReplyTo":"pull.330.v2.git.gitgitgadget@gmail.com","subject":"[PATCH v2 1/1] doc: minor formatting fix","fromName":"Cameron Steffen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-11T14:52:51Z","receivedAt":"2019-09-11T14:52:59Z","isPatch":true,"sender":{"key":"cam.steffen94@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5565418?v=4"},"body":"From: Cameron Steffen <cam.steffen94@gmail.com>\n\nMove a closing backtick that was placed one character too soon.\n\nSigned-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n---\n Documentation/pretty-formats.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\nindex 079598307a..b87e2e83e6 100644\n--- a/Documentation/pretty-formats.txt\n+++ b/Documentation/pretty-formats.txt\n@@ -208,7 +208,7 @@ endif::git-rev-list[]\n '%GP':: show the fingerprint of the primary key whose subkey was used\n \tto sign a signed commit\n '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2\n-\tminutes ago`}; the format follows the rules described for the\n+\tminutes ago}`; the format follows the rules described for the\n \t`-g` option. The portion before the `@` is the refname as\n \tgiven on the command line (so `git log -g refs/heads/master`\n \twould yield `refs/heads/master@{0}`).\n-- \ngitgitgadget\n"},{"id":"382185","messageId":"nycvar.QRO.7.76.6.1909112321270.5377@tvgsbejvaqbjf.bet","threadId":"51820","inReplyTo":"pull.330.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] doc: small formatting fix","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-09-11T21:21:46Z","receivedAt":"2019-09-11T21:22:07Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Cameron,\n\nOn Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote:\n\n> Edit: I need permission to submit please\n\nYou got that permission already ;-)\n\nCiao,\nJohannes\n\n>\n> Cameron Steffen (1):\n>   doc: small formatting fix\n>\n>  Documentation/pretty-formats.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>\n> base-commit: 75b2f01a0f642b39b0f29b6218515df9b5eb798e\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-330%2Fcamsteffen%2Fpatch-1-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-330/camsteffen/patch-1-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/330\n> --\n> gitgitgadget\n>\n"},{"id":"382186","messageId":"nycvar.QRO.7.76.6.1909112322220.5377@tvgsbejvaqbjf.bet","threadId":"51820","inReplyTo":"5248e3332c90e91c1c6a911090d331f005789014.1568071262.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] doc: small formatting fix","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-09-11T21:24:32Z","receivedAt":"2019-09-11T21:24:54Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Cameron,\n\nOn Mon, 9 Sep 2019, Cameron Steffen via GitGitGadget wrote:\n\n> From: Cameron Steffen <cam.steffen94@gmail.com>\n>\n> move an incorrectly placed backtick\n\nThis sentence is incomplete, and does not really explain _why_ the\nbacktick needs to be moved. Something like this would be much clearer:\n\n\tMost likely by mistake, the closing curly brace was added\n\t_after_ the backtick instead of _before_ it. This breaks the\n\tformatting. Let's fix that.\n\nThe patch looks good, though.\n\nTo send another iteration of this patch, amend your commit locally,\nforce-push, and issue another `/submit`.\n\nCiao,\nJohannes\n\n>\n> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n> ---\n>  Documentation/pretty-formats.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index 079598307a..b87e2e83e6 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -208,7 +208,7 @@ endif::git-rev-list[]\n>  '%GP':: show the fingerprint of the primary key whose subkey was used\n>  \tto sign a signed commit\n>  '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2\n> -\tminutes ago`}; the format follows the rules described for the\n> +\tminutes ago}`; the format follows the rules described for the\n>  \t`-g` option. The portion before the `@` is the refname as\n>  \tgiven on the command line (so `git log -g refs/heads/master`\n>  \twould yield `refs/heads/master@{0}`).\n> --\n> gitgitgadget\n>\n"},{"id":"382236","messageId":"xmqq4l1hgzjc.fsf@gitster-ct.c.googlers.com","threadId":"51820","inReplyTo":"8e6400745275e0af317552e73384101e5745a667.1568213570.git.gitgitgadget@gmail.com","subject":"Re: [PATCH v2 1/1] doc: minor formatting fix","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-09-12T18:06:15Z","receivedAt":"2019-09-12T18:06:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Cameron Steffen via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Cameron Steffen <cam.steffen94@gmail.com>\n>\n> Move a closing backtick that was placed one character too soon.\n>\n> Signed-off-by: Cameron Steffen <cam.steffen94@gmail.com>\n> ---\n>  Documentation/pretty-formats.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks for spotting and fixing.  Will apply.\n\n>\n> diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt\n> index 079598307a..b87e2e83e6 100644\n> --- a/Documentation/pretty-formats.txt\n> +++ b/Documentation/pretty-formats.txt\n> @@ -208,7 +208,7 @@ endif::git-rev-list[]\n>  '%GP':: show the fingerprint of the primary key whose subkey was used\n>  \tto sign a signed commit\n>  '%gD':: reflog selector, e.g., `refs/stash@{1}` or `refs/stash@{2\n> -\tminutes ago`}; the format follows the rules described for the\n> +\tminutes ago}`; the format follows the rules described for the\n>  \t`-g` option. The portion before the `@` is the refname as\n>  \tgiven on the command line (so `git log -g refs/heads/master`\n>  \twould yield `refs/heads/master@{0}`).\n"}]}