{"thread":{"id":"51805","subject":"[PATCH 0/1] Fix stale .gitignore change, introduced via js/visual-studio","startedAt":"2019-09-05T11:16:36Z","lastAt":"2019-09-05T17:44:34Z","messageCount":3,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"381863","messageId":"pull.332.git.gitgitgadget@gmail.com","threadId":"51805","inReplyTo":null,"subject":"[PATCH 0/1] Fix stale .gitignore change, introduced via js/visual-studio","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-05T11:16:32Z","receivedAt":"2019-09-05T11:16:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"As reported in \nhttps://public-inbox.org/git/20190825120741.GM20404@szeder.dev/, we added a\nline to ignore .manifest files, but that is a left-over from a long time\nago, before we added and used compat/win32/git.manifest.\n\nThis fixes that left-over.\n\nJohannes Schindelin (1):\n  .gitignore: stop ignoring `.manifest` files\n\n .gitignore | 1 -\n 1 file changed, 1 deletion(-)\n\n\nbase-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-332%2Fdscho%2Fstop-ignoring-manifest-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-332/dscho/stop-ignoring-manifest-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/332\n-- \ngitgitgadget\n"},{"id":"381864","messageId":"05b341661b7e14868af0eaa9179816b28c40b8bf.1567682191.git.gitgitgadget@gmail.com","threadId":"51805","inReplyTo":"pull.332.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] .gitignore: stop ignoring `.manifest` files","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-09-05T11:16:33Z","receivedAt":"2019-09-05T11:16:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nOn Windows, it is possible to embed additional metadata into an\nexecutable by linking in a \"manifest\", i.e. an XML document that\ndescribes capabilities and requirements (such as minimum or maximum\nWindows version). These XML documents are expected to be stored in\n`.manifest` files.\n\nAt least _some_ Visual Studio versions auto-generate `.manifest` files\nwhen none is specified explicitly, therefore we used to ask Git to\nignore them.\n\nHowever, we do have a beautiful `.manifest` file now:\n`compat/win32/git.manifest`, so neither does Visual Studio auto-generate\na manifest for us, nor do we want Git to ignore the `.manifest` files\nanymore.\n\nFurther reading on auto-generated `.manifest` files:\nhttps://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n .gitignore | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex 521d8f4fb4..fc445edea9 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -231,7 +231,6 @@\n *.ipdb\n *.dll\n .vs/\n-*.manifest\n Debug/\n Release/\n /UpgradeLog*.htm\n-- \ngitgitgadget\n"},{"id":"381886","messageId":"xmqqh85qr62t.fsf@gitster-ct.c.googlers.com","threadId":"51805","inReplyTo":"05b341661b7e14868af0eaa9179816b28c40b8bf.1567682191.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] .gitignore: stop ignoring `.manifest` files","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-09-05T17:44:26Z","receivedAt":"2019-09-05T17:44:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> ...\n> Further reading on auto-generated `.manifest` files:\n> https://docs.microsoft.com/en-us/cpp/build/manifest-generation-in-visual-studio\n>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n>  .gitignore | 1 -\n>  1 file changed, 1 deletion(-)\n\nThanks.\n\n> diff --git a/.gitignore b/.gitignore\n> index 521d8f4fb4..fc445edea9 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -231,7 +231,6 @@\n>  *.ipdb\n>  *.dll\n>  .vs/\n> -*.manifest\n>  Debug/\n>  Release/\n>  /UpgradeLog*.htm\n"}]}