{"thread":{"id":"51723","subject":"[PATCH 1/1] hdr-check: make it work on Windows","startedAt":"2019-08-24T22:36:58Z","lastAt":"2019-08-26T17:04:59Z","messageCount":3,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"381079","messageId":"c13d9985284d4b452db0d95b6949e02c533db634.1566686214.git.gitgitgadget@gmail.com","threadId":"51723","inReplyTo":"pull.129.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] hdr-check: make it work on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-24T22:36:55Z","receivedAt":"2019-08-24T22:36:58Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nOn Windows, we define a specific set of pre-processor macros, among\nother reasons: to avoid including syslog.h (which is not available on\nWindows).\n\nThe hdr-check target did not use those definitions, resulting in a\nfailure to include said syslog.h.\n\nTo fix that, let's let the hdr-check target make use of ALL_CFLAGS,\nwhich does include the pre-processor macros that would e.g. skip the\nconditional block including syslog.h.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex c5240942f2..b9f00f0ea0 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2741,7 +2741,7 @@ CHK_HDRS = $(filter-out $(EXCEPT_HDRS),$(patsubst ./%,%,$(LIB_H)))\n HCO = $(patsubst %.h,%.hco,$(CHK_HDRS))\n \n $(HCO): %.hco: %.h FORCE\n-\t$(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $<\n+\t$(QUIET_HDR)$(CC) $(ALL_CFLAGS) -include git-compat-util.h -I. -o /dev/null -c -xc $<\n \n .PHONY: hdr-check $(HCO)\n hdr-check: $(HCO)\n-- \ngitgitgadget\n"},{"id":"381080","messageId":"pull.129.git.gitgitgadget@gmail.com","threadId":"51723","inReplyTo":null,"subject":"[PATCH 0/1] Do use ALL_CFLAGS in hdr-check","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-08-24T22:36:54Z","receivedAt":"2019-08-24T22:36:59Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"When I was playing with the Makefile target hdr-check, it looked as if it\nmissed the correct CFLAGS. Without them, on Windows an attempt is made to\ninclude syslog.h, which does not make sense at all.\n\nThis patch addresses that.\n\nJohannes Schindelin (1):\n  hdr-check: make it work on Windows\n\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: c65a2884eae159bad540135479bc8afe20ff62d1\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-129%2Fdscho%2Ffix-hdr-check-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-129/dscho/fix-hdr-check-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/129\n-- \ngitgitgadget\n"},{"id":"381213","messageId":"xmqqblwbj1sa.fsf@gitster-ct.c.googlers.com","threadId":"51723","inReplyTo":"pull.129.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] Do use ALL_CFLAGS in hdr-check","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-08-26T17:04:53Z","receivedAt":"2019-08-26T17:04:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" <gitgitgadget@gmail.com>\nwrites:\n\n> When I was playing with the Makefile target hdr-check, it looked as if it\n> missed the correct CFLAGS. Without them, on Windows an attempt is made to\n> include syslog.h, which does not make sense at all.\n\nMakes sense.\n\nThanks.\n"}]}