{"thread":{"id":"51540","subject":"git maintainer workflow tools?","startedAt":"2019-07-28T07:30:06Z","lastAt":"2019-07-28T14:20:12Z","messageCount":2,"participants":["Matthias Beyer","Theodore Y. Ts'o"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"379439","messageId":"20190728072318.GO1402@hoshi","threadId":"51540","inReplyTo":null,"subject":"git maintainer workflow tools?","fromName":"Matthias Beyer","fromEmail":"mail@beyermatthias.de","sentAt":"2019-07-28T07:23:18Z","receivedAt":"2019-07-28T07:30:06Z","isPatch":false,"sender":{"key":"mail@beyermatthias.de","avatar":null},"body":"Hello git community,\n\nI write this email because after several attempts over several months of\nsearching the internet for this, I still fail to find a proper documentation\nand/or tools for the workflow. So this is my last resort.\n\nSo what I am looking for is tools to automate contributor and maintainer\nworkflow, especially:\n\n1) Repliying to each emailpatch of a set of patches with\n   \"Reviewed-by: <user@host>\" (or other trailers)\n\n   Szenario: I see a patchset on a mailinglist. I apply this patchset to my\n   local copy of the repository, review it and test it.\n   I want to send \"Reviewed-by\" and \"Tested-by\" trailers for each patch.\n\n\n2) Applying a set of emails as patches, where \"Reviewed-by\" and other trailers\n   from the tree of emails are automatically included in the commit message when\n   applying (how do the kernel people do this? By hand? I don't think so, do\n   they?)\n\n   Szenario: I receive a patchset for my project. Contributors have started a\n   discussion on PATCH 1/3, fixup commits/squash commits were sent to the mail\n   thread. After a bit of discussion, \"Reviewed-by\"/\"Acked-by\" trailers were\n   sent.  I want to apply the patches, and include all trailers in the commit\n   message that were sent for the corrosponding patchmail.\n\n\nFwiw, I'm using mutt as an email reader, but of course such tools can or even\nshould be MUA-agnostic, right?\n\nI know about git-interpret-trailers, but I fail to see how to use them to\nautomate the process.\n\nMaybe you know scripts/tools that are ready and available for accomplishing\nthese tasks.\n\n\n-- \nMit freundlichen Grüßen,\nKind regards,\nMatthias Beyer\n"},{"id":"379440","messageId":"20190728141957.GD1499@mit.edu","threadId":"51540","inReplyTo":"20190728072318.GO1402@hoshi","subject":"Re: git maintainer workflow tools?","fromName":"Theodore Y. Ts'o","fromEmail":"tytso@mit.edu","sentAt":"2019-07-28T14:19:57Z","receivedAt":"2019-07-28T14:20:12Z","isPatch":false,"sender":{"key":"tytso@mit.edu","avatar":"https://avatars.githubusercontent.com/u/51416?v=4"},"body":"On Sun, Jul 28, 2019 at 09:23:18AM +0200, Matthias Beyer wrote:\n> \n> So what I am looking for is tools to automate contributor and maintainer\n> workflow, especially:\n> \n> 1) Repliying to each emailpatch of a set of patches with\n>    \"Reviewed-by: <user@host>\" (or other trailers)\n> \n>    Szenario: I see a patchset on a mailinglist. I apply this patchset to my\n>    local copy of the repository, review it and test it.\n>    I want to send \"Reviewed-by\" and \"Tested-by\" trailers for each patch.\n\nI have the following in my ~/.emacs.el file:\n\n(defvar signed-off-by-address \"Theodore Ts\\'o <tytso@mit.edu>\"\n  \"Address used by insert-signed-off-by\")\n\n(defun insert-signed-off-by ()\n  (interactive)\n  (insert (concat \"Signed-off-by: \" signed-off-by-address \"\\n\")))\n\n(defun insert-reviewed-by ()\n  (interactive)\n  (insert (concat \"Reviewed-by: \" signed-off-by-address \"\\n\")))\n\n(global-set-key \"\\^Cs\" 'insert-signed-off-by)\n(global-set-key \"\\^Cr\" 'insert-reviewed-by)\n\nIf I see an e-mail on the mailing list for me to review, I may or may\nnot apply it to my tree depending on how complex it is to review.  But\nthen in the e-mail reply, I just type \"^C r\" to insert the Reviwed-by\ntag in my e-mail response.\n\nTypically my replies will end with something like this:\n\n\tOnce you address the above comments, feel free to add:\n\n\tReviewed-by: Theodore Ts'o <tytso@mit.edu>\n\nOr a straight LGTM:\n\n\tLooks good, feel free to add:\n\n\tReviewed-by: Theodore Ts'o <tytso@mit.edu>\n\n> \n> 2) Applying a set of emails as patches, where \"Reviewed-by\" and other trailers\n>    from the tree of emails are automatically included in the commit message when\n>    applying (how do the kernel people do this? By hand? I don't think so, do\n>    they?)\n\nPatchwork will automatically include the Reviwed-by tags from the\ne-mail thread.\n\nSo for example, see this patch:\n\n\thttp://patchwork.ozlabs.org/patch/1064297/\n\nIf you click the series link, you'll get a Unix mbox file with all of\nthe patches in the patch series, complete with the tags from the\nreplies tagged.  (e.g, where people have replied with \"Looks good,\nfeel free to add...\")  It is suitable for application using \"git am -s\".\n\nThere are other tools and scripts people might use, but this is one\nsuch workflow.\n\nHope this helps,\n\n\t\t\t\t\t- Ted\n"}]}