{"thread":{"id":"5152","subject":"[PATCH] gitweb: fix $project usage","startedAt":"2006-08-06T11:25:41Z","lastAt":"2006-08-06T11:25:41Z","messageCount":1,"participants":["Matthias Lederhofer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24886","messageId":"20060806112541.GA21515@moooo.ath.cx","threadId":"5152","inReplyTo":null,"subject":"[PATCH] gitweb: fix $project usage","fromName":"Matthias Lederhofer","fromEmail":"matled@gmx.net","sentAt":"2006-08-06T11:25:41Z","receivedAt":"2006-08-06T11:25:41Z","isPatch":true,"sender":{"key":"matled@gmx.net","avatar":null},"body":"There were some places where $project was used even if it was not\ndefined.\n\nSigned-off-by: Matthias Lederhofer <matled@gmx.net>\n---\n gitweb/gitweb.perl |   17 ++++++++++++-----\n 1 files changed, 12 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex d0672cd..fa9ecce 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -85,7 +85,10 @@ if (defined $action) {\n }\n \n our $project = ($cgi->param('p') || $ENV{'PATH_INFO'});\n-$project =~ s|^/||; $project =~ s|/$||;\n+if (defined $project) {\n+\t$project =~ s|^/||;\n+\t$project =~ s|/$||;\n+}\n if (defined $project && $project) {\n \tif (!validate_input($project)) {\n \t\tdie_error(undef, \"Invalid project parameter\");\n@@ -874,11 +877,15 @@ sub git_header_html {\n <title>$title</title>\n <link rel=\"stylesheet\" type=\"text/css\" href=\"$stylesheet\"/>\n EOF\n-\tprint \"<link rel=\\\"alternate\\\" title=\\\"\" . esc_param($project) . \" log\\\" href=\\\"\" .\n-\t      \"$my_uri?\" . esc_param(\"p=$project;a=rss\") . \"\\\" type=\\\"application/rss+xml\\\"/>\\n\" .\n-\t      \"</head>\\n\";\n+\tif (defined $project) {\n+\t\tprintf('<link rel=\"alternate\" title=\"%s log\" '.\n+\t\t       'href=\"%s\" type=\"application/rss+xml\"/>'.\"\\n\",\n+\t\t       esc_param($project),\n+\t\t       esc_param(\"$my_uri?p=$project;a=rss\"));\n+\t}\n \n-\tprint \"<body>\\n\" .\n+\tprint \"</head>\\n\" .\n+\t      \"<body>\\n\" .\n \t      \"<div class=\\\"page_header\\\">\\n\" .\n \t      \"<a href=\\\"http://www.kernel.org/pub/software/scm/git/docs/\\\" title=\\\"git documentation\\\">\" .\n \t      \"<img src=\\\"$logo\\\" width=\\\"72\\\" height=\\\"27\\\" alt=\\\"git\\\" style=\\\"float:right; border-width:0px;\\\"/>\" .\n-- \n1.4.2.rc3.g2f52\n"}]}