{"thread":{"id":"51384","subject":"[PATCH] trace2: correct typo in technical documentation","startedAt":"2019-06-26T20:03:16Z","lastAt":"2019-06-27T10:49:20Z","messageCount":3,"participants":["Carlo Marcelo Arenas Belón","Jeff Hostetler","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"378080","messageId":"20190626200303.9834-1-carenas@gmail.com","threadId":"51384","inReplyTo":null,"subject":"[PATCH] trace2: correct typo in technical documentation","fromName":"Carlo Marcelo Arenas Belón","fromEmail":"carenas@gmail.com","sentAt":"2019-06-26T20:03:03Z","receivedAt":"2019-06-26T20:03:16Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"an apparent typo for the environment variable was included with 81567caf87\n(\"trace2: update docs to describe system/global config settings\",\n2019-04-15), and was missed when renamed variables by e4b75d6a1d\n(\"trace2: rename environment variables to GIT_TRACE2*\", 2019-05-19)\n\nSigned-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n---\n Documentation/technical/api-trace2.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt\nindex 23c3cc7a37..f7ffe7d599 100644\n--- a/Documentation/technical/api-trace2.txt\n+++ b/Documentation/technical/api-trace2.txt\n@@ -35,7 +35,7 @@ Format details are given in a later section.\n === The Normal Format Target\n \n The normal format target is a tradition printf format and similar\n-to GIT_TRACE format.  This format is enabled with the `GIT_TR`\n+to GIT_TRACE format.  This format is enabled with the `GIT_TRACE2`\n environment variable or the `trace2.normalTarget` system or global\n config setting.\n \n-- \n2.22.0\n\n"},{"id":"378081","messageId":"fbe5f66f-6e3e-751c-78af-7c73fa1fac25@jeffhostetler.com","threadId":"51384","inReplyTo":"20190626200303.9834-1-carenas@gmail.com","subject":"Re: [PATCH] trace2: correct typo in technical documentation","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2019-06-26T20:14:46Z","receivedAt":"2019-06-26T20:14:49Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 6/26/2019 4:03 PM, Carlo Marcelo Arenas Belón wrote:\n> an apparent typo for the environment variable was included with 81567caf87\n> (\"trace2: update docs to describe system/global config settings\",\n> 2019-04-15), and was missed when renamed variables by e4b75d6a1d\n> (\"trace2: rename environment variables to GIT_TRACE2*\", 2019-05-19)\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n> ---\n>   Documentation/technical/api-trace2.txt | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt\n> index 23c3cc7a37..f7ffe7d599 100644\n> --- a/Documentation/technical/api-trace2.txt\n> +++ b/Documentation/technical/api-trace2.txt\n> @@ -35,7 +35,7 @@ Format details are given in a later section.\n>   === The Normal Format Target\n>   \n>   The normal format target is a tradition printf format and similar\n> -to GIT_TRACE format.  This format is enabled with the `GIT_TR`\n> +to GIT_TRACE format.  This format is enabled with the `GIT_TRACE2`\n>   environment variable or the `trace2.normalTarget` system or global\n>   config setting.\n>   \n> \n\nGood catch!\n\nThanks,\nJeff\n"},{"id":"378149","messageId":"20190627104909.GA21574@szeder.dev","threadId":"51384","inReplyTo":"20190626200303.9834-1-carenas@gmail.com","subject":"Re: [PATCH] trace2: correct typo in technical documentation","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-06-27T10:49:09Z","receivedAt":"2019-06-27T10:49:20Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Wed, Jun 26, 2019 at 01:03:03PM -0700, Carlo Marcelo Arenas Belón wrote:\n> an apparent typo for the environment variable was included with 81567caf87\n> (\"trace2: update docs to describe system/global config settings\",\n> 2019-04-15), and was missed when renamed variables by e4b75d6a1d\n> (\"trace2: rename environment variables to GIT_TRACE2*\", 2019-05-19)\n> \n> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>\n> ---\n>  Documentation/technical/api-trace2.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt\n> index 23c3cc7a37..f7ffe7d599 100644\n> --- a/Documentation/technical/api-trace2.txt\n> +++ b/Documentation/technical/api-trace2.txt\n> @@ -35,7 +35,7 @@ Format details are given in a later section.\n>  === The Normal Format Target\n>  \n>  The normal format target is a tradition printf format and similar\n> -to GIT_TRACE format.  This format is enabled with the `GIT_TR`\n> +to GIT_TRACE format.  This format is enabled with the `GIT_TRACE2`\n\nCarlo, thanks for catching this.\n\nJunio, this patch should be applied on top of 'sg/trace2-rename' which\ncontains e4b75d6a1d.  In current 'pu' it's applied on top of\n'jh/trace2-sid-fix', which doesn't contain that commit and therefore\nthe rest of the codebase doesn't know about GIT_TRACE2 yet. \n\n"}]}