{"thread":{"id":"51377","subject":"[PATCH] doc: fix form -> from typo","startedAt":"2019-06-25T06:36:21Z","lastAt":"2019-06-26T08:22:41Z","messageCount":6,"participants":["Catalin Criste","Martin Ågren","Johannes Schindelin","Junio C Hamano","Thomas Gummerer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"377942","messageId":"0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com","threadId":"51377","inReplyTo":null,"subject":"[PATCH] doc: fix form -> from typo","fromName":"Catalin Criste","fromEmail":"cris_linu_w@yahoo.com","sentAt":"2019-06-25T06:36:18Z","receivedAt":"2019-06-25T06:36:21Z","isPatch":true,"sender":{"key":"cris_linu_w@yahoo.com","avatar":null},"body":"Signed-off-by: Catalin Criste \n---\n Documentation/git-stash.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 7ef8c4791177b..b96ce2d02d149 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q\n \n \tThis option is deprecated in favour of 'git stash push'. It\n \tdiffers from \"stash push\" in that it cannot take pathspecs,\n-\tand any non-option arguments form the message.\n+\tand any non-option arguments from the message.\n \n list []::\n \n\n--\nhttps://github.com/git/git/pull/521\n"},{"id":"377953","messageId":"CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com","threadId":"51377","inReplyTo":"0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] doc: fix form -> from typo","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2019-06-25T09:41:00Z","receivedAt":"2019-06-25T09:41:14Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Hi Catalin\n\nWelcome to the list!\n\nOn Tue, 25 Jun 2019 at 09:43, Catalin Criste wrote:\n\n> @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q\n>\n> This option is deprecated in favour of 'git stash push'. It\n> differs from \"stash push\" in that it cannot take pathspecs,\n> - and any non-option arguments form the message.\n> + and any non-option arguments from the message.\n\nI think this is actually intended as \"form\". It took me a couple of\nreadings, but what this paragraph wants to say is that any non-option\narguments will be used to form (construct) the message.\n\nDo you have any suggestions as to how this could be made clearer?\nThere are at least two of us that have stumbled on this. :-)\n\nCheers\nMartin\n"},{"id":"377973","messageId":"nycvar.QRO.7.76.6.1906251339050.44@tvgsbejvaqbjf.bet","threadId":"51377","inReplyTo":"CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com","subject":"Re: [PATCH] doc: fix form -> from typo","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-06-25T11:40:41Z","receivedAt":"2019-06-25T11:40:27Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Martin,\n\nOn Tue, 25 Jun 2019, Martin Ågren wrote:\n\n> On Tue, 25 Jun 2019 at 09:43, Catalin Criste wrote:\n>\n> > @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q\n> >\n> > This option is deprecated in favour of 'git stash push'. It\n> > differs from \"stash push\" in that it cannot take pathspecs,\n> > - and any non-option arguments form the message.\n> > + and any non-option arguments from the message.\n>\n> I think this is actually intended as \"form\". It took me a couple of\n> readings, but what this paragraph wants to say is that any non-option\n> arguments will be used to form (construct) the message.\n\nYou're right! I totally misread this, too.\n\n> Do you have any suggestions as to how this could be made clearer?\n> There are at least two of us that have stumbled on this. :-)\n\nMake that three.\n\nMaybe something like\n\n\tThis option is deprecated in favour of 'git stash push'. It\n\tdiffers from \"stash push\" in that it cannot take pathspecs;\n\tInstead, all non-option arguments are concatenated to form the stash\n\tmessage.\n\n?\n\nCiao,\nDscho\n"},{"id":"378029","messageId":"CAN0heSr=E6yHkUHiGE=nezB72+P_R2iSZcYKDZHp1JTPj4f2QA@mail.gmail.com","threadId":"51377","inReplyTo":"nycvar.QRO.7.76.6.1906251339050.44@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] doc: fix form -> from typo","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2019-06-25T17:49:52Z","receivedAt":"2019-06-25T17:50:07Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"On Tue, 25 Jun 2019 at 13:40, Johannes Schindelin\n wrote:\n> On Tue, 25 Jun 2019, Martin Ågren wrote:\n\n> > Do you have any suggestions as to how this could be made clearer?\n> > There are at least two of us that have stumbled on this. :-)\n>\n> Make that three.\n>\n> Maybe something like\n>\n> This option is deprecated in favour of 'git stash push'. It\n> differs from \"stash push\" in that it cannot take pathspecs;\n> Instead, all non-option arguments are concatenated to form the stash\n> message.\n>\n> ?\n\nLooks good. I would probably avoid the semicolon \";\" and in this case\njust replace it with a period. But it's nothing I feel strongly about.\n\nMartin\n"},{"id":"378040","messageId":"xmqqv9wte8ev.fsf@gitster-ct.c.googlers.com","threadId":"51377","inReplyTo":"CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com","subject":"Re: [PATCH] doc: fix form -> from typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-06-25T20:07:04Z","receivedAt":"2019-06-25T20:07:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren writes:\n\n> Hi Catalin\n>\n> Welcome to the list!\n>\n> On Tue, 25 Jun 2019 at 09:43, Catalin Criste wrote:\n>\n>> @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q\n>>\n>> This option is deprecated in favour of 'git stash push'. It\n>> differs from \"stash push\" in that it cannot take pathspecs,\n>> - and any non-option arguments form the message.\n>> + and any non-option arguments from the message.\n>\n> I think this is actually intended as \"form\". It took me a couple of\n> readings, but what this paragraph wants to say is that any non-option\n> arguments will be used to form (construct) the message.\n>\n> Do you have any suggestions as to how this could be made clearer?\n> There are at least two of us that have stumbled on this. :-)\n\n\"become\"?\n"},{"id":"378054","messageId":"20190626082234.GC2423@hank.intra.tgummerer.com","threadId":"51377","inReplyTo":"CAN0heSraZh+j04qjeaVtS5bsNoE=Hf_FBU-kfcB+69BkZz+zHg@mail.gmail.com","subject":"Re: [PATCH] doc: fix form -> from typo","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2019-06-26T08:22:34Z","receivedAt":"2019-06-26T08:22:41Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"On 06/25, Martin Ågren wrote:\n> Hi Catalin\n> \n> Welcome to the list!\n> \n> On Tue, 25 Jun 2019 at 09:43, Catalin Criste wrote:\n> \n> > @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q\n> >\n> > This option is deprecated in favour of 'git stash push'. It\n> > differs from \"stash push\" in that it cannot take pathspecs,\n> > - and any non-option arguments form the message.\n> > + and any non-option arguments from the message.\n> \n> I think this is actually intended as \"form\". It took me a couple of\n> readings, but what this paragraph wants to say is that any non-option\n> arguments will be used to form (construct) the message.\n> \n> Do you have any suggestions as to how this could be made clearer?\n> There are at least two of us that have stumbled on this. :-)\n\nEven though I originally wrote this I had to have a double take on it.\nMaybe what you're saying above would be good? \"and any non-option\narguments are used to form the message\" sounds a little clearer to\nme. Or maybe even use the word construct? Dunno.\n"}]}