{"thread":{"id":"51371","subject":"[PATCH] t5551: use 'test_i18ngrep' to check translated output","startedAt":"2019-06-24T12:44:59Z","lastAt":"2019-06-24T12:44:59Z","messageCount":1,"participants":["SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"377869","messageId":"20190624124446.32206-1-szeder.dev@gmail.com","threadId":"51371","inReplyTo":null,"subject":"[PATCH] t5551: use 'test_i18ngrep' to check translated output","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-06-24T12:44:46Z","receivedAt":"2019-06-24T12:44:59Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"The two tests 'invalid Content-Type rejected' and 'server-side error\ndetected' in 't5551-http-fetch-smart.sh' use \"plain\" 'grep' to check\nthat 'git clone' failed with the expected error message, but the\nmessages they are checking are translated, and, consequently, these\ntests fail when the test script is run with GIT_TEST_GETTEXT_POISON\nenabled.\n\nUse 'test_i18ngrep' instead.\n\nSigned-off-by: SZEDER Gábor <szeder.dev@gmail.com>\n---\n\nThe GETTEXT_POISON CI build jobs haven't caught these, because they\ndon't run the httpd (and svn, p4...) tests.  Should they?  Dunno.\n\n t/t5551-http-fetch-smart.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh\nindex ac74626a7b..cb11f13d6d 100755\n--- a/t/t5551-http-fetch-smart.sh\n+++ b/t/t5551-http-fetch-smart.sh\n@@ -199,7 +199,7 @@ test_expect_success 'GIT_SMART_HTTP can disable smart http' '\n \n test_expect_success 'invalid Content-Type rejected' '\n \ttest_must_fail git clone $HTTPD_URL/broken_smart/repo.git 2>actual &&\n-\tgrep \"not valid:\" actual\n+\ttest_i18ngrep \"not valid:\" actual\n '\n \n test_expect_success 'create namespaced refs' '\n@@ -466,7 +466,7 @@ test_expect_success 'GIT_TRACE_CURL_NO_DATA prevents data from being traced' '\n \n test_expect_success 'server-side error detected' '\n \ttest_must_fail git clone $HTTPD_URL/error_smart/repo.git 2>actual &&\n-\tgrep \"server-side error\" actual\n+\ttest_i18ngrep \"server-side error\" actual\n '\n \n test_done\n-- \n2.22.0.589.g5bd7971b91\n\n"}]}