{"thread":{"id":"5129","subject":"[PATCH] Allow config file to specify Signed-off-by identity in format-patch.","startedAt":"2006-08-04T21:01:30Z","lastAt":"2006-08-04T22:56:53Z","messageCount":2,"participants":["Ramsay Jones","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"24753","messageId":"000001c6b809$2919a200$c47eedc1@ramsay1.demon.co.uk","threadId":"5129","inReplyTo":null,"subject":"[PATCH] Allow config file to specify Signed-off-by identity in format-patch.","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2006-08-04T21:01:30Z","receivedAt":"2006-08-04T21:01:30Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nUnlike git-commit, git-format-patch was not picking up and using the\nuser.email config variable for the email part of the committer info.\nI was forced to use the GIT_COMMITTER_EMAIL environment variable to\noverride the default <user@localhost.localdomain>. The fix was to\nsimply move the call to setup_ident() to come before the git_config()\ncall.\n\nSigned-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>\n---\n builtin-log.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex f9515a8..dcee141 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -243,6 +243,7 @@ int cmd_format_patch(int argc, const cha\n \trev.ignore_merges = 1;\n \trev.diffopt.output_format = DIFF_FORMAT_PATCH;\n \n+\tsetup_ident();\n \tgit_config(git_format_config);\n \trev.extra_headers = extra_headers;\n \n@@ -283,7 +284,6 @@ int cmd_format_patch(int argc, const cha\n \t\t\t !strcmp(argv[i], \"-s\")) {\n \t\t\tconst char *committer;\n \t\t\tconst char *endpos;\n-\t\t\tsetup_ident();\n \t\t\tcommitter = git_committer_info(1);\n \t\t\tendpos = strchr(committer, '>');\n \t\t\tif (!endpos)\n-- \n1.4.1\n\n\nFrom 2bc01f2ceb042192827d05e941ca81c1a7dc30fe Mon Sep 17 00:00:00 2001\nFrom: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>\nDate: Fri, 4 Aug 2006 17:18:15 +0100\nSubject: [PATCH] Allow config file to specify Signed-off-by identity in format-patch.\n\nUnlike git-commit, git-format-patch was not picking up and using the\nuser.email config variable for the email part of the committer info.\nI was forced to use the GIT_COMMITTER_EMAIL environment variable to\noverride the default <user@localhost.localdomain>. The fix was to\nsimply move the call to setup_ident() to come before the git_config()\ncall.\n\nSigned-off-by: Ramsay Allan Jones <ramsay@ramsay1.demon.co.uk>\n---\n builtin-log.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-log.c b/builtin-log.c\nindex f9515a8..dcee141 100644\n--- a/builtin-log.c\n+++ b/builtin-log.c\n@@ -243,6 +243,7 @@ int cmd_format_patch(int argc, const cha\n \trev.ignore_merges = 1;\n \trev.diffopt.output_format = DIFF_FORMAT_PATCH;\n \n+\tsetup_ident();\n \tgit_config(git_format_config);\n \trev.extra_headers = extra_headers;\n \n@@ -283,7 +284,6 @@ int cmd_format_patch(int argc, const cha\n \t\t\t !strcmp(argv[i], \"-s\")) {\n \t\t\tconst char *committer;\n \t\t\tconst char *endpos;\n-\t\t\tsetup_ident();\n \t\t\tcommitter = git_committer_info(1);\n \t\t\tendpos = strchr(committer, '>');\n \t\t\tif (!endpos)\n-- \n1.4.1\n\n"},{"id":"24775","messageId":"Pine.LNX.4.63.0608050055090.1800@wbgn013.biozentrum.uni-wuerzburg.de","threadId":"5129","inReplyTo":"000001c6b809$2919a200$c47eedc1@ramsay1.demon.co.uk","subject":"Re: [PATCH] Allow config file to specify Signed-off-by identity in format-patch.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2006-08-04T22:56:53Z","receivedAt":"2006-08-04T22:56:53Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\n\nOn Fri, 4 Aug 2006, Ramsay Jones wrote:\n\n> Unlike git-commit, git-format-patch was not picking up and using the\n> user.email config variable for the email part of the committer info.\n> I was forced to use the GIT_COMMITTER_EMAIL environment variable to\n> override the default <user@localhost.localdomain>. The fix was to\n> simply move the call to setup_ident() to come before the git_config()\n> call.\n\nAcked-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nI _always_ use environment variables, since the $HOME/.gitconfig is a \npretty recent addition. Therefore, I completely missed that one.\n\nCiao,\nDscho\n"}]}