{"thread":{"id":"5128","subject":"http-push: email address problem with LOCK_REQUEST?","startedAt":"2006-08-04T21:01:33Z","lastAt":"2006-08-04T21:01:33Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"24752","messageId":"000401c6b809$2a4f62e0$c47eedc1@ramsay1.demon.co.uk","threadId":"5128","inReplyTo":null,"subject":"http-push: email address problem with LOCK_REQUEST?","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2006-08-04T21:01:33Z","receivedAt":"2006-08-04T21:01:33Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi all,\n\nWhilst fixing the git-format-patch \"Signed-off-by identity bug\", I\ndecided to have a look at the other calls to setup_ident(), to check\nfor similar problems. I noticed a couple of things that didn't look\nquite right (see also next email).\n\nIn particular, http-push accesses git_default_email directly, using\nit as part of a (DAV?) LOCK_REQUEST. However, since http-push does\nnot call git_config(), only the generic <user@localhost.localdomain>\ndetermined by setup_ident() will be used.\n\nNow this may not be a problem. I don't really know what the email\naddress is used for in the lock request; it could have no effect\non the transaction at all, apart from perhaps some message text\nin the web-server logs.\n\nAlso, there may be a reason for not reading the config file. I can't\nthink of one, but hey ...\n\nUnfortunately, since my config has NO_CURL, I can't even compile\nhttp-push.c, let alone test the change given below.\n\ncomments anyone?\n\nRamsay\n\n\ndiff --git a/http-push.c b/http-push.c\nindex e281f70..4de62e4 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -2340,6 +2340,7 @@ int main(int argc, char **argv)\n \n \tsetup_git_directory();\n \tsetup_ident();\n+\tgit_config(git_default_config);\n \n \tremote = xcalloc(sizeof(*remote), 1);\n \n"}]}