{"thread":{"id":"51255","subject":"[PATCH] completion (zsh): fix misleading install location","startedAt":"2019-06-06T21:38:57Z","lastAt":"2019-10-01T21:05:32Z","messageCount":5,"participants":["Durant Schoon","Denton Liu","Felipe Contreras","Maxim Belsky"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"376783","messageId":"0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com","threadId":"51255","inReplyTo":null,"subject":"[PATCH] completion (zsh): fix misleading install location","fromName":"Durant Schoon","fromEmail":"durant.schoon@gmail.com","sentAt":"2019-06-06T21:38:54Z","receivedAt":"2019-06-06T21:38:57Z","isPatch":true,"sender":{"key":"durant.schoon@gmail.com","avatar":null},"body":"When the code comment in the zsh completion suggests that this file\nshould be copied to `~/.zsh`, many users might be misled to believe that\nthis refers to a file location. But it refers to a directory, and won't\nwork when it is a file.\n\nLet's just add a slash, to make it abundantly clear that this must be a\ndirectory.\n\n(thank you to Johannes Schindelin for the suggested wording and title)\n\nSigned-off-by: B. Durant Schoon durant.schoon@gmail.com\n---\n contrib/completion/git-completion.zsh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh\nindex 886bf95d1f594..0e63004e2613e 100644\n--- a/contrib/completion/git-completion.zsh\n+++ b/contrib/completion/git-completion.zsh\n@@ -11,8 +11,8 @@\n #\n #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh\n #\n-# The recommended way to install this script is to copy to '~/.zsh/_git', and\n-# then add the following to your ~/.zshrc file:\n+# The recommended way to install this script is to copy to '~/.zsh/_git/',\n+# and then add the following to your ~/.zshrc file:\n #\n #  fpath=(~/.zsh $fpath)\n \n\n--\nhttps://github.com/git/git/pull/609\n"},{"id":"376789","messageId":"20190606224450.GA31942@archbookpro.localdomain","threadId":"51255","inReplyTo":"0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] completion (zsh): fix misleading install location","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-06-06T22:44:50Z","receivedAt":"2019-06-06T22:44:56Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"Hi Durant,\n\nJust a couple of small things:\n\nOn Thu, Jun 06, 2019 at 09:38:54PM +0000, Durant Schoon wrote:\n> When the code comment in the zsh completion suggests that this file\n> should be copied to `~/.zsh`, many users might be misled to believe that\n> this refers to a file location. But it refers to a directory, and won't\n> work when it is a file.\n> \n> Let's just add a slash, to make it abundantly clear that this must be a\n> directory.\n> \n> (thank you to Johannes Schindelin for the suggested wording and title)\n\nMaybe this would be better incorporated as a Helped-by: or Suggested-by:\ntag at the bottom?\n\n> \n> Signed-off-by: B. Durant Schoon durant.schoon@gmail.com\n\nThe email in your sign-off line should be wrapped in <>, i.e. it should\nbe\n\n\tB. Durant Schoon <durant.schoon@gmail.com>\n\nOther than that, the patch looks fine to me.\n\nThanks,\n\nDenton\n\n> ---\n>  contrib/completion/git-completion.zsh | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh\n> index 886bf95d1f594..0e63004e2613e 100644\n> --- a/contrib/completion/git-completion.zsh\n> +++ b/contrib/completion/git-completion.zsh\n> @@ -11,8 +11,8 @@\n>  #\n>  #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh\n>  #\n> -# The recommended way to install this script is to copy to '~/.zsh/_git', and\n> -# then add the following to your ~/.zshrc file:\n> +# The recommended way to install this script is to copy to '~/.zsh/_git/',\n> +# and then add the following to your ~/.zshrc file:\n>  #\n>  #  fpath=(~/.zsh $fpath)\n>  \n> \n> --\n> https://github.com/git/git/pull/609\n"},{"id":"376790","messageId":"CAMP44s2w2ByBAx5rdc+M7Z=CWN7+CXMLECcpfYGHBxO277xFdg@mail.gmail.com","threadId":"51255","inReplyTo":"0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] completion (zsh): fix misleading install location","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2019-06-06T22:52:03Z","receivedAt":"2019-06-06T22:52:16Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Thu, Jun 6, 2019 at 5:37 PM Durant Schoon <durant.schoon@gmail.com> wrote:\n\n> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh\n> index 886bf95d1f594..0e63004e2613e 100644\n> --- a/contrib/completion/git-completion.zsh\n> +++ b/contrib/completion/git-completion.zsh\n> @@ -11,8 +11,8 @@\n>  #\n>  #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh\n>  #\n> -# The recommended way to install this script is to copy to '~/.zsh/_git', and\n> -# then add the following to your ~/.zshrc file:\n> +# The recommended way to install this script is to copy to '~/.zsh/_git/',\n> +# and then add the following to your ~/.zshrc file:\n\n~/.zsh/_git should be a file, not a directory.\n\n-- \nFelipe Contreras\n"},{"id":"382872","messageId":"0102016d650b16ca-073c796f-065f-4966-9f94-f276c8fe6ee7-000000@eu-west-1.amazonses.com","threadId":"51255","inReplyTo":"0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com","subject":"[PATCH] completion (zsh): fix misleading install location","fromName":"Durant Schoon","fromEmail":"durant.schoon@gmail.com","sentAt":"2019-09-24T20:51:28Z","receivedAt":"2019-09-24T20:51:31Z","isPatch":true,"sender":{"key":"durant.schoon@gmail.com","avatar":null},"body":"When the code comment in the zsh completion suggests that this file\nshould be copied to `~/.zsh`, many users might be misled to believe that\nthis refers to a file location. But it refers to a directory, and won't\nwork when it is a file.\n\nLet's just add a slash, to make it abundantly clear that this must be a\ndirectory.\n\nSigned-off-by: B. Durant Schoon <durant.schoon@gmail.com>\nHelped-by: Johannes Schindelin\n---\n contrib/completion/git-completion.zsh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh\nindex 886bf95d1f594..0e63004e2613e 100644\n--- a/contrib/completion/git-completion.zsh\n+++ b/contrib/completion/git-completion.zsh\n@@ -11,8 +11,8 @@\n #\n #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh\n #\n-# The recommended way to install this script is to copy to '~/.zsh/_git', and\n-# then add the following to your ~/.zshrc file:\n+# The recommended way to install this script is to copy to '~/.zsh/_git/',\n+# and then add the following to your ~/.zshrc file:\n #\n #  fpath=(~/.zsh $fpath)\n \n\n--\nhttps://github.com/git/git/pull/609\n"},{"id":"383234","messageId":"30798B33-EF82-449F-BDF3-B639A292BCFA@gmail.com","threadId":"51255","inReplyTo":"0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] completion (zsh): fix misleading install location","fromName":"Maxim Belsky","fromEmail":"public.belsky@gmail.com","sentAt":"2019-10-01T21:05:26Z","receivedAt":"2019-10-01T21:05:32Z","isPatch":true,"sender":{"key":"public.belsky@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3923527?v=4"},"body":"Hey, \n\nI face same issue a few days ago. Initially I thought `~/.zsh/_git` should be a dictionary. I’ve made all required actions, but completion didn't work. After a few hours I found that it should be just a file instead of a dictionary.\n\nI have two ideas how to patch this comments to help another users setup completion:\n\n1. Add a note that `~/.zsh/_git` should be a file https://github.com/mbelsky/git/commit/e951a0dee5f124ad755d32fa5cc5cded471d389b \n2. Change the patch to make it more obvious https://github.com/mbelsky/git/commit/6c839727163b29b2d2cf5d2ec7f780c2826848d6\n\nIt’s my first time mail listing experience so I just put links on github to don’t make something wrong.\n\nWhat do you think about this changes? \n\n> On 7 Jun 2019, at 00:38, Durant Schoon <durant.schoon@gmail.com> wrote:\n> \n> diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh\n> index 886bf95d1f594..0e63004e2613e 100644\n> --- a/contrib/completion/git-completion.zsh\n> +++ b/contrib/completion/git-completion.zsh\n> @@ -11,8 +11,8 @@\n> #\n> #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh\n> #\n> -# The recommended way to install this script is to copy to '~/.zsh/_git', and\n> -# then add the following to your ~/.zshrc file:\n> +# The recommended way to install this script is to copy to '~/.zsh/_git/',\n> +# and then add the following to your ~/.zshrc file:\n"}]}