{"thread":{"id":"51223","subject":"Why is there still git-rebase--am.sh?","startedAt":"2019-06-02T11:04:29Z","lastAt":"2019-06-02T11:20:20Z","messageCount":2,"participants":["Alban Gruin","Philip Oakley"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"376543","messageId":"3322453.bNc8J3RWDa@andromeda","threadId":"51223","inReplyTo":null,"subject":"Why is there still git-rebase--am.sh?","fromName":"Alban Gruin","fromEmail":"alban.gruin@gmail.com","sentAt":"2019-06-02T11:04:15Z","receivedAt":"2019-06-02T11:04:29Z","isPatch":false,"sender":{"key":"alban.gruin@gmail.com","avatar":"https://avatars.githubusercontent.com/u/6310153?v=4"},"body":"Hi,\n\nI was wandering in rebase’s source code, and found out that even though \nrun_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea \n(\"built-in rebase: call `git am` directly\", 2019-01-18), this commit did not \nremove the code to call it.  I guess it was an oversight.\n\nNow that git-legacy-rebase.sh is gone (since d03ebd411c, \"rebase: remove the \nrebase.useBuiltin setting\", 2019-03-18), I would expect this file to be \ncompletely removed, too.\n\nMay I send a patch to remove git-rebase--am.sh, or is there a reason to keep \nit?\n\nCheers,\nAlban\n\n\n\n\n"},{"id":"376544","messageId":"ab655637-bb6d-436d-a822-31fa1a9495ed@iee.org","threadId":"51223","inReplyTo":"3322453.bNc8J3RWDa@andromeda","subject":"Re: Why is there still git-rebase--am.sh?","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":"2019-06-02T11:19:08Z","receivedAt":"2019-06-02T11:20:20Z","isPatch":false,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"Hi Alban,\n\nOn 02/06/2019 12:04, Alban Gruin wrote:\n> Hi,\n>\n> I was wandering in rebase’s source code, and found out that even though\n> run_specific_rebase() no longer calls git-rebase--am.sh since 21853626ea\n> (\"built-in rebase: call `git am` directly\", 2019-01-18), this commit did not\n> remove the code to call it.  I guess it was an oversight.\n>\n> Now that git-legacy-rebase.sh is gone (since d03ebd411c, \"rebase: remove the\n> rebase.useBuiltin setting\", 2019-03-18), I would expect this file to be\n> completely removed, too.\n>\n> May I send a patch to remove git-rebase--am.sh, or is there a reason to keep\n> it?\n>\n>\nWhat's cooking (May 2019, #05; Thu, 30) has it in js/rebase-cleanup \n(2019-05-15) 5 commits, and will be cooked in next.\nPhilip\n"}]}