{"thread":{"id":"51209","subject":"[PATCH 1/1] list-objects-filter-options: error is localizeable","startedAt":"2019-05-31T18:02:03Z","lastAt":"2019-05-31T18:02:03Z","messageCount":1,"participants":["Matthew DeVore"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"376492","messageId":"20190531180156.GA7633@comcast.net","threadId":"51209","inReplyTo":null,"subject":"[PATCH 1/1] list-objects-filter-options: error is localizeable","fromName":"Matthew DeVore","fromEmail":"matvore@google.com","sentAt":"2019-05-31T18:01:56Z","receivedAt":"2019-05-31T18:02:03Z","isPatch":true,"sender":{"key":"matvore@google.com","avatar":"https://avatars.githubusercontent.com/u/946637?v=4"},"body":"The \"invalid filter-spec\" message is user-facing and not a BUG, so make\nit localizeable.\n\nFor reference, the message appears in this context:\n\n\t$ git rev-list --filter=blob:nonse --objects HEAD\n\tfatal: invalid filter-spec 'blob:nonse'\n\nSigned-off-by: Matthew DeVore <matvore@google.com>\n---\n list-objects-filter-options.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/list-objects-filter-options.c b/list-objects-filter-options.c\nindex c0036f7378..e46ea467bc 100644\n--- a/list-objects-filter-options.c\n+++ b/list-objects-filter-options.c\n@@ -81,21 +81,21 @@ static int gently_parse_list_objects_filter(\n \t\tfilter_options->choice = LOFC_SPARSE_PATH;\n \t\tfilter_options->sparse_path_value = strdup(v0);\n \t\treturn 0;\n \t}\n \t/*\n \t * Please update _git_fetch() in git-completion.bash when you\n \t * add new filters\n \t */\n \n \tif (errbuf)\n-\t\tstrbuf_addf(errbuf, \"invalid filter-spec '%s'\", arg);\n+\t\tstrbuf_addf(errbuf, _(\"invalid filter-spec '%s'\"), arg);\n \n \tmemset(filter_options, 0, sizeof(*filter_options));\n \treturn 1;\n }\n \n int parse_list_objects_filter(struct list_objects_filter_options *filter_options,\n \t\t\t      const char *arg)\n {\n \tstruct strbuf buf = STRBUF_INIT;\n \tif (gently_parse_list_objects_filter(filter_options, arg, &buf))\n-- \n2.17.1\n\n"}]}