{"thread":{"id":"51163","subject":"[PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.","startedAt":"2019-05-23T23:55:51Z","lastAt":"2019-05-29T21:26:55Z","messageCount":7,"participants":["Xin Li","Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"376137","messageId":"20190523235543.4342-1-delphij@google.com","threadId":"51163","inReplyTo":null,"subject":"[PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.","fromName":"Xin Li","fromEmail":"delphij@google.com","sentAt":"2019-05-23T23:55:43Z","receivedAt":"2019-05-23T23:55:51Z","isPatch":true,"sender":{"key":"delphij@google.com","avatar":"https://avatars.githubusercontent.com/u/1045626?v=4"},"body":"Signed-off-by: Xin Li \n---\n builtin/clone.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 50bde99618..822208a346 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\t\tremote_head_points_at, &branch_top);\n \n \tif (filter_options.choice)\n-\t\tpartial_clone_register(\"origin\", &filter_options);\n+\t\tpartial_clone_register(option_origin, &filter_options);\n \n \tif (is_local)\n \t\tclone_local(path, git_dir);\n-- \n2.22.0.rc1.257.g3120a18244-goog\n\n"},{"id":"376138","messageId":"20190524000150.GD70860@google.com","threadId":"51163","inReplyTo":"20190523235543.4342-1-delphij@google.com","subject":"Re: [PATCH] Use user supplied origin name for extension.partialcone instead of hardcoded value.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2019-05-24T00:01:50Z","receivedAt":"2019-05-24T00:01:56Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Xin Li wrote:\n\n> Subject: Use user supplied origin name for extension.partialcone instead of hardcoded value.\n\nGood catch!\n\nNits:\n\n- s/partialcone/partialclone/ (missing \"l\")\n\n- subject lines in git.git tend to be of the form\n \"subsystem: lowercase summary\" with no trailing period. So maybe\n something like:\n\n\tclone: respect user supplied origin name when setting up partial clone\n\n> Signed-off-by: Xin Li \n> ---\n> builtin/clone.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nThe change looks obviously good. With or without a commit message\nchange like suggested above,\n\nReviewed-by: Jonathan Nieder \n\nThanks.\n"},{"id":"376139","messageId":"20190524001525.12952-1-delphij@google.com","threadId":"51163","inReplyTo":"20190524000150.GD70860@google.com","subject":"[PATCH] clone: respect user supplied origin name when setting up partial clone","fromName":"Xin Li","fromEmail":"delphij@google.com","sentAt":"2019-05-24T00:15:25Z","receivedAt":"2019-05-24T00:15:45Z","isPatch":true,"sender":{"key":"delphij@google.com","avatar":"https://avatars.githubusercontent.com/u/1045626?v=4"},"body":"Signed-off-by: Xin Li \nReviewed-by: Jonathan Nieder \n---\n builtin/clone.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 50bde99618..822208a346 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\t\tremote_head_points_at, &branch_top);\n \n \tif (filter_options.choice)\n-\t\tpartial_clone_register(\"origin\", &filter_options);\n+\t\tpartial_clone_register(option_origin, &filter_options);\n \n \tif (is_local)\n \t\tclone_local(path, git_dir);\n-- \n2.22.0.rc1.257.g3120a18244-goog\n\n"},{"id":"376418","messageId":"xmqqr28hxc9t.fsf@gitster-ct.c.googlers.com","threadId":"51163","inReplyTo":"20190524001525.12952-1-delphij@google.com","subject":"Re: [PATCH] clone: respect user supplied origin name when setting up partial clone","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-05-29T19:59:26Z","receivedAt":"2019-05-29T19:59:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Xin Li writes:\n\n> Signed-off-by: Xin Li \n> Reviewed-by: Jonathan Nieder \n> ---\n> builtin/clone.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks. Can you add a test to demonstrate existing breakage without\nthis single-line code change in the same patch?\n\n>\n> diff --git a/builtin/clone.c b/builtin/clone.c\n> index 50bde99618..822208a346 100644\n> --- a/builtin/clone.c\n> +++ b/builtin/clone.c\n> @@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n> \t\t\tremote_head_points_at, &branch_top);\n> \n> \tif (filter_options.choice)\n> -\t\tpartial_clone_register(\"origin\", &filter_options);\n> +\t\tpartial_clone_register(option_origin, &filter_options);\n> \n> \tif (is_local)\n> \t\tclone_local(path, git_dir);\n"},{"id":"376424","messageId":"20190529211610.190269-1-delphij@google.com","threadId":"51163","inReplyTo":"xmqqr28hxc9t.fsf@gitster-ct.c.googlers.com","subject":"[PATCH v3] clone: respect user supplied origin name when setting up partial clone","fromName":"Xin Li","fromEmail":"delphij@google.com","sentAt":"2019-05-29T21:16:10Z","receivedAt":"2019-05-29T21:16:33Z","isPatch":true,"sender":{"key":"delphij@google.com","avatar":"https://avatars.githubusercontent.com/u/1045626?v=4"},"body":"Signed-off-by: Xin Li \nReviewed-by: Jonathan Nieder \n---\n builtin/clone.c | 2 +-\n t/t5601-clone.sh | 15 +++++++++++++--\n 2 files changed, 14 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 50bde99618..822208a346 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\t\tremote_head_points_at, &branch_top);\n \n \tif (filter_options.choice)\n-\t\tpartial_clone_register(\"origin\", &filter_options);\n+\t\tpartial_clone_register(option_origin, &filter_options);\n \n \tif (is_local)\n \t\tclone_local(path, git_dir);\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex d6948cbdab..3595162c32 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -634,7 +634,7 @@ test_expect_success CASE_INSENSITIVE_FS 'colliding file detection' '\n \ttest_i18ngrep \"the following paths have collided\" icasefs/warning\n '\n \n-partial_clone () {\n+partial_clone_server () {\n \t SERVER=\"$1\" &&\n \t URL=\"$2\" &&\n \n@@ -646,8 +646,14 @@ partial_clone () {\n \ttest_commit -C \"$SERVER\" two &&\n \tHASH2=$(git hash-object \"$SERVER/two.t\") &&\n \ttest_config -C \"$SERVER\" uploadpack.allowfilter 1 &&\n-\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1 &&\n+\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1\n+}\n+\n+partial_clone () {\n+\t SERVER=\"$1\" &&\n+\t URL=\"$2\" &&\n \n+\tpartial_clone_server \"${SERVER}\" \"${URL}\" &&\n \tgit clone --filter=blob:limit=0 \"$URL\" client &&\n \n \tgit -C client fsck &&\n@@ -664,6 +670,11 @@ test_expect_success 'partial clone' '\n \tpartial_clone server \"file://$(pwd)/server\"\n '\n \n+test_expect_success 'partial clone with -o' '\n+\tpartial_clone_server server \"file://$(pwd)/server\" &&\n+\tgit clone -o blah --filter=blob:limit=0 \"${URL}\" client\n+'\n+\n test_expect_success 'partial clone: warn if server does not support object filtering' '\n \trm -rf server client &&\n \ttest_create_repo server &&\n-- \n2.22.0.rc1.257.g3120a18244-goog\n\n"},{"id":"376425","messageId":"20190529212231.197417-1-delphij@google.com","threadId":"51163","inReplyTo":"20190529211610.190269-1-delphij@google.com","subject":"[PATCH v4] clone: respect user supplied origin name when setting up partial clone","fromName":"Xin Li","fromEmail":"delphij@google.com","sentAt":"2019-05-29T21:22:31Z","receivedAt":"2019-05-29T21:22:37Z","isPatch":true,"sender":{"key":"delphij@google.com","avatar":"https://avatars.githubusercontent.com/u/1045626?v=4"},"body":"Signed-off-by: Xin Li \nReviewed-by: Jonathan Nieder \n---\n builtin/clone.c | 2 +-\n t/t5601-clone.sh | 16 +++++++++++++---\n 2 files changed, 14 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 50bde99618..822208a346 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\t\tremote_head_points_at, &branch_top);\n \n \tif (filter_options.choice)\n-\t\tpartial_clone_register(\"origin\", &filter_options);\n+\t\tpartial_clone_register(option_origin, &filter_options);\n \n \tif (is_local)\n \t\tclone_local(path, git_dir);\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex d6948cbdab..22066bb88c 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -634,9 +634,8 @@ test_expect_success CASE_INSENSITIVE_FS 'colliding file detection' '\n \ttest_i18ngrep \"the following paths have collided\" icasefs/warning\n '\n \n-partial_clone () {\n+partial_clone_server () {\n \t SERVER=\"$1\" &&\n-\t URL=\"$2\" &&\n \n \trm -rf \"$SERVER\" client &&\n \ttest_create_repo \"$SERVER\" &&\n@@ -646,8 +645,14 @@ partial_clone () {\n \ttest_commit -C \"$SERVER\" two &&\n \tHASH2=$(git hash-object \"$SERVER/two.t\") &&\n \ttest_config -C \"$SERVER\" uploadpack.allowfilter 1 &&\n-\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1 &&\n+\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1\n+}\n \n+partial_clone () {\n+\t SERVER=\"$1\" &&\n+\t URL=\"$2\" &&\n+\n+\tpartial_clone_server \"${SERVER}\" &&\n \tgit clone --filter=blob:limit=0 \"$URL\" client &&\n \n \tgit -C client fsck &&\n@@ -664,6 +669,11 @@ test_expect_success 'partial clone' '\n \tpartial_clone server \"file://$(pwd)/server\"\n '\n \n+test_expect_success 'partial clone with -o' '\n+\tpartial_clone_server server \"file://$(pwd)/server\" &&\n+\tgit clone -o blah --filter=blob:limit=0 \"file://$(pwd)/server\" client\n+'\n+\n test_expect_success 'partial clone: warn if server does not support object filtering' '\n \trm -rf server client &&\n \ttest_create_repo server &&\n-- \n2.22.0.rc1.257.g3120a18244-goog\n\n"},{"id":"376426","messageId":"20190529212643.206908-1-delphij@google.com","threadId":"51163","inReplyTo":"20190529212231.197417-1-delphij@google.com","subject":"[PATCH v5] clone: respect user supplied origin name when setting up partial clone","fromName":"Xin Li","fromEmail":"delphij@google.com","sentAt":"2019-05-29T21:26:43Z","receivedAt":"2019-05-29T21:26:55Z","isPatch":true,"sender":{"key":"delphij@google.com","avatar":"https://avatars.githubusercontent.com/u/1045626?v=4"},"body":"Signed-off-by: Xin Li \nReviewed-by: Jonathan Nieder \n---\n builtin/clone.c | 2 +-\n t/t5601-clone.sh | 16 +++++++++++++---\n 2 files changed, 14 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/clone.c b/builtin/clone.c\nindex 50bde99618..822208a346 100644\n--- a/builtin/clone.c\n+++ b/builtin/clone.c\n@@ -1215,7 +1215,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)\n \t\t\tremote_head_points_at, &branch_top);\n \n \tif (filter_options.choice)\n-\t\tpartial_clone_register(\"origin\", &filter_options);\n+\t\tpartial_clone_register(option_origin, &filter_options);\n \n \tif (is_local)\n \t\tclone_local(path, git_dir);\ndiff --git a/t/t5601-clone.sh b/t/t5601-clone.sh\nindex d6948cbdab..1fae8ae223 100755\n--- a/t/t5601-clone.sh\n+++ b/t/t5601-clone.sh\n@@ -634,9 +634,8 @@ test_expect_success CASE_INSENSITIVE_FS 'colliding file detection' '\n \ttest_i18ngrep \"the following paths have collided\" icasefs/warning\n '\n \n-partial_clone () {\n+partial_clone_server () {\n \t SERVER=\"$1\" &&\n-\t URL=\"$2\" &&\n \n \trm -rf \"$SERVER\" client &&\n \ttest_create_repo \"$SERVER\" &&\n@@ -646,8 +645,14 @@ partial_clone () {\n \ttest_commit -C \"$SERVER\" two &&\n \tHASH2=$(git hash-object \"$SERVER/two.t\") &&\n \ttest_config -C \"$SERVER\" uploadpack.allowfilter 1 &&\n-\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1 &&\n+\ttest_config -C \"$SERVER\" uploadpack.allowanysha1inwant 1\n+}\n \n+partial_clone () {\n+\t SERVER=\"$1\" &&\n+\t URL=\"$2\" &&\n+\n+\tpartial_clone_server \"${SERVER}\" &&\n \tgit clone --filter=blob:limit=0 \"$URL\" client &&\n \n \tgit -C client fsck &&\n@@ -664,6 +669,11 @@ test_expect_success 'partial clone' '\n \tpartial_clone server \"file://$(pwd)/server\"\n '\n \n+test_expect_success 'partial clone with -o' '\n+\tpartial_clone_server server &&\n+\tgit clone -o blah --filter=blob:limit=0 \"file://$(pwd)/server\" client\n+'\n+\n test_expect_success 'partial clone: warn if server does not support object filtering' '\n \trm -rf server client &&\n \ttest_create_repo server &&\n-- \n2.22.0.rc1.257.g3120a18244-goog\n\n"}]}