{"thread":{"id":"51059","subject":"Proposal: Remembering message IDs sent with git send-email","startedAt":"2019-05-08T23:10:17Z","lastAt":"2019-05-10T02:25:59Z","messageCount":6,"participants":["Drew DeVault","Emily Shaffer","Eric Wong"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"375194","messageId":"20190508231013.GA25216@homura.localdomain","threadId":"51059","inReplyTo":null,"subject":"Proposal: Remembering message IDs sent with git send-email","fromName":"Drew DeVault","fromEmail":"sir@cmpwn.com","sentAt":"2019-05-08T23:10:13Z","receivedAt":"2019-05-08T23:10:17Z","isPatch":false,"sender":{"key":"sir@cmpwn.com","avatar":"https://avatars.githubusercontent.com/u/1310872?v=4"},"body":"I want to gather some thoughts about this. Say you've written a patch\nseries and are getting ready to send a -v2. If you set\n--in-reply-to=ask, it'll show you a list of emails you've recently sent,\nand their subject lines, and ask you to pick one to use the message ID\nfrom. It'll set the In-Reply-To header to your selection.\n\nI'd also like to add a custom header, X-Patch-Supersedes: <message ID>,\nwith a similar behavior & purpose.\n\nThoughts?\n"},{"id":"375197","messageId":"20190509001959.GB14000@google.com","threadId":"51059","inReplyTo":"20190508231013.GA25216@homura.localdomain","subject":"Re: Proposal: Remembering message IDs sent with git send-email","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2019-05-09T00:19:59Z","receivedAt":"2019-05-09T00:20:08Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Wed, May 08, 2019 at 07:10:13PM -0400, Drew DeVault wrote:\n> I want to gather some thoughts about this. Say you've written a patch\n> series and are getting ready to send a -v2. If you set\n> --in-reply-to=ask, it'll show you a list of emails you've recently sent,\n> and their subject lines, and ask you to pick one to use the message ID\n> from. It'll set the In-Reply-To header to your selection.\n\nIt sounds to me like you mean to call this during `git format-patch` -\nthat is, `git format-patch -v2 --cover-letter --in-reply-to=ask master..branch\n-o branch/`. That should set the In-Reply-To: header on your cover\nletter.\n\nThere's also the possibility that you mean `git send-email\n--in-reply-to=ask branch/v2*` - in which case I imagine the In-Reply-To:\nis added as the message is sent, but not added to the cover letter text\nfile.\n\n> \n> I'd also like to add a custom header, X-Patch-Supersedes: <message ID>,\n> with a similar behavior & purpose.\n\nIs the hope to store the message ID you choose from --in-reply-to=ask\ninto the X-Patch-Supersedes: header? I'm not sure I understand what\nyou're trying to solve; if you use `git format-patch --in-reply-to` it\nsounds like the X-Patch-Supersedes: and In-Reply-To: would be redundant.\n\nIs it possible you mean you want (sorry for pseudocode scribblings)\n[PATCH v2 1/1]->X-Patch-Supersedes = [PATCH 1/1]->Message-Id ? I think that\nwouldn't look good in a threaded mail client?\n\n> \n> Thoughts?\n\nOr maybe I totally misunderstood :)\n\nWhat I think might be useful (and what I was hoping you were going to\ntalk about when I saw the subject line) would be if the Message-Id is\nconveniently stored during `git send-email` on v1 and somehow saved in a\nuseful place in order to apply to the In-Reply-To field on v2\nautomatically upon `git format-patch -v2`. I'll admit I didn't know\nabout --in-reply-to=ask and that helps with the pain point I've\nexperienced sending out v2 before.\n\n - Emily\n"},{"id":"375242","messageId":"20190509165025.GA18342@homura.localdomain","threadId":"51059","inReplyTo":"20190509001959.GB14000@google.com","subject":"Re: Proposal: Remembering message IDs sent with git send-email","fromName":"Drew DeVault","fromEmail":"sir@cmpwn.com","sentAt":"2019-05-09T16:50:25Z","receivedAt":"2019-05-09T16:50:29Z","isPatch":false,"sender":{"key":"sir@cmpwn.com","avatar":"https://avatars.githubusercontent.com/u/1310872?v=4"},"body":"On 2019-05-08  5:19 PM, Emily Shaffer wrote:\n> What I think might be useful (and what I was hoping you were going to\n> talk about when I saw the subject line) would be if the Message-Id is\n> conveniently stored during `git send-email` on v1 and somehow saved in a\n> useful place in order to apply to the In-Reply-To field on v2\n> automatically upon `git format-patch -v2`. I'll admit I didn't know\n> about --in-reply-to=ask and that helps with the pain point I've\n> experienced sending out v2 before.\n\n--in-reply-to=ask doesn't exist, that's what I'm looking to add. This\nconvenient storage mechanism is exactly what I'm talking about. Sorry\nfor the confusion.\n"},{"id":"375251","messageId":"20190509185136.GC14000@google.com","threadId":"51059","inReplyTo":"20190509165025.GA18342@homura.localdomain","subject":"Re: Proposal: Remembering message IDs sent with git send-email","fromName":"Emily Shaffer","fromEmail":"emilyshaffer@google.com","sentAt":"2019-05-09T18:51:36Z","receivedAt":"2019-05-09T19:00:21Z","isPatch":false,"sender":{"key":"nasamuffin@google.com","avatar":"https://avatars.githubusercontent.com/u/1606826?v=4"},"body":"On Thu, May 09, 2019 at 12:50:25PM -0400, Drew DeVault wrote:\n> On 2019-05-08  5:19 PM, Emily Shaffer wrote:\n> > What I think might be useful (and what I was hoping you were going to\n> > talk about when I saw the subject line) would be if the Message-Id is\n> > conveniently stored during `git send-email` on v1 and somehow saved in a\n> > useful place in order to apply to the In-Reply-To field on v2\n> > automatically upon `git format-patch -v2`. I'll admit I didn't know\n> > about --in-reply-to=ask and that helps with the pain point I've\n> > experienced sending out v2 before.\n> \n> --in-reply-to=ask doesn't exist, that's what I'm looking to add. This\n> convenient storage mechanism is exactly what I'm talking about. Sorry\n> for the confusion.\n\nLooking at the documentation, I suppose I hadn't realized before that\n--thread will generate a Message-Id for your cover letter. It does seem\nlike we could teach --thread to check for the previous patch's cover\nletter in the directory provided by -o. Of course, this wouldn't work\nif the author was generating v2 and didn't have the v1 files available\n(i.e. different workstation or different author picking up the set).\n\nI'm still not sure I see the value of the extra header proposed here.\nI'd appreciate an explanation of how you think it would be used, Drew.\n\nI don't know much about emailed workflows outside of Git; is this\nsomething likely to be useful to other communities?\n\n - Emily\n"},{"id":"375253","messageId":"20190509201401.mtinxj7wqjw6bvlg@dcvr","threadId":"51059","inReplyTo":"20190509165025.GA18342@homura.localdomain","subject":"Re: Proposal: Remembering message IDs sent with git send-email","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2019-05-09T20:14:01Z","receivedAt":"2019-05-09T20:14:05Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Drew DeVault <sir@cmpwn.com> wrote:\n> --in-reply-to=ask doesn't exist, that's what I'm looking to add. This\n> convenient storage mechanism is exactly what I'm talking about. Sorry\n> for the confusion.\n\nUsing Net::NNTP to query NNTP servers using ->xover([recent-ish\nrange]) to scan for Message-IDs and Subjects matching the\ncurrent ident could be an option, too.\n\nIt could cache the xover result for --dry-run and format-patch\ncases; and Net::NNTP is a standard Perl module.  Going online\nto do this query also benefits people who work across different\nmachines/environments, as it's one less thing to sync.\n\nFwiw, this list has:\n\tnntp://news.gmane.org/gmane.comp.version-control.git\n\tnntp://news.public-inbox.org/inbox.comp.version-control.git\n\nAnd there's a bunch of kernel lists at nntp://nntp.lore.kernel.org/\n"},{"id":"375279","messageId":"20190510022554.GD1281@homura.localdomain","threadId":"51059","inReplyTo":"20190509185136.GC14000@google.com","subject":"Re: Proposal: Remembering message IDs sent with git send-email","fromName":"Drew DeVault","fromEmail":"sir@cmpwn.com","sentAt":"2019-05-10T02:25:55Z","receivedAt":"2019-05-10T02:25:59Z","isPatch":false,"sender":{"key":"sir@cmpwn.com","avatar":"https://avatars.githubusercontent.com/u/1310872?v=4"},"body":"On 2019-05-09 11:51 AM, Emily Shaffer wrote:\n> I'm still not sure I see the value of the extra header proposed here.\n> I'd appreciate an explanation of how you think it would be used, Drew.\n\nI'm not just thinking about your run of the mill mail reader, but also\nmail readers which are aware of git and could use it to provide\ngit-specific features for browsing patchsets. Distinguishing it from the\nmecahnism used for normal conversation allows us to have fewer\nheuristics in such software.\n"}]}