{"thread":{"id":"51056","subject":"[PATCH] tag: fix typo in nested tagging hint","startedAt":"2019-05-08T19:16:47Z","lastAt":"2019-05-09T06:09:23Z","messageCount":2,"participants":["Denton Liu","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"375179","messageId":"4213b04b1f7262bc53c83dffc82956951dfe869f.1557342925.git.liu.denton@gmail.com","threadId":"51056","inReplyTo":null,"subject":"[PATCH] tag: fix typo in nested tagging hint","fromName":"Denton Liu","fromEmail":"liu.denton@gmail.com","sentAt":"2019-05-08T19:16:41Z","receivedAt":"2019-05-08T19:16:47Z","isPatch":true,"sender":{"key":"liu.denton@gmail.com","avatar":"https://avatars.githubusercontent.com/u/9620836?v=4"},"body":"In eea9c1e78f (tag: advise on nested tags, 2019-04-04), tag was taught\nto hint at the user if a nested tag is made. However, this message had a\ntypo and it said \"The object referred to by your new is...\", which was\nmissing a \"tag\" after \"new\". Fix this message by adding the \"tag\".\n\nSigned-off-by: Denton Liu <liu.denton@gmail.com>\n---\nHi Junio, sorry we didn't catch this before it got merged into master.\nJust a small typofix.\n\n builtin/tag.c  | 2 +-\n t/t7004-tag.sh | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/tag.c b/builtin/tag.c\nindex 1debd3a11c..ef37dccf86 100644\n--- a/builtin/tag.c\n+++ b/builtin/tag.c\n@@ -207,7 +207,7 @@ struct create_tag_options {\n };\n \n static const char message_advice_nested_tag[] =\n-\tN_(\"You have created a nested tag. The object referred to by your new is\\n\"\n+\tN_(\"You have created a nested tag. The object referred to by your new tag is\\n\"\n \t   \"already a tag. If you meant to tag the object that it points to, use:\\n\"\n \t   \"\\n\"\n \t   \"\\tgit tag -f %s %s^{}\");\ndiff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\nindex e285686662..6aeeb279a0 100755\n--- a/t/t7004-tag.sh\n+++ b/t/t7004-tag.sh\n@@ -1702,7 +1702,7 @@ test_expect_success '--points-at finds annotated tags of tags' '\n \n test_expect_success 'recursive tagging should give advice' '\n \tsed -e \"s/|$//\" <<-EOF >expect &&\n-\thint: You have created a nested tag. The object referred to by your new is\n+\thint: You have created a nested tag. The object referred to by your new tag is\n \thint: already a tag. If you meant to tag the object that it points to, use:\n \thint: |\n \thint: \tgit tag -f nested annotated-v4.0^{}\n-- \n2.21.0.1049.geb646f7864\n\n"},{"id":"375201","messageId":"xmqq4l64f9bl.fsf@gitster-ct.c.googlers.com","threadId":"51056","inReplyTo":"4213b04b1f7262bc53c83dffc82956951dfe869f.1557342925.git.liu.denton@gmail.com","subject":"Re: [PATCH] tag: fix typo in nested tagging hint","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-05-09T06:09:18Z","receivedAt":"2019-05-09T06:09:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Denton Liu <liu.denton@gmail.com> writes:\n\n> In eea9c1e78f (tag: advise on nested tags, 2019-04-04), tag was taught\n> to hint at the user if a nested tag is made. However, this message had a\n> typo and it said \"The object referred to by your new is...\", which was\n> missing a \"tag\" after \"new\". Fix this message by adding the \"tag\".\n\nThanks.  Makes sense.  Will apply.\n"}]}