{"thread":{"id":"50916","subject":"Local Config File: Submodule initialization looks broken with the --recurse-submodules option when cloning a repository","startedAt":"2019-04-11T02:36:09Z","lastAt":"2019-10-15T00:39:27Z","messageCount":3,"participants":["ron","Ron"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"373624","messageId":"Otial29UjnjP-PuGN9Mwnd8k4q8Alof6wWOxFqYv_mXpNbumrljWGN44RvNZYIkC-in7KSXzjFjbceYglTW4iACRcven7CyHUUSUcPCWbL4=@protonmail.com","threadId":"50916","inReplyTo":null,"subject":"Local Config File: Submodule initialization looks broken with the --recurse-submodules option when cloning a repository","fromName":"ron","fromEmail":"ronazek@protonmail.com","sentAt":"2019-04-11T02:36:01Z","receivedAt":"2019-04-11T02:36:09Z","isPatch":false,"sender":{"key":"ronazek@protonmail.com","avatar":null},"body":"Initially reported for GFW on version 2.20.1, I have tested with Linux Mint Mate 19.1 Tessa which by default uses git version 2.17.1\n\nIt produces a config file with the relevant submodule entries looking like this:\n\n----------------\n[submodule]\n\tactive = .\n\n[submodule \"Submodule/Path\"]\n\turl = https://github.com/organization/submodule.git\n----------------\n\nInstead of that, which is produced by manually initializing a submodule anytime after cloning:\n\n----------------\n [submodule \"Submodule/Path\"]\n\tactive = true\n\turl = https://github.com/organization/submodule.git\n----------------\n\nSent with ProtonMail Secure Email.\n\n\n"},{"id":"384003","messageId":"ZkLbpInDB0A-uWL3lVcy67PplIX56Pr7qakiHnXnP4OInRFs20ZPH3wDZl-LNoCNRv-_4HlTwa9LLkrWjdVFPshEi-JXVAhHwsLdp2ivJew=@protonmail.com","threadId":"50916","inReplyTo":"Otial29UjnjP-PuGN9Mwnd8k4q8Alof6wWOxFqYv_mXpNbumrljWGN44RvNZYIkC-in7KSXzjFjbceYglTW4iACRcven7CyHUUSUcPCWbL4=@protonmail.com","subject":"Re: Local Config File: Submodule initialization looks broken with the --recurse-submodules option when cloning a repository","fromName":"Ron","fromEmail":"ronazek@protonmail.com","sentAt":"2019-10-14T01:35:16Z","receivedAt":"2019-10-14T01:35:26Z","isPatch":false,"sender":{"key":"ronazek@protonmail.com","avatar":null},"body":"> Initially reported for GFW on version 2.20.1, I have tested with Linux Mint Mate 19.1 Tessa which by default uses git version 2.17.1\n>\n> It produces a config file with the relevant submodule entries looking like this:\n>\n> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n>\n> [submodule]\n> active = .\n>\n> [submodule \"Submodule/Path\"]\n> url = https://github.com/organization/submodule.git\n>\n> ---------------------------------------------------------------------------------------------------------\n>\n> Instead of that, which is produced by manually initializing a submodule anytime after cloning:\n>\n> -------------------------------------------------------------------------------------------------\n>\n> [submodule \"Submodule/Path\"]\n> active = true\n> url = https://github.com/organization/submodule.git\n>\n> -----------------------------------------------------------------------------------------------\n>\n> Sent with ProtonMail Secure Email.\n\nI've got someone to test this with the latest 2.23.0 version on archlinux.\n\nIt is still happening:\n\ngit clone --depth=1 --recurse-submodules --origin upstream https://github.com/git-for-windows/git;\ngit -C git config --get submodule.active\nexpected true, got .\n\n\nAnything more I need to add to help this get solved?\n\nSent with ProtonMail Secure Email.\n\n"},{"id":"384051","messageId":"XqdveI1_zW78uGKUxGnJanJ87mg_lJaw9tKylbfgadEeKlVUlOx5juZWpXC0OPDC4lD60mbRTHDm64HqP1Jxw-A9byDF9le2YfuECuatGQk=@protonmail.com","threadId":"50916","inReplyTo":"ZkLbpInDB0A-uWL3lVcy67PplIX56Pr7qakiHnXnP4OInRFs20ZPH3wDZl-LNoCNRv-_4HlTwa9LLkrWjdVFPshEi-JXVAhHwsLdp2ivJew=@protonmail.com","subject":"Re: Local Config File: Submodule initialization looks broken with the --recurse-submodules option when cloning a repository","fromName":"Ron","fromEmail":"ronazek@protonmail.com","sentAt":"2019-10-15T00:39:18Z","receivedAt":"2019-10-15T00:39:27Z","isPatch":false,"sender":{"key":"ronazek@protonmail.com","avatar":null},"body":"> I've got someone to test this with the latest 2.23.0 version on archlinux.\n>\n> It is still happening:\n>\n> git clone --depth=1 --recurse-submodules --origin upstream https://github.com/git-for-windows/git;\n> git -C git config --get submodule.active\n> expected true, got .\n>\n> Anything more I need to add to help this get solved?\n>\n> Sent with ProtonMail Secure Email.\n\nThis appears to have been a false positive, there are 2 different kind of \"active\" parameters in the config file\nand this is, according to the docs, expected behavior. I'm not sure if the other tester wrote the last line\nhimself or did git wrote that for him, because on GFW that command only outputs the value if there is one.\n\nI cannot reproduce the error anymore that I thought was happening because of this, it never caused a problem\nwhen cloning or when applying submodule later, it must have been a coincidence at the time.\n\nThe effect is \"equivalent\" as the docs say, whether doing \"--recurse-submodule\" (without specifying pathspec)\nat clone time or doing a normal clone and running \"git submodule update --init --recursive\" afterward,\nbut technically the config file will not be the same.\n\nSorry for the inconvenience.\n\n"}]}