{"thread":{"id":"50894","subject":"[PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg","startedAt":"2019-04-08T13:21:21Z","lastAt":"2019-05-27T19:37:34Z","messageCount":3,"participants":["Ismael Luceno Cortes","Ismael Luceno","Johannes Schindelin"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"373420","messageId":"20190408125406.16703-1-ismael.luceno@silicon-gears.com","threadId":"50894","inReplyTo":null,"subject":"[PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg","fromName":"Ismael Luceno Cortes","fromEmail":"ismael.luceno@silicon-gears.com","sentAt":"2019-04-08T12:54:54Z","receivedAt":"2019-04-08T13:21:21Z","isPatch":true,"sender":{"key":"ismael.luceno@silicon-gears.com","avatar":null},"body":"- Control+BackSpace: Delete word to the left of the cursor.\n- Control+Delete   : Delete word to the right of the cursor.\n\nOriginally introduced by BRIEF and Turbo Vision between 1985 and 1992,\nthey were adopted by most CUA-Compliant UIs, including those of: OS/2,\nWindows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs.\n\nIn both cases Tk already implements the functionality bound to other key\ncombination, so we use that.\n\nGraphical examples:\n\nDeleting to the left:\n        v------ pointer\nX_WORD____X\n  ^-----^------ selection\n\nDeleting to the right:\n  v--------- pointer\nX_WORD_X\n  ^--^------ selection\n\nSigned-off-by: Ismael Luceno <ismael.luceno@silicon-gears.com>\n\n---\n\nCC: Junio C Hamano <gitster@pobox.com>\nCC: \"brian m. carlson\" <sandals@crustytoothpaste.net>\nCC: Pat Thoyts <patthoyts@users.sourceforge.net>\n\nNotes:\n    Changes since v2:\n    - Reimplemented via existing events, which correctly delete spaces.\n    - Further improved commit message.\n    \n    Changes since v1:\n    - Improved commit message.\n\n git-gui/git-gui.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 6de74ce639..c4e0270626 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -3812,6 +3812,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}\n bind $ui_comm <$M1B-Key-equal> {show_more_context;break}\n bind $ui_comm <$M1B-Key-plus> {show_more_context;break}\n bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}\n+bind $ui_comm <Control-Key-BackSpace> {event generate %W <Meta-Delete>;break}\n+bind $ui_comm <Control-Key-Delete> {event generate %W <Meta-d>;break}\n \n bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}\n bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}\n-- \n2.19.1\n"},{"id":"374946","messageId":"20190506144122.GE4920@kiki","threadId":"50894","inReplyTo":"20190408125406.16703-1-ismael.luceno@silicon-gears.com","subject":"Re: [PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg","fromName":"Ismael Luceno","fromEmail":"ismael@iodev.co.uk","sentAt":"2019-05-06T14:41:22Z","receivedAt":"2019-05-06T14:50:45Z","isPatch":true,"sender":{"key":"ismael@iodev.co.uk","avatar":"https://avatars.githubusercontent.com/u/426980?v=4"},"body":"On 08/Apr/2019 12:54, Ismael Luceno Cortes wrote:\n> - Control+BackSpace: Delete word to the left of the cursor.\n> - Control+Delete   : Delete word to the right of the cursor.\n> \n> Originally introduced by BRIEF and Turbo Vision between 1985 and 1992,\n> they were adopted by most CUA-Compliant UIs, including those of: OS/2,\n> Windows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs.\n> \n> In both cases Tk already implements the functionality bound to other key\n> combination, so we use that.\n<...>\n\nPing.\n"},{"id":"376245","messageId":"nycvar.QRO.7.76.6.1905272135280.28524@tvgsbejvaqbjf.bet","threadId":"50894","inReplyTo":"20190506144122.GE4920@kiki","subject":"Re: [PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-05-27T19:37:10Z","receivedAt":"2019-05-27T19:37:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Mon, 6 May 2019, Ismael Luceno wrote:\n\n> On 08/Apr/2019 12:54, Ismael Luceno Cortes wrote:\n> > - Control+BackSpace: Delete word to the left of the cursor.\n> > - Control+Delete   : Delete word to the right of the cursor.\n> >\n> > Originally introduced by BRIEF and Turbo Vision between 1985 and 1992,\n> > they were adopted by most CUA-Compliant UIs, including those of: OS/2,\n> > Windows, Mac OS, Qt, GTK, Open/Libre Office, Gecko, and GNU Emacs.\n> >\n> > In both cases Tk already implements the functionality bound to other key\n> > combination, so we use that.\n> <...>\n>\n> Ping.\n\nFWIW I am in favor of this patch. It is simple enough, and the commit\nmessage does a good job explaining why it is a good idea to do it.\n\nIt's too bad that we do not have any active Git GUI maintainer... :-(\n\nCiao,\nJohannes\n"}]}