{"thread":{"id":"50827","subject":"[GSoC][PATCH] microporject test_path_is_*","startedAt":"2019-03-27T12:26:00Z","lastAt":"2019-03-28T18:01:17Z","messageCount":6,"participants":["Mooga","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"372572","messageId":"1A5DE2FC-7D94-4785-A915-EA2A71C6C377@m-mooga.com","threadId":"50827","inReplyTo":null,"subject":"[GSoC][PATCH] microporject test_path_is_*","fromName":"Mooga","fromEmail":"contact@m-mooga.com","sentAt":"2019-03-27T12:24:25Z","receivedAt":"2019-03-27T12:26:00Z","isPatch":true,"sender":{"key":"contact@m-mooga.com","avatar":null},"body":"\nSo for example  that is git diff\n\ndiff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh\nindex 286bba35d8..fc82965a0f 100755\n--- a/t/t2400-worktree-add.sh\n+++ b/t/t2400-worktree-add.sh\n@@ -66,7 +66,7 @@ test_expect_success '\"add\" worktree' '\ntest_expect_success '\"add\" worktree with lock' '\n        git rev-parse HEAD >expect &&\n        git worktree add --detach --lock here-with-lock master &&\n-       test -f .git/worktrees/here-with-lock/locked\n+       test_path_is_file .git/worktrees/here-with-lock/locked\n\n\n\nI would like to hear feedback if I should commit \n\n\n\n\n"},{"id":"372582","messageId":"CABPp-BE9vNhnN6XdcxnePnXkek0bNogAiA_cKJqZ1-ct=QA2pw@mail.gmail.com","threadId":"50827","inReplyTo":"1A5DE2FC-7D94-4785-A915-EA2A71C6C377@m-mooga.com","subject":"Re: [GSoC][PATCH] microporject test_path_is_*","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2019-03-27T17:05:27Z","receivedAt":"2019-03-27T17:05:41Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"Hi Mooga,\n\nOn Wed, Mar 27, 2019 at 5:27 AM Mooga wrote:\n>\n>\n> So for example that is git diff\n>\n> diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh\n> index 286bba35d8..fc82965a0f 100755\n> --- a/t/t2400-worktree-add.sh\n> +++ b/t/t2400-worktree-add.sh\n> @@ -66,7 +66,7 @@ test_expect_success '\"add\" worktree' '\n> test_expect_success '\"add\" worktree with lock' '\n> git rev-parse HEAD >expect &&\n> git worktree add --detach --lock here-with-lock master &&\n> - test -f .git/worktrees/here-with-lock/locked\n> + test_path_is_file .git/worktrees/here-with-lock/locked\n>\n> I would like to hear feedback if I should commit\n\nAs you noticed from the other thread, there are folks who are now\nunsure whether this microproject suggestion is a good idea anymore.\nPersonally, I like the test_path_is_* slightly better, but the real\nissue is that we didn't have that discussion before starting the GSoC\nprocess and putting it up as a suggestion on the microprojects page.\nI think the main purpose is getting people familiar with creating and\nsubmitting patches, so I'd go ahead and make this change as well as\nothers needed in that file and submit it. Maybe the patch doesn't get\napplied but if you've created a correct commit and submitted it as a\npatch to the mailing list, I'd still count it as a successful\nmicroproject.\n"},{"id":"372586","messageId":"BF34A383-7714-40CC-B5EF-4FD20E7AC839@m-mooga.com","threadId":"50827","inReplyTo":"CABPp-BE9vNhnN6XdcxnePnXkek0bNogAiA_cKJqZ1-ct=QA2pw@mail.gmail.com","subject":"Re: [GSoC][PATCH] microporject test_path_is_*","fromName":"Mooga","fromEmail":"contact@m-mooga.com","sentAt":"2019-03-27T20:29:54Z","receivedAt":"2019-03-27T20:31:17Z","isPatch":true,"sender":{"key":"contact@m-mooga.com","avatar":null},"body":"Hi Eliah, \nthanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example \n\n\nRegards\n\nOn 27.03.19, 18:06, \"Elijah Newren\" wrote:\n\n Hi Mooga,\n \n On Wed, Mar 27, 2019 at 5:27 AM Mooga wrote:\n >\n >\n > So for example that is git diff\n >\n > diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh\n > index 286bba35d8..fc82965a0f 100755\n > --- a/t/t2400-worktree-add.sh\n > +++ b/t/t2400-worktree-add.sh\n > @@ -66,7 +66,7 @@ test_expect_success '\"add\" worktree' '\n > test_expect_success '\"add\" worktree with lock' '\n > git rev-parse HEAD >expect &&\n > git worktree add --detach --lock here-with-lock master &&\n > - test -f .git/worktrees/here-with-lock/locked\n > + test_path_is_file .git/worktrees/here-with-lock/locked\n >\n > I would like to hear feedback if I should commit\n \n As you noticed from the other thread, there are folks who are now\n unsure whether this microproject suggestion is a good idea anymore.\n Personally, I like the test_path_is_* slightly better, but the real\n issue is that we didn't have that discussion before starting the GSoC\n process and putting it up as a suggestion on the microprojects page.\n I think the main purpose is getting people familiar with creating and\n submitting patches, so I'd go ahead and make this change as well as\n others needed in that file and submit it. Maybe the patch doesn't get\n applied but if you've created a correct commit and submitted it as a\n patch to the mailing list, I'd still count it as a successful\n microproject.\n \n\n\n"},{"id":"372623","messageId":"CABPp-BGiP8BZwWQMbYhVQjqq8jZx+bbUTfgLaC6ZyukpLErZBw@mail.gmail.com","threadId":"50827","inReplyTo":"BF34A383-7714-40CC-B5EF-4FD20E7AC839@m-mooga.com","subject":"Re: [GSoC][PATCH] microporject test_path_is_*","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2019-03-28T16:02:07Z","receivedAt":"2019-03-28T16:02:21Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote:\n>\n> Hi Eliah,\n> thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example\n>\n>\n> Regards\n\nOn this list, please respond to emails interleaved or below the\noriginal email; we discourage top-posting.\n\nWhat part of the process is confusing? Without knowing that, we're\nlikely to just repeat the document as it stands. Also, have you taken\na look at https://gitgitgadget.github.io/ (which is a new thing\ndesigned to make submitting patches to git.git easier)?\n\nHope that helps,\nElijah\n"},{"id":"372633","messageId":"1B12FDC7-20CD-4044-AA88-AE9A4E942531@m-mooga.com","threadId":"50827","inReplyTo":"CABPp-BGiP8BZwWQMbYhVQjqq8jZx+bbUTfgLaC6ZyukpLErZBw@mail.gmail.com","subject":"Re: [GSoC][PATCH] microporject test_path_is_*","fromName":"Mooga","fromEmail":"contact@m-mooga.com","sentAt":"2019-03-28T17:07:32Z","receivedAt":"2019-03-28T17:08:56Z","isPatch":true,"sender":{"key":"contact@m-mooga.com","avatar":null},"body":"I have done what is https://gitgitgadget.github.io/ but the problem is\nmy pull request not being successful even what I have changed is \" test_path_is_dir \" in test file \"t2400\", it returns\n\nPowerShell exited with code '1'.\nPublishing build artifacts failed with an error: Not found PathtoPublish: D:\\a\\1\\s\\t\\failed-test-artifacts\n\nI have contributed before in open source community and I just need a quick review to continue the proposal\n\nOn 28.03.19, 17:03, \"Elijah Newren\" wrote:\n\n On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote:\n >\n > Hi Eliah,\n > thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example\n >\n >\n > Regards\n \n On this list, please respond to emails interleaved or below the\n original email; we discourage top-posting.\n \n What part of the process is confusing? Without knowing that, we're\n likely to just repeat the document as it stands. Also, have you taken\n a look at https://gitgitgadget.github.io/ (which is a new thing\n designed to make submitting patches to git.git easier)?\n \n Hope that helps,\n Elijah\n \n\n\n"},{"id":"372639","messageId":"CABPp-BHbEkVfhh_Q=_ZD2nNF+J+NdNmDL4nR-yH2WGmSvbx0Cg@mail.gmail.com","threadId":"50827","inReplyTo":"1B12FDC7-20CD-4044-AA88-AE9A4E942531@m-mooga.com","subject":"Re: [GSoC][PATCH] microporject test_path_is_*","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2019-03-28T18:01:02Z","receivedAt":"2019-03-28T18:01:17Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"Hi Mooga,\n\nOn Thu, Mar 28, 2019 at 10:08 AM Mooga wrote:\n>\n> I have done what is https://gitgitgadget.github.io/ but the problem is\n> my pull request not being successful even what I have changed is \" test_path_is_dir \" in test file \"t2400\", it returns\n>\n> PowerShell exited with code '1'.\n> Publishing build artifacts failed with an error: Not found PathtoPublish: D:\\a\\1\\s\\t\\failed-test-artifacts\n>\n> I have contributed before in open source community and I just need a quick review to continue the proposal\n\nPlease don't top-post.\n\nI may have to allow others to respond as I haven't used Windows\nmeaningfully in over two decades and don't know how to do anything\nuseful on that OS, but the fact you are attempting to run these bourne\nshell scripts with PowerShell suggests you are not invoking them\ncorrectly. You'll need to get and use some version of Bash; see\nhttps://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md\n\n\nHope that helps,\nElijah\n\n\n> On 28.03.19, 17:03, \"Elijah Newren\" wrote:\n>\n> On Wed, Mar 27, 2019 at 1:31 PM Mooga wrote:\n> >\n> > Hi Eliah,\n> > thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example\n> >\n> >\n> > Regards\n>\n> On this list, please respond to emails interleaved or below the\n> original email; we discourage top-posting.\n>\n> What part of the process is confusing? Without knowing that, we're\n> likely to just repeat the document as it stands. Also, have you taken\n> a look at https://gitgitgadget.github.io/ (which is a new thing\n> designed to make submitting patches to git.git easier)?\n>\n> Hope that helps,\n> Elijah\n>\n>\n>\n"}]}