{"thread":{"id":"50753","subject":"[PATCH] fix pack protocol example client/server communication","startedAt":"2019-03-16T09:29:54Z","lastAt":"2019-03-18T05:37:44Z","messageCount":2,"participants":["Mike Hommey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"371644","messageId":"20190316085707.4151-1-mh@glandium.org","threadId":"50753","inReplyTo":null,"subject":"[PATCH] fix pack protocol example client/server communication","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2019-03-16T08:57:07Z","receivedAt":"2019-03-16T09:29:54Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"The pkt-line formatted lines contained the wrong pkt-len.\n\nSigned-off-by: Mike Hommey <mh@glandium.org>\n---\n Documentation/technical/pack-protocol.txt | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\nindex 7a2375a55d..c73e72de0e 100644\n--- a/Documentation/technical/pack-protocol.txt\n+++ b/Documentation/technical/pack-protocol.txt\n@@ -657,14 +657,14 @@ can be rejected.\n An example client/server communication might look like this:\n \n ----\n-   S: 007c74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\\0report-status delete-refs ofs-delta\\n\n+   S: 006274730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\\0report-status delete-refs ofs-delta\\n\n    S: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug\\n\n    S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master\\n\n-   S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\\n\n+   S: 003d74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\\n\n    S: 0000\n \n-   C: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\\n\n-   C: 003e74730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\\n\n+   C: 00677d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\\n\n+   C: 006874730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\\n\n    C: 0000\n    C: [PACKDATA]\n \n-- \n2.21.0\n\n"},{"id":"371775","messageId":"xmqqimwg4uaj.fsf@gitster-ct.c.googlers.com","threadId":"50753","inReplyTo":"20190316085707.4151-1-mh@glandium.org","subject":"Re: [PATCH] fix pack protocol example client/server communication","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-03-18T05:37:40Z","receivedAt":"2019-03-18T05:37:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mike Hommey <mh@glandium.org> writes:\n\n> The pkt-line formatted lines contained the wrong pkt-len.\n\nWow.\n\n>\n> Signed-off-by: Mike Hommey <mh@glandium.org>\n> ---\n>  Documentation/technical/pack-protocol.txt | 8 ++++----\n>  1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/technical/pack-protocol.txt b/Documentation/technical/pack-protocol.txt\n> index 7a2375a55d..c73e72de0e 100644\n> --- a/Documentation/technical/pack-protocol.txt\n> +++ b/Documentation/technical/pack-protocol.txt\n> @@ -657,14 +657,14 @@ can be rejected.\n>  An example client/server communication might look like this:\n>  \n>  ----\n> -   S: 007c74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\\0report-status delete-refs ofs-delta\\n\n> +   S: 006274730d410fcb6603ace96f1dc55ea6196122532d refs/heads/local\\0report-status delete-refs ofs-delta\\n\n\nThis miscounts from the very beginning.  I am not sure where the\nmistake came from originally.\n\n>     S: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe refs/heads/debug\\n\n>     S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/master\\n\n> -   S: 003f74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\\n\n> +   S: 003d74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/team\\n\n\nThis too miscounts from the very beginning of this content; it is\nlikely that it was copied and pasted from the line above, which does\nhave a correct bytecount.\n\n>     S: 0000\n>  \n> -   C: 003e7d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\\n\n> -   C: 003e74730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\\n\n\nThese are likely copy-and-paste from the above ;-)\n\n> +   C: 00677d1665144a3a975c05f1f43902ddaf084e784dbe 74730d410fcb6603ace96f1dc55ea6196122532d refs/heads/debug\\n\n> +   C: 006874730d410fcb6603ace96f1dc55ea6196122532d 5a3f6be755bbb7deae50065988cbfa1ffa9ab68a refs/heads/master\\n\n\nI counted these myself before applying, and they look correct ;-)\n\nThanks.\n\n>     C: 0000\n>     C: [PACKDATA]\n"}]}