{"thread":{"id":"50718","subject":"[PATCH] t4150: remove unused variable","startedAt":"2019-03-12T14:38:10Z","lastAt":"2019-03-13T14:47:34Z","messageCount":3,"participants":["Andrei Rybak","Junio C Hamano","Phillip Wood"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"371267","messageId":"36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com","threadId":"50718","inReplyTo":null,"subject":"[PATCH] t4150: remove unused variable","fromName":"Andrei Rybak","fromEmail":"rybak.a.v@gmail.com","sentAt":"2019-03-12T14:38:04Z","receivedAt":"2019-03-12T14:38:10Z","isPatch":true,"sender":{"key":"rybak.a.v@gmail.com","avatar":"https://avatars.githubusercontent.com/u/624072?v=4"},"body":"In commit 735285b403 (\"am: fix signoff when other trailers are present\",\n2017-08-08) tests using variable $signoff were rewritten and it is no\nlonger used, so just remove it from the test setup.\n\nSigned-off-by: Andrei Rybak <rybak.a.v@gmail.com>\n---\n t/t4150-am.sh | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/t/t4150-am.sh b/t/t4150-am.sh\nindex 55b577d919..3f7f750cc8 100755\n--- a/t/t4150-am.sh\n+++ b/t/t4150-am.sh\n@@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '\n \n \tprintf \"Subject: \" >subject-prefix &&\n \n-\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF &&\n+\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF\n \tThis line should not be included in the commit message with --scissors enabled.\n \n \t - - >8 - - remove everything above this line - - >8 - -\n \n \tEOF\n-\n-\tsignoff=\"Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>\"\n '\n \n test_expect_success setup '\n-- \n2.20.1\n\n"},{"id":"371322","messageId":"xmqqa7hzfrsv.fsf@gitster-ct.c.googlers.com","threadId":"50718","inReplyTo":"36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com","subject":"Re: [PATCH] t4150: remove unused variable","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-03-13T02:10:08Z","receivedAt":"2019-03-13T02:10:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrei Rybak <rybak.a.v@gmail.com> writes:\n\n> In commit 735285b403 (\"am: fix signoff when other trailers are present\",\n> 2017-08-08) tests using variable $signoff were rewritten and it is no\n> longer used, so just remove it from the test setup.\n>\n> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>\n> ---\n>  t/t4150-am.sh | 4 +---\n>  1 file changed, 1 insertion(+), 3 deletions(-)\n\nLooks good; thanks.\n\n>\n> diff --git a/t/t4150-am.sh b/t/t4150-am.sh\n> index 55b577d919..3f7f750cc8 100755\n> --- a/t/t4150-am.sh\n> +++ b/t/t4150-am.sh\n> @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '\n>  \n>  \tprintf \"Subject: \" >subject-prefix &&\n>  \n> -\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF &&\n> +\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF\n>  \tThis line should not be included in the commit message with --scissors enabled.\n>  \n>  \t - - >8 - - remove everything above this line - - >8 - -\n>  \n>  \tEOF\n> -\n> -\tsignoff=\"Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>\"\n>  '\n>  \n>  test_expect_success setup '\n"},{"id":"371368","messageId":"936bfc66-c121-a036-4ccf-c9877560bc33@gmail.com","threadId":"50718","inReplyTo":"36ad743f-8429-a6ff-7fad-15e5dba01483@gmail.com","subject":"Re: [PATCH] t4150: remove unused variable","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2019-03-13T14:47:29Z","receivedAt":"2019-03-13T14:47:34Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"On 12/03/2019 14:38, Andrei Rybak wrote:\n> In commit 735285b403 (\"am: fix signoff when other trailers are present\",\n> 2017-08-08) tests using variable $signoff were rewritten and it is no\n> longer used, so just remove it from the test setup.\n\nWell spotted, thanks\n\nPhillip\n\n> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>\n> ---\n>   t/t4150-am.sh | 4 +---\n>   1 file changed, 1 insertion(+), 3 deletions(-)\n> \n> diff --git a/t/t4150-am.sh b/t/t4150-am.sh\n> index 55b577d919..3f7f750cc8 100755\n> --- a/t/t4150-am.sh\n> +++ b/t/t4150-am.sh\n> @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '\n>   \n>   \tprintf \"Subject: \" >subject-prefix &&\n>   \n> -\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF &&\n> +\tcat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\\EOF\n>   \tThis line should not be included in the commit message with --scissors enabled.\n>   \n>   \t - - >8 - - remove everything above this line - - >8 - -\n>   \n>   \tEOF\n> -\n> -\tsignoff=\"Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>\"\n>   '\n>   \n>   test_expect_success setup '\n> \n"}]}