{"thread":{"id":"50693","subject":"[PATCH 1/2] modified dir-iterator.c","startedAt":"2019-03-08T13:06:17Z","lastAt":"2019-03-08T13:06:17Z","messageCount":1,"participants":["sushmaunnibhavi"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"370986","messageId":"20190308130605.GA20220@hacker-queen","threadId":"50693","inReplyTo":null,"subject":"[PATCH 1/2] modified dir-iterator.c","fromName":"sushmaunnibhavi","fromEmail":"sushmaunnibhavi425@gmail.com","sentAt":"2019-03-08T13:06:05Z","receivedAt":"2019-03-08T13:06:17Z","isPatch":true,"sender":{"key":"sushmaunnibhavi425@gmail.com","avatar":null},"body":"---\nSome places in git use raw API opendir/readdir/closedir to traverse a directory recursively, which usually involves function recursion. Now that we have struct dir_iterator,we have to convert these to use the dir-iterator to simplify the code. \n\nSigned-off-by: Sushma Unnibhavi <sushmaunnibhavi425@gmail.com>\n dir-iterator.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/dir-iterator.c b/dir-iterator.c\nindex f2dcd82fde..a3b5b8929c 100644\n--- a/dir-iterator.c\n+++ b/dir-iterator.c\n@@ -169,7 +169,7 @@ int dir_iterator_abort(struct dir_iterator *dir_iterator)\n \t\tstruct dir_iterator_level *level =\n \t\t\t&iter->levels[iter->levels_nr - 1];\n \n-\t\tif (level->dir && closedir(level->dir)) {\n+\t\tif (level->dir && (struct dir_iterator_int *)(level->dir)) {//changed closedir to (struct dir_iterator_int *)\n \t\t\tstrbuf_setlen(&iter->base.path, level->prefix_len);\n \t\t\twarning(\"error closing directory %s: %s\",\n \t\t\t\titer->base.path.buf, strerror(errno));\n-- \n2.17.1\n\n"}]}