{"thread":{"id":"5066","subject":"Re: git+ssh://master.kernel.org/home/rmk/linux-2.6-arm.git","startedAt":"2006-08-01T08:46:03Z","lastAt":"2006-08-01T09:04:09Z","messageCount":3,"participants":["Junio C Hamano","Andrew Morton"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"24496","messageId":"7v4pww3ktw.fsf@assigned-by-dhcp.cox.net","threadId":"5066","inReplyTo":"20060801001958.67a071b2.akpm@osdl.org","subject":"Re: git+ssh://master.kernel.org/home/rmk/linux-2.6-arm.git","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-01T08:46:03Z","receivedAt":"2006-08-01T08:46:03Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrew Morton <akpm@osdl.org> writes:\n\n> \n> fyi, a git-fetch of this tree gives:\n>\n> error: refs/heads/devel does not point to a valid commit object!\n> error: refs/heads/devel does not point to a valid commit object!\n>\n> Junio, I'm running git-core-1.4.0-1.fc5 - perhaps more recent gits are\n> better at telling the user if the error is remote or local.  If not: whine ;)\n\nI'd try this out and see what people think.\n\n-- >8 --\n[PATCH] fetch/clone: mark messages from remote side stand out.\n\nWhen dealing with a corrupt or out of sync remote repository,\nthe user often gets error messages like this:\n\n\terror: refs/heads/devel does not point to a valid commit object!\n\nwhich leaves the user wondering if the breakage is on the local\nend or on the remote end.  This is unnecessarily alarming.\n\nThis patch changes the way we display messages received from the\nremote side over the git protocol sideband (i.e. stderr stream\nof the remote process).  It shows them with blue background with\nwhite letters, but this presentation is subject to proposals of\nbetter ways from the list.\n\nThe problem was pointed out by Andrew Morton.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n fetch-clone.c |    3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/fetch-clone.c b/fetch-clone.c\nindex 81d1371..692d9b7 100644\n--- a/fetch-clone.c\n+++ b/fetch-clone.c\n@@ -133,7 +133,10 @@ static pid_t setup_sideband(int sideband\n \t\t\t\tfprintf(stderr, \"\\n\");\n \t\t\t\texit(1);\n \t\t\tcase 2:\n+\t\t\t\t/* color sideband */\n+\t\t\t\tsafe_write(2, \"\\033[44;37;1m\", 10);\n \t\t\t\tsafe_write(2, buf+1, len);\n+\t\t\t\tsafe_write(2, \"\\033[m\", 3);\n \t\t\t\tcontinue;\n \t\t\tcase 1:\n \t\t\t\tsafe_write(fd[1], buf+1, len);\n-- \n1.4.2.rc2.gb9f77\n"},{"id":"24497","messageId":"20060801015250.cfd4f223.akpm@osdl.org","threadId":"5066","inReplyTo":"7v4pww3ktw.fsf@assigned-by-dhcp.cox.net","subject":"Re: git+ssh://master.kernel.org/home/rmk/linux-2.6-arm.git","fromName":"Andrew Morton","fromEmail":"akpm@osdl.org","sentAt":"2006-08-01T08:52:50Z","receivedAt":"2006-08-01T08:52:50Z","isPatch":false,"sender":{"key":"akpm@osdl.org","avatar":null},"body":"On Tue, 01 Aug 2006 01:46:03 -0700\nJunio C Hamano <junkio@cox.net> wrote:\n\n> It shows them with blue background with\n> white letters, but this presentation is subject to proposals of\n> better ways from the list.\n\neek.  If any application on my machine starts emitting funny colours I'll\nimmediately stop everything and go work out how to make it stop ;)\n\nIt would be more traditional to stick \"remote:\" at the beginning of the\nmessage or something.\n"},{"id":"24498","messageId":"7vzmeo25fa.fsf@assigned-by-dhcp.cox.net","threadId":"5066","inReplyTo":"20060801015250.cfd4f223.akpm@osdl.org","subject":"Re: git+ssh://master.kernel.org/home/rmk/linux-2.6-arm.git","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-08-01T09:04:09Z","receivedAt":"2006-08-01T09:04:09Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrew Morton <akpm@osdl.org> writes:\n\n> On Tue, 01 Aug 2006 01:46:03 -0700\n> Junio C Hamano <junkio@cox.net> wrote:\n>\n>> It shows them with blue background with\n>> white letters, but this presentation is subject to proposals of\n>> better ways from the list.\n>\n> eek.  If any application on my machine starts emitting funny colours I'll\n> immediately stop everything and go work out how to make it stop ;)\n>\n> It would be more traditional to stick \"remote:\" at the beginning of the\n> message or something.\n\nHehehe.  I succeeded getting your attention ;-).\n"}]}