{"thread":{"id":"50635","subject":"[PATCH] Makefile: remove the 'hdr-check' target","startedAt":"2019-03-03T22:23:19Z","lastAt":"2019-03-04T14:59:31Z","messageCount":2,"participants":["Ramsay Jones","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"370561","messageId":"c1b1c37c-5476-4dc1-9e9b-b0c7363c5ae4@ramsayjones.plus.com","threadId":"50635","inReplyTo":null,"subject":"[PATCH] Makefile: remove the 'hdr-check' target","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-03-03T22:23:14Z","receivedAt":"2019-03-03T22:23:19Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nThe 'hdr-check' target has proved to be costly for some developers and\nplatforms, depending on the configuration, even when not using this\ntarget. In part, this is due to the use of $(FIND) in the definition\nof the $(LIB_H) variable. This effectively reverts commit ebb7baf02f\n(\"Makefile: add a hdr-check target\", 2018-09-19).\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n Makefile | 12 ------------\n 1 file changed, 12 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex c5240942f2..dd3e38dc1f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1852,7 +1852,6 @@ ifndef V\n \tQUIET_MSGFMT   = @echo '   ' MSGFMT $@;\n \tQUIET_GCOV     = @echo '   ' GCOV $@;\n \tQUIET_SP       = @echo '   ' SP $<;\n-\tQUIET_HDR      = @echo '   ' HDR $<;\n \tQUIET_RC       = @echo '   ' RC $@;\n \tQUIET_SUBDIR0  = +@subdir=\n \tQUIET_SUBDIR1  = ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \\\n@@ -2735,17 +2734,6 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE\n .PHONY: sparse $(SP_OBJ)\n sparse: $(SP_OBJ)\n \n-GEN_HDRS := command-list.h unicode-width.h\n-EXCEPT_HDRS := $(GEN_HDRS) compat% xdiff%\n-CHK_HDRS = $(filter-out $(EXCEPT_HDRS),$(patsubst ./%,%,$(LIB_H)))\n-HCO = $(patsubst %.h,%.hco,$(CHK_HDRS))\n-\n-$(HCO): %.hco: %.h FORCE\n-\t$(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $<\n-\n-.PHONY: hdr-check $(HCO)\n-hdr-check: $(HCO)\n-\n .PHONY: style\n style:\n \tgit clang-format --style file --diff --extensions c,h\n-- \n2.21.0\n"},{"id":"370606","messageId":"nycvar.QRO.7.76.6.1903041558480.45@tvgsbejvaqbjf.bet","threadId":"50635","inReplyTo":"c1b1c37c-5476-4dc1-9e9b-b0c7363c5ae4@ramsayjones.plus.com","subject":"Re: [PATCH] Makefile: remove the 'hdr-check' target","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-03-04T14:59:20Z","receivedAt":"2019-03-04T14:59:31Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Ramsay,\n\nOn Sun, 3 Mar 2019, Ramsay Jones wrote:\n\n> The 'hdr-check' target has proved to be costly for some developers and\n> platforms, depending on the configuration, even when not using this\n> target. In part, this is due to the use of $(FIND) in the definition\n> of the $(LIB_H) variable. This effectively reverts commit ebb7baf02f\n> (\"Makefile: add a hdr-check target\", 2018-09-19).\n\nAs I said elsewhere, I think it would make sense to keep this target, and\nto wire it up to our CI builds.\n\nCiao,\nDscho\n\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>  Makefile | 12 ------------\n>  1 file changed, 12 deletions(-)\n> \n> diff --git a/Makefile b/Makefile\n> index c5240942f2..dd3e38dc1f 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -1852,7 +1852,6 @@ ifndef V\n>  \tQUIET_MSGFMT   = @echo '   ' MSGFMT $@;\n>  \tQUIET_GCOV     = @echo '   ' GCOV $@;\n>  \tQUIET_SP       = @echo '   ' SP $<;\n> -\tQUIET_HDR      = @echo '   ' HDR $<;\n>  \tQUIET_RC       = @echo '   ' RC $@;\n>  \tQUIET_SUBDIR0  = +@subdir=\n>  \tQUIET_SUBDIR1  = ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \\\n> @@ -2735,17 +2734,6 @@ $(SP_OBJ): %.sp: %.c GIT-CFLAGS FORCE\n>  .PHONY: sparse $(SP_OBJ)\n>  sparse: $(SP_OBJ)\n>  \n> -GEN_HDRS := command-list.h unicode-width.h\n> -EXCEPT_HDRS := $(GEN_HDRS) compat% xdiff%\n> -CHK_HDRS = $(filter-out $(EXCEPT_HDRS),$(patsubst ./%,%,$(LIB_H)))\n> -HCO = $(patsubst %.h,%.hco,$(CHK_HDRS))\n> -\n> -$(HCO): %.hco: %.h FORCE\n> -\t$(QUIET_HDR)$(CC) -include git-compat-util.h -I. -o /dev/null -c -xc $<\n> -\n> -.PHONY: hdr-check $(HCO)\n> -hdr-check: $(HCO)\n> -\n>  .PHONY: style\n>  style:\n>  \tgit clang-format --style file --diff --extensions c,h\n> -- \n> 2.21.0\n> \n"}]}