{"thread":{"id":"50593","subject":"[PATCH 1/2] gitk: refresh the colour scheme","startedAt":"2019-02-26T11:05:50Z","lastAt":"2021-02-04T20:35:54Z","messageCount":5,"participants":["Andrej Shadura","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"370217","messageId":"20190226110535.29172-1-andrew.shadura@collabora.co.uk","threadId":"50593","inReplyTo":null,"subject":"[PATCH 1/2] gitk: refresh the colour scheme","fromName":"Andrej Shadura","fromEmail":"andrew.shadura@collabora.co.uk","sentAt":"2019-02-26T11:05:34Z","receivedAt":"2019-02-26T11:05:50Z","isPatch":true,"sender":{"key":"andrew.shadura@collabora.co.uk","avatar":"https://gravatar.com/avatar/b8a2e566757c079bac2d71b7bab3f11eb3472ab8a1ddfc8aaf8e957db8d6249f?d=mp&s=160"},"body":"The colours gitk is currently using are from the basic 16 colour\npalette, and are a bit too intensive to be comfortable or pleasant\nto work with.\n\nAdjust the main colours (commit nodes, remotes, tags and one branch\ncolour) to be slightly softer.\n\nSigned-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>\n---\n gitk-git/gitk | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex a14d7a16b2..5766754ab6 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -12302,7 +12302,7 @@ if {[tk windowingsystem] eq \"aqua\"} {\n     set extdifftool \"meld\"\n }\n \n-set colors {\"#00ff00\" red blue magenta darkgrey brown orange}\n+set colors {\"#00ff00\" red blue #f282f2 darkgrey brown orange}\n if {[tk windowingsystem] eq \"win32\"} {\n     set uicolor SystemButtonFace\n     set uifgcolor SystemButtonText\n@@ -12325,11 +12325,11 @@ set ignorespace 0\n set worddiff \"\"\n set markbgcolor \"#e0e0ff\"\n \n-set headbgcolor \"#00ff00\"\n+set headbgcolor #98ff5e\n set headfgcolor black\n set headoutlinecolor black\n-set remotebgcolor #ffddaa\n-set tagbgcolor yellow\n+set remotebgcolor #bae2ff\n+set tagbgcolor #f3fb57\n set tagfgcolor black\n set tagoutlinecolor black\n set reflinecolor black\n@@ -12338,10 +12338,10 @@ set filesepfgcolor black\n set linehoverbgcolor #ffff80\n set linehoverfgcolor black\n set linehoveroutlinecolor black\n-set mainheadcirclecolor yellow\n+set mainheadcirclecolor #ffeb74\n set workingfilescirclecolor red\n set indexcirclecolor \"#00ff00\"\n-set circlecolors {white blue gray blue blue}\n+set circlecolors {white #08b5ed gray blue blue}\n set linkfgcolor blue\n set circleoutlinecolor $fgcolor\n set foundbgcolor yellow\n-- \n2.19.1\n\n"},{"id":"370218","messageId":"20190226110535.29172-2-andrew.shadura@collabora.co.uk","threadId":"50593","inReplyTo":"20190226110535.29172-1-andrew.shadura@collabora.co.uk","subject":"[PATCH 2/2] gitk: disable autoselect by default","fromName":"Andrej Shadura","fromEmail":"andrew.shadura@collabora.co.uk","sentAt":"2019-02-26T11:05:35Z","receivedAt":"2019-02-26T11:05:54Z","isPatch":true,"sender":{"key":"andrew.shadura@collabora.co.uk","avatar":"https://gravatar.com/avatar/b8a2e566757c079bac2d71b7bab3f11eb3472ab8a1ddfc8aaf8e957db8d6249f?d=mp&s=160"},"body":"Auto-selection of the commit hash overwrites whatever content was in the\nselection clipboard, and also pollutes the clipboard history if the user\nis using a clipboard manager. Most users probably want this off by\ndefault.\n\nSigned-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>\n---\n gitk-git/gitk | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 5766754ab6..583e505709 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -12291,7 +12291,7 @@ set maxlinelen 200\n set showlocalchanges 1\n set limitdiffs 1\n set datetimeformat \"%Y-%m-%d %H:%M:%S\"\n-set autoselect 1\n+set autoselect 0\n set autosellen 40\n set perfile_attrs 0\n set want_ttk 1\n-- \n2.19.1\n\n"},{"id":"370486","messageId":"20190302230228.GA26937@blackberry","threadId":"50593","inReplyTo":"20190226110535.29172-1-andrew.shadura@collabora.co.uk","subject":"Re: [PATCH 1/2] gitk: refresh the colour scheme","fromName":"Paul Mackerras","fromEmail":"paulus@ozlabs.org","sentAt":"2019-03-02T23:02:28Z","receivedAt":"2019-03-03T01:21:46Z","isPatch":true,"sender":{"key":"paulus@ozlabs.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:\n> The colours gitk is currently using are from the basic 16 colour\n> palette, and are a bit too intensive to be comfortable or pleasant\n> to work with.\n> \n> Adjust the main colours (commit nodes, remotes, tags and one branch\n> colour) to be slightly softer.\n> \n> Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>\n\nThanks for the patch, but I disagree.  I do like the change you made\nto the tag colours, but the blue you have for the commit node circles\nis pretty blah.  That needs a more definite colour.\n\nAlso, the \"too intensive to be comfortable or pleasant\" in the commit\nmessage reflect a personal preference, and the way it is put seems to\nme to be too intensive to be comfortable or pleasant.\n\nPaul.\n"},{"id":"370586","messageId":"7e696805-4b80-cd26-aaaa-261a05ead964@collabora.co.uk","threadId":"50593","inReplyTo":"20190302230228.GA26937@blackberry","subject":"Re: [PATCH 1/2] gitk: refresh the colour scheme","fromName":"Andrej Shadura","fromEmail":"andrew.shadura@collabora.co.uk","sentAt":"2019-03-04T09:35:56Z","receivedAt":"2019-03-04T09:36:03Z","isPatch":true,"sender":{"key":"andrew.shadura@collabora.co.uk","avatar":"https://gravatar.com/avatar/b8a2e566757c079bac2d71b7bab3f11eb3472ab8a1ddfc8aaf8e957db8d6249f?d=mp&s=160"},"body":"On 03/03/2019 00:02, Paul Mackerras wrote:\n> On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:\n>> The colours gitk is currently using are from the basic 16 colour\n>> palette, and are a bit too intensive to be comfortable or pleasant\n>> to work with.\n>>\n>> Adjust the main colours (commit nodes, remotes, tags and one branch\n>> colour) to be slightly softer.\n>>\n>> Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>\n> \n> Thanks for the patch, but I disagree.  I do like the change you made\n> to the tag colours, but the blue you have for the commit node circles\n> is pretty blah.  That needs a more definite colour.\n\nI see.\n\n1) Would you accept the patch without that change?\n2) What colour would you prefer (except the already existing one)?\n\n> Also, the \"too intensive to be comfortable or pleasant\" in the commit\n> message reflect a personal preference, and the way it is put seems to\n> me to be too intensive to be comfortable or pleasant.\n\nHmm, sorry if that came across not the way I intended. I was trying to\nformulate the thought in a way that would not be emotional or\nsubjective, but I guess the end result was exactly opposite.\n\n-- \nCheers,\n  Andrej\n"},{"id":"416192","messageId":"9e3cef09-b98a-cd8a-ecba-fcb059137088@collabora.co.uk","threadId":"50593","inReplyTo":"7e696805-4b80-cd26-aaaa-261a05ead964@collabora.co.uk","subject":"Re: [PATCH 1/2] gitk: refresh the colour scheme","fromName":"Andrej Shadura","fromEmail":"andrew.shadura@collabora.co.uk","sentAt":"2021-02-04T20:34:57Z","receivedAt":"2021-02-04T20:35:54Z","isPatch":true,"sender":{"key":"andrew.shadura@collabora.co.uk","avatar":"https://gravatar.com/avatar/b8a2e566757c079bac2d71b7bab3f11eb3472ab8a1ddfc8aaf8e957db8d6249f?d=mp&s=160"},"body":"Hi,\n\nOn 04/03/2019 10:35, Andrej Shadura wrote:\n> On 03/03/2019 00:02, Paul Mackerras wrote:\n>> On Tue, Feb 26, 2019 at 12:05:34PM +0100, Andrej Shadura wrote:\n>>> The colours gitk is currently using are from the basic 16 colour\n>>> palette, and are a bit too intensive to be comfortable or pleasant\n>>> to work with.\n>>>\n>>> Adjust the main colours (commit nodes, remotes, tags and one branch\n>>> colour) to be slightly softer.\n>>>\n>>> Signed-off-by: Andrej Shadura <andrew.shadura@collabora.co.uk>\n>>\n>> Thanks for the patch, but I disagree.  I do like the change you made\n>> to the tag colours, but the blue you have for the commit node circles\n>> is pretty blah.  That needs a more definite colour.\n> \n> I see.\n> \n> 1) Would you accept the patch without that change?\n> 2) What colour would you prefer (except the already existing one)?\n\n>> Also, the \"too intensive to be comfortable or pleasant\" in the commit\n>> message reflect a personal preference, and the way it is put seems to\n>> me to be too intensive to be comfortable or pleasant.\n> \n> Hmm, sorry if that came across not the way I intended. I was trying to\n> formulate the thought in a way that would not be emotional or\n> subjective, but I guess the end result was exactly opposite.\n\nI’d be happy to resubmit the patch adjusted to your preference, only if\nyou gave me some more ideas on how you’d like to see it.\n\nThanks in advance.\n\n-- \nCheers,\n  Andrej\n"}]}