{"thread":{"id":"50587","subject":"[PATCH 0/1] Drop last MakeMaker reference","startedAt":"2019-02-25T19:27:15Z","lastAt":"2019-03-11T20:24:44Z","messageCount":9,"participants":["Johannes Schindelin via GitGitGadget","Jonathan Nieder","Johannes Schindelin","Junio C Hamano","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"370125","messageId":"pull.146.git.gitgitgadget@gmail.com","threadId":"50587","inReplyTo":null,"subject":"[PATCH 0/1] Drop last MakeMaker reference","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-02-25T19:27:11Z","receivedAt":"2019-02-25T19:27:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Back when we stopped using MakeMaker, we forgot one reference...\n\nJohannes Schindelin (1):\n mingw: drop MakeMaker reference\n\n config.mak.uname | 1 -\n 1 file changed, 1 deletion(-)\n\n\nbase-commit: 8104ec994ea3849a968b4667d072fedd1e688642\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/146\n-- \ngitgitgadget\n"},{"id":"370126","messageId":"061093e2f000829a560e7bcce1dc86cb6babbca5.1551122830.git.gitgitgadget@gmail.com","threadId":"50587","inReplyTo":"pull.146.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] mingw: drop MakeMaker reference","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-02-25T19:27:11Z","receivedAt":"2019-02-25T19:27:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nIn 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make\nrules, 2017-12-10), Git stopped using MakeMaker. Therefore, that\ndefinition in the MINGW-specific section became useless.\n\nSigned-off-by: Johannes Schindelin \n---\n config.mak.uname | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex b37fa8424c..b88d8451fe 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -529,7 +529,6 @@ ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_STRTOUMAX = YesPlease\n \tNO_MKDTEMP = YesPlease\n \tNO_SVN_TESTS = YesPlease\n-\tNO_PERL_MAKEMAKER = YesPlease\n \tRUNTIME_PREFIX = YesPlease\n \tHAVE_WPGMPTR = YesWeDo\n \tNO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease\n-- \ngitgitgadget\n"},{"id":"370127","messageId":"20190225200225.GA16965@google.com","threadId":"50587","inReplyTo":"061093e2f000829a560e7bcce1dc86cb6babbca5.1551122830.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] mingw: drop MakeMaker reference","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2019-02-25T20:02:25Z","receivedAt":"2019-02-25T20:02:30Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Johannes Schindelin via GitGitGadget wrote:\n\n> From: Johannes Schindelin \n>\n> In 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make\n> rules, 2017-12-10), Git stopped using MakeMaker. Therefore, that\n> definition in the MINGW-specific section became useless.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> config.mak.uname | 1 -\n> 1 file changed, 1 deletion(-)\n\nYay!\n\nReviewed-by: Jonathan Nieder \n\nIs there a way to automate checking for make variables that are set\nbut never used?\n\nThanks,\nJonathan\n"},{"id":"370154","messageId":"nycvar.QRO.7.76.6.1902252304180.41@tvgsbejvaqbjf.bet","threadId":"50587","inReplyTo":"20190225200225.GA16965@google.com","subject":"Re: [PATCH 1/1] mingw: drop MakeMaker reference","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-25T22:07:03Z","receivedAt":"2019-02-25T22:07:51Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Jonathan,\n\nOn Mon, 25 Feb 2019, Jonathan Nieder wrote:\n\n> Johannes Schindelin via GitGitGadget wrote:\n> \n> > From: Johannes Schindelin \n> >\n> > In 20d2a30f8ffe (Makefile: replace perl/Makefile.PL with simple make\n> > rules, 2017-12-10), Git stopped using MakeMaker. Therefore, that\n> > definition in the MINGW-specific section became useless.\n> >\n> > Signed-off-by: Johannes Schindelin \n> > ---\n> > config.mak.uname | 1 -\n> > 1 file changed, 1 deletion(-)\n> \n> Yay!\n> \n> Reviewed-by: Jonathan Nieder \n\nThanks!\n\n> Is there a way to automate checking for make variables that are set\n> but never used?\n\nNo, not that I know of...\n\nThe biggest problem is that we only add documentation to the beginning of\nthe Makefile by convention, and there is not really any consistent way to\nparse that documentation to figure out what build variables are handled\ncurrently.\n\nCiao,\nDscho\n"},{"id":"370484","messageId":"xmqqfts469h5.fsf@gitster-ct.c.googlers.com","threadId":"50587","inReplyTo":"pull.146.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/1] Drop last MakeMaker reference","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-03-03T01:19:02Z","receivedAt":"2019-03-03T01:19:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> Back when we stopped using MakeMaker, we forgot one reference...\n>\n> Johannes Schindelin (1):\n> mingw: drop MakeMaker reference\n>\n> config.mak.uname | 1 -\n> 1 file changed, 1 deletion(-)\n>\n>\n> base-commit: 8104ec994ea3849a968b4667d072fedd1e688642\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/146\n\nGood ;-)\nThanks.\n"},{"id":"370895","messageId":"nycvar.QRO.7.76.6.1903071109020.41@tvgsbejvaqbjf.bet","threadId":"50587","inReplyTo":"xmqqfts469h5.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 0/1] Drop last MakeMaker reference","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-03-07T10:10:24Z","receivedAt":"2019-03-07T10:10:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Sun, 3 Mar 2019, Junio C Hamano wrote:\n\n> \"Johannes Schindelin via GitGitGadget\" \n> writes:\n> \n> > Back when we stopped using MakeMaker, we forgot one reference...\n> >\n> > Johannes Schindelin (1):\n> > mingw: drop MakeMaker reference\n> >\n> > config.mak.uname | 1 -\n> > 1 file changed, 1 deletion(-)\n> >\n> >\n> > base-commit: 8104ec994ea3849a968b4667d072fedd1e688642\n> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1\n> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1\n> > Pull-Request: https://github.com/gitgitgadget/git/pull/146\n> \n> Good ;-)\n> Thanks.\n\nGentle reminder that this has not made it into `pu` yet...\n\nThanks,\nDscho\n"},{"id":"370937","messageId":"xmqq1s3ikurh.fsf@gitster-ct.c.googlers.com","threadId":"50587","inReplyTo":"nycvar.QRO.7.76.6.1903071109020.41@tvgsbejvaqbjf.bet","subject":"Re: [PATCH 0/1] Drop last MakeMaker reference","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-03-08T01:41:22Z","receivedAt":"2019-03-08T01:41:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> Hi Junio,\n>\n> On Sun, 3 Mar 2019, Junio C Hamano wrote:\n>\n>> \"Johannes Schindelin via GitGitGadget\" \n>> writes:\n>> \n>> > Back when we stopped using MakeMaker, we forgot one reference...\n>> >\n>> > Johannes Schindelin (1):\n>> > mingw: drop MakeMaker reference\n>> >\n>> > config.mak.uname | 1 -\n>> > 1 file changed, 1 deletion(-)\n>> >\n>> >\n>> > base-commit: 8104ec994ea3849a968b4667d072fedd1e688642\n>> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1\n>> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1\n>> > Pull-Request: https://github.com/gitgitgadget/git/pull/146\n>> \n>> Good ;-)\n>> Thanks.\n>\n> Gentle reminder that this has not made it into `pu` yet...\n\nThanks.\n\nI'll try to make it a habit not to respond to 0/1 (but instead to\n1/1) as it is quite inefficient to get to 1/1 from 0/1 at least for\nme X-<.\n\nOr perhaps GGG can learn to avoid 0/1 for a single-patch topic ;-)\n\nThanks anyway. Will try to apply directly on top of master.\n"},{"id":"370998","messageId":"nycvar.QRO.7.76.6.1903081718330.41@tvgsbejvaqbjf.bet","threadId":"50587","inReplyTo":"xmqq1s3ikurh.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 0/1] Drop last MakeMaker reference","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-03-08T16:27:36Z","receivedAt":"2019-03-08T16:27:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Fri, 8 Mar 2019, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > On Sun, 3 Mar 2019, Junio C Hamano wrote:\n> >\n> >> \"Johannes Schindelin via GitGitGadget\" \n> >> writes:\n> >> \n> >> > Back when we stopped using MakeMaker, we forgot one reference...\n> >> >\n> >> > Johannes Schindelin (1):\n> >> > mingw: drop MakeMaker reference\n> >> >\n> >> > config.mak.uname | 1 -\n> >> > 1 file changed, 1 deletion(-)\n> >> >\n> >> >\n> >> > base-commit: 8104ec994ea3849a968b4667d072fedd1e688642\n> >> > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-146%2Fdscho%2Fno-perl-makemaker-v1\n> >> > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-146/dscho/no-perl-makemaker-v1\n> >> > Pull-Request: https://github.com/gitgitgadget/git/pull/146\n> >> \n> >> Good ;-)\n> >> Thanks.\n> >\n> > Gentle reminder that this has not made it into `pu` yet...\n> \n> Thanks.\n> \n> I'll try to make it a habit not to respond to 0/1 (but instead to\n> 1/1) as it is quite inefficient to get to 1/1 from 0/1 at least for\n> me X-<.\n\nHehe. I do have something for you there:\n\nhttps://github.com/git-for-windows/build-extra/blob/master/apply-from-public-inbox.sh\n\n-- snip --\n\n> Or perhaps GGG can learn to avoid 0/1 for a single-patch topic ;-)\n\nIt is easier, and more consistent, to have a cover letter even then, for\nthings like the broader explanation of the context, the changes since the\nprevious iteration, and the range-diff (which would make v2, v3, v4, etc\nutterly unreadable from my point of view if they were integrated into the\nsingle patches, as I used to do with interdiffs).\n\n> Thanks anyway. Will try to apply directly on top of master.\n\nThank you!\n\nWhile we're talking about \"directly on top of master\"... *after* it got\nsome review, I would love to ask for the same favor for\nhttps://public-inbox.org/git/pull.160.git.gitgitgadget@gmail.com\n\nOn the other hand, it is an old bug, I know, and it will break all CI\nbuilds for branches that are based off of older commits, anyway. I guess\nwe'll need some sort of horrible hack in the git-sdk-64-minimal thing, to\nallow for patching this on the CI side, without adding commits to all of\nthose branches. :-(\n\nSo: I made up my mind, and that MSYS2 runtime v3.x patch does not need to\nbe fast-tracked; it would not fix all the CI builds...\n\nCiao,\nDscho\n"},{"id":"371190","messageId":"20190311202441.GB18263@sigill.intra.peff.net","threadId":"50587","inReplyTo":"nycvar.QRO.7.76.6.1903081718330.41@tvgsbejvaqbjf.bet","subject":"Re: [PATCH 0/1] Drop last MakeMaker reference","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-03-11T20:24:41Z","receivedAt":"2019-03-11T20:24:44Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Mar 08, 2019 at 05:27:36PM +0100, Johannes Schindelin wrote:\n\n> > Or perhaps GGG can learn to avoid 0/1 for a single-patch topic ;-)\n> \n> It is easier, and more consistent, to have a cover letter even then, for\n> things like the broader explanation of the context, the changes since the\n> previous iteration, and the range-diff (which would make v2, v3, v4, etc\n> utterly unreadable from my point of view if they were integrated into the\n> single patches, as I used to do with interdiffs).\n\nJust my two cents:\n\nAs a reviewer, I generally prefer not to see a separate cover letter for\na single patch. At least for the first version (I agree it gets unwieldy\nshowing a range-diff after the \"---\" for subsequent versions, unless it\nhappens to be pretty short).\n\nMy reasoning is that I've noticed that many of the GGG-sent patches\noften end up duplicating quite a bit of content between the cover letter\nand the commit message of the patch (or worse, putting things only in\nthe cover letter that really could go into the commit message). That\ndoubles the time I spend reading and understanding the patch's rationale\n(and I'm speaking subjectively here, of course; I didn't measure it).\n\nI don't think it's an _inherent_ problem with a separate cover letter.\nBut something about the workflow causes people to write up over-long\ncover letters. Which presumably is the fact that they're presented with\na PR textbox to write the rationale separately from when they wrote the\ncommit message. So they err on the side of repeating themselves, and\nnever see the two pieces \"together\" (like the reader will), which makes\nthe redundancy more obvious.\n\nI'd say 99% of the time a single-patch doesn't need any cover letter\nmaterial at all. And even a multi-patch series really just needs a tl;dr\nof the problem and a sketch of the solution. In both cases, the commit\nmessages should carry the meat.\n\n(That's all specific to our project, of course; I know many projects\ndon't care about commit messages at all and expect PR descriptions to be\nthe first-class explanations).\n\n-Peff\n"}]}