{"thread":{"id":"50564","subject":"[PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","startedAt":"2019-02-22T15:58:47Z","lastAt":"2019-03-03T01:22:00Z","messageCount":8,"participants":["Olga Telezhnaya","Eric Sunshine","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":20},"messages":[{"id":"369933","messageId":"CAL21BmnVkKtYWa1cRL1EJAwtchGcVUzhu0136AuV8uXAi5Kuew@mail.gmail.com","threadId":"50564","inReplyTo":null,"subject":"[PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Olga Telezhnaya","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2019-02-22T15:50:06Z","receivedAt":"2019-02-22T15:58:47Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"Hi everyone,\nIt was a long way for me, I got older (by 1 year) and smarter\n(hopefully), and maybe I will finish my Outreachy Internship task for\nnow. (I am doing it just for one year and a half, that's OK)\n\nIf serious:\nIn this patch we remove cat-file formatting logic and reuse ref-filter\nlogic there. As a positive side effect, cat-file now has many new\nformatting tokens (all from ref-filter formatting), including deref\n(like %(*objectsize:disk)). I have already tried to do this task one\nyear ago, and it was bad attempt. I feel that today's patch is much\nbetter.\n\nIn my opinion, it still has some issues. I mentioned all of them in\nTODOs in comments. All of them considered to be separate tasks for\nother patches. Some of them sound easy and could be great tasks for\nnewbies.\n\nI also have a question about site https://git-scm.com/docs/\nI thought it is updated automatically based on Documentation folder in\nthe project, but it is not true. I edited docs for for-each-ref in\nDecember, I still see my patch in master, but for-each-ref docs in\ngit-csm is outdated. Is it OK?\n\nThank you!\nOlga\n"},{"id":"369955","messageId":"CAPig+cSDtU1pbuzCvNPf+nmwS5LLKPm5RSY7wYxWg=s1e53enw@mail.gmail.com","threadId":"50564","inReplyTo":"CAL21BmnVkKtYWa1cRL1EJAwtchGcVUzhu0136AuV8uXAi5Kuew@mail.gmail.com","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2019-02-22T16:09:34Z","receivedAt":"2019-02-22T16:09:46Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Fri, Feb 22, 2019 at 10:58 AM Olga Telezhnaya\n wrote:\n> I also have a question about site https://git-scm.com/docs/\n> I thought it is updated automatically based on Documentation folder in\n> the project, but it is not true. I edited docs for for-each-ref in\n> December, I still see my patch in master, but for-each-ref docs in\n> git-csm is outdated. Is it OK?\n\nIf you look at https://git-scm.com/docs/git-for-each-ref, you'll find\na pop-up control at the top of the page which allows you to select\ndocumentation for a particular release of Git (say, 2.19.1). Your\nchange to git-for-each-ref.txt may be in \"master\" but is not yet in\nany official final release. It will be in 2.21.0, but that release is\nstill in the RC stage, thus doesn't appear at\nhttps://git-scm.com/docs/git-for-each-ref.\n"},{"id":"369956","messageId":"CAL21Bmmwr=F+-sTNFcHxk3kdCE3ahV2eQzTNCDteb=7vZVB2aw@mail.gmail.com","threadId":"50564","inReplyTo":"CAPig+cSDtU1pbuzCvNPf+nmwS5LLKPm5RSY7wYxWg=s1e53enw@mail.gmail.com","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Olga Telezhnaya","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2019-02-22T16:19:23Z","receivedAt":"2019-02-22T16:28:02Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"пт, 22 февр. 2019 г. в 19:09, Eric Sunshine :\n>\n> On Fri, Feb 22, 2019 at 10:58 AM Olga Telezhnaya\n> wrote:\n> > I also have a question about site https://git-scm.com/docs/\n> > I thought it is updated automatically based on Documentation folder in\n> > the project, but it is not true. I edited docs for for-each-ref in\n> > December, I still see my patch in master, but for-each-ref docs in\n> > git-csm is outdated. Is it OK?\n>\n> If you look at https://git-scm.com/docs/git-for-each-ref, you'll find\n> a pop-up control at the top of the page which allows you to select\n> documentation for a particular release of Git (say, 2.19.1). Your\n> change to git-for-each-ref.txt may be in \"master\" but is not yet in\n> any official final release. It will be in 2.21.0, but that release is\n> still in the RC stage, thus doesn't appear at\n> https://git-scm.com/docs/git-for-each-ref.\n\nOh, thank you, I missed that.\n"},{"id":"370388","messageId":"20190228214112.GK12723@sigill.intra.peff.net","threadId":"50564","inReplyTo":"CAL21BmnVkKtYWa1cRL1EJAwtchGcVUzhu0136AuV8uXAi5Kuew@mail.gmail.com","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-02-28T21:41:12Z","receivedAt":"2019-02-28T21:41:16Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Feb 22, 2019 at 06:50:06PM +0300, Olga Telezhnaya wrote:\n\n> It was a long way for me, I got older (by 1 year) and smarter\n> (hopefully), and maybe I will finish my Outreachy Internship task for\n> now. (I am doing it just for one year and a half, that's OK)\n\nWelcome back!\n\nSorry to be a bit slow on the review. I've read through and commented on\npatch 10. Some of my comments were \"I'll have to see how this plays out\nlater in the series\", so you may want to hold off on responding until I\nread the rest. :)\n\n> If serious:\n> In this patch we remove cat-file formatting logic and reuse ref-filter\n> logic there. As a positive side effect, cat-file now has many new\n> formatting tokens (all from ref-filter formatting), including deref\n> (like %(*objectsize:disk)). I have already tried to do this task one\n> year ago, and it was bad attempt. I feel that today's patch is much\n> better.\n\nI'm still concerned that this is going to regress the performance of\ncat-file noticeably without some big cleanups in ref-filter. Here are\ntimings on linux.git before and after your patches:\n\n [before]\n $ time git cat-file --unordered --batch-all-objects --batch-check >/dev/null\n real\t0m16.602s\n user\t0m15.545s\n sys\t0m0.495s\n\n [after]\n $ time git cat-file --unordered --batch-all-objects --batch-check >/dev/null\n real\t0m27.301s\n user\t0m24.549s\n sys\t0m2.752s\n\nI don't think that's anything particularly wrong with your patches. It's\nthe existing strategy of ref-filter (in particular how it is very eager\nto allocate lots of separate strings). And it may be too early to switch\ncat-file over to it.\n\n> I also have a question about site https://git-scm.com/docs/\n> I thought it is updated automatically based on Documentation folder in\n> the project, but it is not true. I edited docs for for-each-ref in\n> December, I still see my patch in master, but for-each-ref docs in\n> git-csm is outdated. Is it OK?\n\nYeah, as Eric noted, we only build docs for the tagged releases. In\ntheory it would be easy to just build the tip of master nightly, but the\ndata model for the site would need quite a bit of adjustment.\n\n-Peff\n"},{"id":"370389","messageId":"20190228214314.GL12723@sigill.intra.peff.net","threadId":"50564","inReplyTo":"CAL21BmnVkKtYWa1cRL1EJAwtchGcVUzhu0136AuV8uXAi5Kuew@mail.gmail.com","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-02-28T21:43:14Z","receivedAt":"2019-02-28T21:43:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Feb 22, 2019 at 06:50:06PM +0300, Olga Telezhnaya wrote:\n\n> In my opinion, it still has some issues. I mentioned all of them in\n> TODOs in comments. All of them considered to be separate tasks for\n> other patches. Some of them sound easy and could be great tasks for\n> newbies.\n\nOne other thing I forgot to mention: your patches ended up on the list\nin jumbled order. How do you send them? Usually `send-email` would add 1\nsecond to the timestamp of each, so that threading mail readers sort\nthem as you'd expect (even if they arrive out of order due to the\nvagaries of SMTP servers).\n\n-Peff\n"},{"id":"370406","messageId":"CAL21BmkPL1RDiz6v+=etJhFn3kmTMJKpnQa-qFFR224wFo8ubw@mail.gmail.com","threadId":"50564","inReplyTo":"20190228214112.GK12723@sigill.intra.peff.net","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Olga Telezhnaya","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2019-03-01T06:16:20Z","receivedAt":"2019-03-01T06:16:35Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"пт, 1 мар. 2019 г. в 00:41, Jeff King :\n>\n> On Fri, Feb 22, 2019 at 06:50:06PM +0300, Olga Telezhnaya wrote:\n>\n> > It was a long way for me, I got older (by 1 year) and smarter\n> > (hopefully), and maybe I will finish my Outreachy Internship task for\n> > now. (I am doing it just for one year and a half, that's OK)\n>\n> Welcome back!\n>\n> Sorry to be a bit slow on the review. I've read through and commented on\n> patch 10. Some of my comments were \"I'll have to see how this plays out\n> later in the series\", so you may want to hold off on responding until I\n> read the rest. :)\n>\n> > If serious:\n> > In this patch we remove cat-file formatting logic and reuse ref-filter\n> > logic there. As a positive side effect, cat-file now has many new\n> > formatting tokens (all from ref-filter formatting), including deref\n> > (like %(*objectsize:disk)). I have already tried to do this task one\n> > year ago, and it was bad attempt. I feel that today's patch is much\n> > better.\n>\n> I'm still concerned that this is going to regress the performance of\n> cat-file noticeably without some big cleanups in ref-filter. Here are\n> timings on linux.git before and after your patches:\n>\n> [before]\n> $ time git cat-file --unordered --batch-all-objects --batch-check >/dev/null\n> real 0m16.602s\n> user 0m15.545s\n> sys 0m0.495s\n>\n> [after]\n> $ time git cat-file --unordered --batch-all-objects --batch-check >/dev/null\n> real 0m27.301s\n> user 0m24.549s\n> sys 0m2.752s\n>\n> I don't think that's anything particularly wrong with your patches. It's\n> the existing strategy of ref-filter (in particular how it is very eager\n> to allocate lots of separate strings). And it may be too early to switch\n> cat-file over to it.\n\nI have a guess that we need to add batch printing argument to our\ngeneral printing functions, that could make my version faster.\n\n>\n> > I also have a question about site https://git-scm.com/docs/\n> > I thought it is updated automatically based on Documentation folder in\n> > the project, but it is not true. I edited docs for for-each-ref in\n> > December, I still see my patch in master, but for-each-ref docs in\n> > git-csm is outdated. Is it OK?\n>\n> Yeah, as Eric noted, we only build docs for the tagged releases. In\n> theory it would be easy to just build the tip of master nightly, but the\n> data model for the site would need quite a bit of adjustment.\n>\n> -Peff\n"},{"id":"370407","messageId":"CAL21Bm=_Ybj+HPU7dq7vpQkev31krapXe=HVN3zXKtY_gU2yJA@mail.gmail.com","threadId":"50564","inReplyTo":"20190228214314.GL12723@sigill.intra.peff.net","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Olga Telezhnaya","fromEmail":"olyatelezhnaya@gmail.com","sentAt":"2019-03-01T06:17:45Z","receivedAt":"2019-03-01T06:17:59Z","isPatch":true,"sender":{"key":"olyatelezhnaya@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11246099?v=4"},"body":"пт, 1 мар. 2019 г. в 00:43, Jeff King :\n>\n> On Fri, Feb 22, 2019 at 06:50:06PM +0300, Olga Telezhnaya wrote:\n>\n> > In my opinion, it still has some issues. I mentioned all of them in\n> > TODOs in comments. All of them considered to be separate tasks for\n> > other patches. Some of them sound easy and could be great tasks for\n> > newbies.\n>\n> One other thing I forgot to mention: your patches ended up on the list\n> in jumbled order. How do you send them? Usually `send-email` would add 1\n> second to the timestamp of each, so that threading mail readers sort\n> them as you'd expect (even if they arrive out of order due to the\n> vagaries of SMTP servers).\n\nOh, that's one more bug in submitgit, I guess. I will not use it\nanymore, OK, it's time to change the habits.\n\n>\n> -Peff\n"},{"id":"370488","messageId":"xmqqtvgk4urv.fsf@gitster-ct.c.googlers.com","threadId":"50564","inReplyTo":"20190228214314.GL12723@sigill.intra.peff.net","subject":"Re: [PATCH RFC 0/20] cat-file: start using formatting logic from ref-filter","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-03-03T01:21:56Z","receivedAt":"2019-03-03T01:22:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Fri, Feb 22, 2019 at 06:50:06PM +0300, Olga Telezhnaya wrote:\n>\n>> In my opinion, it still has some issues. I mentioned all of them in\n>> TODOs in comments. All of them considered to be separate tasks for\n>> other patches. Some of them sound easy and could be great tasks for\n>> newbies.\n>\n> One other thing I forgot to mention: your patches ended up on the list\n> in jumbled order. How do you send them? Usually `send-email` would add 1\n> second to the timestamp of each, so that threading mail readers sort\n> them as you'd expect (even if they arrive out of order due to the\n> vagaries of SMTP servers).\n\nYes, the 1 second increment has served us so well in the entire life\nof this project, and I am finding a bit irritating that we seem to\nbe seeing topics that are shown in jumbled order more often. I'd love\nto see why and get them fixed at the source eventually.\n\n"}]}