{"thread":{"id":"50503","subject":"[PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","startedAt":"2019-02-14T06:35:19Z","lastAt":"2019-02-14T21:20:43Z","messageCount":6,"participants":["Todd Zullinger","Jeff King","Jonathan Tan","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"369295","messageId":"20190214063513.32041-1-tmz@pobox.com","threadId":"50503","inReplyTo":null,"subject":"[PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2019-02-14T06:35:13Z","receivedAt":"2019-02-14T06:35:19Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\nGIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\nfrom Apache when the variable is unset, as we do for GIT_VALGRIND* and\nGIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n--valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\nApache\", 2015-03-13), respectively.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\nI missed this with rc0, but poking through build logs I noticed a number\nof 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\nwarnings.\n\nI think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\nGIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\nthings like GNUPGHOME.  But I could easily be wrong about that.\n\n t/lib-httpd.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/t/lib-httpd.sh b/t/lib-httpd.sh\nindex 216281eabc..0dfb48c2f6 100644\n--- a/t/lib-httpd.sh\n+++ b/t/lib-httpd.sh\n@@ -91,6 +91,7 @@ HTTPD_DOCUMENT_ROOT_PATH=$HTTPD_ROOT_PATH/www\n # hack to suppress apache PassEnv warnings\n GIT_VALGRIND=$GIT_VALGRIND; export GIT_VALGRIND\n GIT_VALGRIND_OPTIONS=$GIT_VALGRIND_OPTIONS; export GIT_VALGRIND_OPTIONS\n+GIT_TEST_SIDEBAND_ALL=$GIT_TEST_SIDEBAND_ALL; export GIT_TEST_SIDEBAND_ALL\n GIT_TRACE=$GIT_TRACE; export GIT_TRACE\n \n if ! test -x \"$LIB_HTTPD_PATH\"\n-- \n2.21.0.rc1\n\n"},{"id":"369297","messageId":"20190214065226.GA22932@sigill.intra.peff.net","threadId":"50503","inReplyTo":"20190214063513.32041-1-tmz@pobox.com","subject":"Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2019-02-14T06:52:27Z","receivedAt":"2019-02-14T06:52:30Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, Feb 14, 2019 at 01:35:13AM -0500, Todd Zullinger wrote:\n\n> 07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\n> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\n> from Apache when the variable is unset, as we do for GIT_VALGRIND* and\n> GIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n> --valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\n> Apache\", 2015-03-13), respectively.\n> \n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n> I missed this with rc0, but poking through build logs I noticed a number\n> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\n> warnings.\n> \n> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\n> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\n> things like GNUPGHOME.  But I could easily be wrong about that.\n\nYeah, I think this is the right place to put it (and this approach is\nthe right thing to do).\n\n> diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh\n> index 216281eabc..0dfb48c2f6 100644\n> --- a/t/lib-httpd.sh\n> +++ b/t/lib-httpd.sh\n> @@ -91,6 +91,7 @@ HTTPD_DOCUMENT_ROOT_PATH=$HTTPD_ROOT_PATH/www\n>  # hack to suppress apache PassEnv warnings\n>  GIT_VALGRIND=$GIT_VALGRIND; export GIT_VALGRIND\n>  GIT_VALGRIND_OPTIONS=$GIT_VALGRIND_OPTIONS; export GIT_VALGRIND_OPTIONS\n> +GIT_TEST_SIDEBAND_ALL=$GIT_TEST_SIDEBAND_ALL; export GIT_TEST_SIDEBAND_ALL\n>  GIT_TRACE=$GIT_TRACE; export GIT_TRACE\n\nI applaud your attempt to alphabetize, but the existing list is already\nout of order. ;) I don't think it really matters much either way,\nthough.\n\n-Peff\n"},{"id":"369299","messageId":"20190214070014.GF16125@zaya.teonanacatl.net","threadId":"50503","inReplyTo":"20190214065226.GA22932@sigill.intra.peff.net","subject":"Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2019-02-14T07:00:14Z","receivedAt":"2019-02-14T07:00:27Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Jeff King wrote:\n> On Thu, Feb 14, 2019 at 01:35:13AM -0500, Todd Zullinger wrote:\n> \n>> 07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\n>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\n>> from Apache when the variable is unset, as we do for GIT_VALGRIND* and\n>> GIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n>> --valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\n>> Apache\", 2015-03-13), respectively.\n>> \n>> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n>> ---\n>> I missed this with rc0, but poking through build logs I noticed a number\n>> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\n>> warnings.\n>> \n>> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\n>> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\n>> things like GNUPGHOME.  But I could easily be wrong about that.\n> \n> Yeah, I think this is the right place to put it (and this approach is\n> the right thing to do).\n\nExcellent, thanks.\n\n>> diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh\n>> index 216281eabc..0dfb48c2f6 100644\n>> --- a/t/lib-httpd.sh\n>> +++ b/t/lib-httpd.sh\n>> @@ -91,6 +91,7 @@ HTTPD_DOCUMENT_ROOT_PATH=$HTTPD_ROOT_PATH/www\n>>  # hack to suppress apache PassEnv warnings\n>>  GIT_VALGRIND=$GIT_VALGRIND; export GIT_VALGRIND\n>>  GIT_VALGRIND_OPTIONS=$GIT_VALGRIND_OPTIONS; export GIT_VALGRIND_OPTIONS\n>> +GIT_TEST_SIDEBAND_ALL=$GIT_TEST_SIDEBAND_ALL; export GIT_TEST_SIDEBAND_ALL\n>>  GIT_TRACE=$GIT_TRACE; export GIT_TRACE\n> \n> I applaud your attempt to alphabetize, but the existing list is already\n> out of order. ;) I don't think it really matters much either way,\n> though.\n\nIt's like a tar pit for catching people with a little OCD.\n\nI debated whether to add it at the end, sort them all in a\nprep patch, or just add it after GIT_TRACE.  I'm not sure if\nI should even admit to spending as much time debating it\nwith myself as I did. ;)\n\n-- \nTodd\n"},{"id":"369336","messageId":"20190214201711.130216-1-jonathantanmy@google.com","threadId":"50503","inReplyTo":"20190214063513.32041-1-tmz@pobox.com","subject":"Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Jonathan Tan","fromEmail":"jonathantanmy@google.com","sentAt":"2019-02-14T20:17:11Z","receivedAt":"2019-02-14T20:17:27Z","isPatch":true,"sender":{"key":"jonathantanmy@fastmail.com","avatar":null},"body":"> 07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\n> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\n> from Apache when the variable is unset, as we do for GIT_VALGRIND* and\n> GIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n> --valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\n> Apache\", 2015-03-13), respectively.\n> \n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n> I missed this with rc0, but poking through build logs I noticed a number\n> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\n> warnings.\n> \n> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\n> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\n> things like GNUPGHOME.  But I could easily be wrong about that.\n\nThanks for looking into this. I think this is the right way to do it\ntoo.\n\nPrevious discussion here [1] but I don't think any patches came out of\nthat.\n\n[1] https://public-inbox.org/git/20190129232732.GB218214@google.com/\n"},{"id":"369342","messageId":"20190214204725.GK16125@zaya.teonanacatl.net","threadId":"50503","inReplyTo":"20190214201711.130216-1-jonathantanmy@google.com","subject":"Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2019-02-14T20:47:25Z","receivedAt":"2019-02-14T20:47:35Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Jonathan Tan wrote:\n>> 07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\n>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\n>> from Apache when the variable is unset, as we do for GIT_VALGRIND* and\n>> GIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n>> --valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\n>> Apache\", 2015-03-13), respectively.\n>> \n>> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n>> ---\n>> I missed this with rc0, but poking through build logs I noticed a number\n>> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\n>> warnings.\n>> \n>> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\n>> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\n>> things like GNUPGHOME.  But I could easily be wrong about that.\n> \n> Thanks for looking into this. I think this is the right way to do it\n> too.\n> \n> Previous discussion here [1] but I don't think any patches came out of\n> that.\n> \n> [1] https://public-inbox.org/git/20190129232732.GB218214@google.com/\n\nHah.  Somehow I missed that thread and Jeff's reply barely\n24 hours before I sent this.  Hopefully this saves Jonathan\nNieder a few minutes of patch prep & testing.\n\nThanks,\n\n-- \nTodd\n"},{"id":"369345","messageId":"xmqqr2ca6p95.fsf@gitster-ct.c.googlers.com","threadId":"50503","inReplyTo":"20190214204725.GK16125@zaya.teonanacatl.net","subject":"Re: [PATCH] t/lib-httpd: pass GIT_TEST_SIDEBAND_ALL through Apache","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-02-14T21:20:38Z","receivedAt":"2019-02-14T21:20:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> Jonathan Tan wrote:\n>>> 07c3c2aa16 (\"tests: define GIT_TEST_SIDEBAND_ALL\", 2019-01-16) added\n>>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list.  Avoid warnings\n>>> from Apache when the variable is unset, as we do for GIT_VALGRIND* and\n>>> GIT_TRACE, from f628825481 (\"t/lib-httpd: handle running under\n>>> --valgrind\", 2012-07-24) and 89c57ab3f0 (\"t: pass GIT_TRACE through\n>>> Apache\", 2015-03-13), respectively.\n>>> \n>>> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n>>> ---\n>>> I missed this with rc0, but poking through build logs I noticed a number\n>>> of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'\n>>> warnings.\n>>> \n>>> I think exporting this in lib-httpd.sh like we do for GIT_VALGRIND* and\n>>> GIT_TRACE is the way to go, as opposed to in test-lib.sh, as we do for\n>>> things like GNUPGHOME.  But I could easily be wrong about that.\n>> \n>> Thanks for looking into this. I think this is the right way to do it\n>> too.\n>> \n>> Previous discussion here [1] but I don't think any patches came out of\n>> that.\n>> \n>> [1] https://public-inbox.org/git/20190129232732.GB218214@google.com/\n>\n> Hah.  Somehow I missed that thread and Jeff's reply barely\n> 24 hours before I sent this.  Hopefully this saves Jonathan\n> Nieder a few minutes of patch prep & testing.\n\nThanks, will queue in the meantime, and let's aim for -rc2.\n"}]}