{"thread":{"id":"50468","subject":"[PATCH] git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg","startedAt":"2019-02-11T21:51:08Z","lastAt":"2019-02-13T03:36:08Z","messageCount":3,"participants":["Ismael Luceno","brian m. carlson"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"369044","messageId":"20190211214203.32444-1-ismael@iodev.co.uk","threadId":"50468","inReplyTo":null,"subject":"[PATCH] git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg","fromName":"Ismael Luceno","fromEmail":"ismael@iodev.co.uk","sentAt":"2019-02-11T21:42:03Z","receivedAt":"2019-02-11T21:51:08Z","isPatch":true,"sender":{"key":"ismael@iodev.co.uk","avatar":"https://avatars.githubusercontent.com/u/426980?v=4"},"body":"Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>\n---\n git-gui.sh | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/git-gui.sh b/git-gui.sh\nindex 5bc21b878d41..e00d9a345294 100755\n--- a/git-gui.sh\n+++ b/git-gui.sh\n@@ -3788,6 +3788,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}\n bind $ui_comm <$M1B-Key-equal> {show_more_context;break}\n bind $ui_comm <$M1B-Key-plus> {show_more_context;break}\n bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}\n+bind $ui_comm <Control-Key-BackSpace> {%W delete {insert -1 chars wordstart} insert;break}\n+bind $ui_comm <Control-Key-Delete> {%W delete insert {insert wordend};break}\n \n bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}\n bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}\n-- \n2.20.1\n\n"},{"id":"369067","messageId":"20190212002932.GC684736@genre.crustytoothpaste.net","threadId":"50468","inReplyTo":"20190211214203.32444-1-ismael@iodev.co.uk","subject":"Re: [PATCH] git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2019-02-12T00:29:33Z","receivedAt":"2019-02-12T00:29:42Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Mon, Feb 11, 2019 at 10:42:03PM +0100, Ismael Luceno wrote:\n> Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>\n> ---\n>  git-gui.sh | 2 ++\n>  1 file changed, 2 insertions(+)\n> \n> diff --git a/git-gui.sh b/git-gui.sh\n> index 5bc21b878d41..e00d9a345294 100755\n> --- a/git-gui.sh\n> +++ b/git-gui.sh\n> @@ -3788,6 +3788,8 @@ bind $ui_comm <$M1B-Key-KP_Subtract> {show_less_context;break}\n>  bind $ui_comm <$M1B-Key-equal> {show_more_context;break}\n>  bind $ui_comm <$M1B-Key-plus> {show_more_context;break}\n>  bind $ui_comm <$M1B-Key-KP_Add> {show_more_context;break}\n> +bind $ui_comm <Control-Key-BackSpace> {%W delete {insert -1 chars wordstart} insert;break}\n> +bind $ui_comm <Control-Key-Delete> {%W delete insert {insert wordend};break}\n\nI don't use git-gui and I don't understand TCL, but I was interested to\nlearn more about these key bindings in case other programs use them and\nthey might be useful in my day-to-day life.\n\nHowever, your commit message doesn't include a body, so it isn't clear\nto me what this change does and why these are useful keys for git-gui to\nunderstand. Are they common among many programs? What do they do? Why\ndid we pick these keys instead of others?\n\nPerhaps you could send a v2 with a more comprehensive commit message\nthat provides some of these answers.\n-- \nbrian m. carlson: Houston, Texas, US\nOpenPGP: https://keybase.io/bk2204\n"},{"id":"369203","messageId":"20190213033558.GJ684736@genre.crustytoothpaste.net","threadId":"50468","inReplyTo":"9EBA7C5F-4D59-45EE-B2E6-E7E76D7221EC@iodev.co.uk","subject":"Re: [PATCH] git-gui: Handle Ctrl+BS & Ctrl+Del in the commit msg","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2019-02-13T03:35:58Z","receivedAt":"2019-02-13T03:36:08Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Tue, Feb 12, 2019 at 12:24:40PM +0100, ismael@iodev.co.uk wrote:\n> These bindings delete the word before and after the cursor\n> respectively. It didn't seem necessary to describe the thing in detail\n> because it has been commonplace for more than 30 years AFAICT.\n\nI'm sure that these key bindings are familiar to you and probably to a\nlot of people, but I wasn't aware of them. I imagine there might be\nother people who aren't aware of them as well. The commit message is an\nopportunity for you to explain both what your patch does and argue why\nit's valuable.\n\nIt's also rather uncommon for commit messages in this project to lack a\nbody; we typically prefer to say at least a few sentences about why\nwe've chosen to make a change, even preferring to perhaps state some of\nthe more obvious things just for clarity's sake to assist other people\n(and future us) in understanding what's going on.\n\nThis isn't me trying to be difficult, but rather to help you get your\npatch in a state that's most likely to be accepted. It's common here to\ndo a couple of revisions of a patch, incorporating reviewers' comments\nand polishing along the way.\n-- \nbrian m. carlson: Houston, Texas, US\nOpenPGP: https://keybase.io/bk2204\n"}]}