{"thread":{"id":"50463","subject":"[PATCH] sequencer: make sign_off_header a file local symbol","startedAt":"2019-02-11T17:17:02Z","lastAt":"2019-02-11T21:08:48Z","messageCount":2,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"369018","messageId":"93b23b5a-7fcd-e9ec-3411-f8362b601732@ramsayjones.plus.com","threadId":"50463","inReplyTo":null,"subject":"[PATCH] sequencer: make sign_off_header a file local symbol","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-02-11T17:16:58Z","receivedAt":"2019-02-11T17:17:02Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit d0aaa46fd3 (\"commit: move empty message checks to libgit\",\n2017-11-10) removes the last use of 'sign_off_header' outside of\nthe \"sequencer.c\" source file. Remove the extern declaration from\nthe header file and mark the definition of the symbol with the\nstatic keyword.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nThis has been hanging around for a while. I sent it to the list last\ntime in [1], but it seems to have been dropped. (Found while attempting\nto rebase loads of old branches to a newer base!)\n\nATB,\nRamsay Jones\n\n[1] https://public-inbox.org/git/8caabe3e-4dc3-657a-236d-6cf91e1e6d03@ramsayjones.plus.com/\n\n sequencer.c | 2 +-\n sequencer.h | 2 --\n 2 files changed, 1 insertion(+), 3 deletions(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex e1a4dd15f1..20f1823b06 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -35,7 +35,7 @@\n \n #define GIT_REFLOG_ACTION \"GIT_REFLOG_ACTION\"\n \n-const char sign_off_header[] = \"Signed-off-by: \";\n+static const char sign_off_header[] = \"Signed-off-by: \";\n static const char cherry_picked_prefix[] = \"(cherry picked from commit \";\n \n GIT_PATH_FUNC(git_path_commit_editmsg, \"COMMIT_EDITMSG\")\ndiff --git a/sequencer.h b/sequencer.h\nindex 5071a73563..e5e4845f14 100644\n--- a/sequencer.h\n+++ b/sequencer.h\n@@ -102,8 +102,6 @@ int complete_action(struct replay_opts *opts, unsigned flags,\n \t\t    unsigned autosquash);\n int rearrange_squash(void);\n \n-extern const char sign_off_header[];\n-\n /*\n  * Append a signoff to the commit message in \"msgbuf\". The ignore_footer\n  * parameter specifies the number of bytes at the end of msgbuf that should\n-- \n2.20.0\n"},{"id":"369038","messageId":"xmqqbm3ighic.fsf@gitster-ct.c.googlers.com","threadId":"50463","inReplyTo":"93b23b5a-7fcd-e9ec-3411-f8362b601732@ramsayjones.plus.com","subject":"Re: [PATCH] sequencer: make sign_off_header a file local symbol","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-02-11T21:08:43Z","receivedAt":"2019-02-11T21:08:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> This has been hanging around for a while. I sent it to the list last\n> time in [1], but it seems to have been dropped. (Found while attempting\n> to rebase loads of old branches to a newer base!)\n\nThanks.  Will apply.\n"}]}