{"thread":{"id":"50435","subject":"[Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","startedAt":"2019-02-08T10:48:41Z","lastAt":"2019-02-09T06:50:18Z","messageCount":8,"participants":["Randall S. Becker","Johannes Schindelin","SZEDER Gábor","Todd Zullinger"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"368817","messageId":"000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com","threadId":"50435","inReplyTo":null,"subject":"[Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2019-02-08T10:48:27Z","receivedAt":"2019-02-08T10:48:41Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"Hi All,\n\nWe have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below:\n\n/home/git/git/t/trash directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout: line 2: $GIT_DIR/post-checkout.args: ambiguous redirect\nnot ok 8 - post-checkout hook is triggered by clone\n#\n#               mkdir -p templates/hooks &&\n#               write_script templates/hooks/post-checkout <<-\\EOF &&\n#               echo \"$@\" >$GIT_DIR/post-checkout.args\n#               EOF\n#               git clone --template=templates . clone3 &&\n#               test -f clone3/.git/post-checkout.args\n#\n\nThe post-checkout hook is:\n#!/usr/local/bin/bash\necho \"$@\" >$GIT_DIR/post-checkout.args\n\nThis looks like it is a \"bash thing\" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace \n\necho \"$@\" >$GIT_DIR/post-checkout.args\n\nwith\n\necho \"$@\" >\"$GIT_DIR/post-checkout.args\"\n\nThe test passes. I wonder I should provide this patch or whether the author would like to do so.\n\nThanks,\nRandall\n\n"},{"id":"368818","messageId":"nycvar.QRO.7.76.6.1902081155000.41@tvgsbejvaqbjf.bet","threadId":"50435","inReplyTo":"000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com","subject":"Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-08T10:55:37Z","receivedAt":"2019-02-08T10:56:00Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Randall,\n\nOn Fri, 8 Feb 2019, Randall S. Becker wrote:\n\n> This looks like it is a \"bash thing\" and $GIT_DIR might have to be in\n> quotes, and is not be specific to the platform. If I replace \n> \n> echo \"$@\" >$GIT_DIR/post-checkout.args\n> \n> with\n> \n> echo \"$@\" >\"$GIT_DIR/post-checkout.args\"\n> \n> The test passes. I wonder I should provide this patch or whether the\n> author would like to do so.\n\nIt is the correct fix, you came up with it, why not simply provide a\npatch yourself?\n\nThanks,\nDscho\n"},{"id":"368820","messageId":"000e01d4bf9d$38df5c80$aa9e1580$@nexbridge.com","threadId":"50435","inReplyTo":"nycvar.QRO.7.76.6.1902081155000.41@tvgsbejvaqbjf.bet","subject":"RE: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2019-02-08T10:58:23Z","receivedAt":"2019-02-08T10:58:41Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On February 8, 2019 5:56, Johannes Schindelin wrote:\n> To: Randall S. Becker <rsbecker@nexbridge.com>\n> Cc: 'Junio C Hamano' <gitster@pobox.com>; git@vger.kernel.org; 'Linux\n> Kernel' <linux-kernel@vger.kernel.org>; git-packagers@googlegroups.com\n> Subject: Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)\n> \n> Hi Randall,\n> \n> On Fri, 8 Feb 2019, Randall S. Becker wrote:\n> \n> > This looks like it is a \"bash thing\" and $GIT_DIR might have to be in\n> > quotes, and is not be specific to the platform. If I replace\n> >\n> > echo \"$@\" >$GIT_DIR/post-checkout.args\n> >\n> > with\n> >\n> > echo \"$@\" >\"$GIT_DIR/post-checkout.args\"\n> >\n> > The test passes. I wonder I should provide this patch or whether the\n> > author would like to do so.\n> \n> It is the correct fix, you came up with it, why not simply provide a patch\n> yourself?\n\nWill do (later today)\n\n"},{"id":"368822","messageId":"20190208111002.GU10587@szeder.dev","threadId":"50435","inReplyTo":"000d01d4bf9b$d5d48da0$817da8e0$@nexbridge.com","subject":"Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-02-08T11:10:02Z","receivedAt":"2019-02-08T11:10:13Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:\n> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below:\n> \n> /home/git/git/t/trash directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout: line 2: $GIT_DIR/post-checkout.args: ambiguous redirect\n> not ok 8 - post-checkout hook is triggered by clone\n> #\n> #               mkdir -p templates/hooks &&\n> #               write_script templates/hooks/post-checkout <<-\\EOF &&\n> #               echo \"$@\" >$GIT_DIR/post-checkout.args\n> #               EOF\n> #               git clone --template=templates . clone3 &&\n> #               test -f clone3/.git/post-checkout.args\n> #\n> \n> The post-checkout hook is:\n> #!/usr/local/bin/bash\n> echo \"$@\" >$GIT_DIR/post-checkout.args\n> \n> This looks like it is a \"bash thing\" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace \n> \n> echo \"$@\" >$GIT_DIR/post-checkout.args\n> \n> with\n> \n> echo \"$@\" >\"$GIT_DIR/post-checkout.args\"\n> \n> The test passes.\n\nWow, this is the second time this \"redirection to a filename with\nspaces under Bash\" issue pops up today, see the other one here:\n\n  https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#u\n\nIn short, Bash (when invoked as bash) doesn't conform to POSIX in this\nrespect; for a (too detailed) explanation see:\n\n  https://public-inbox.org/git/20180926121107.GH27036@localhost/\n\nEven our CodingGuidelines suggest the use of quotes around the\nredirection's target.\n\n> I wonder I should provide this patch or whether the author would like to do so.\n\nWell, since you didn't Cc the author, he might very well overlook this\nissue, so I think you should ;)\n\n"},{"id":"368829","messageId":"001001d4bfa2$84dcff70$8e96fe50$@nexbridge.com","threadId":"50435","inReplyTo":"20190208111002.GU10587@szeder.dev","subject":"RE: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2019-02-08T11:36:17Z","receivedAt":"2019-02-08T11:36:35Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On February 8, 2019 6:10, SZEDER Gábor\n> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:\n> > We have a few new breakages on the NonStop port in 2.21.0-rc0. The first\n> is in t5403, as below:\n> >\n> > /home/git/git/t/trash\n> > directory.t5403-post-checkout-hook/clone3/.git/hooks/post-checkout:\n> > line 2: $GIT_DIR/post-checkout.args: ambiguous redirect not ok 8 - post-\n> checkout hook is triggered by clone #\n> > #               mkdir -p templates/hooks &&\n> > #               write_script templates/hooks/post-checkout <<-\\EOF &&\n> > #               echo \"$@\" >$GIT_DIR/post-checkout.args\n> > #               EOF\n> > #               git clone --template=templates . clone3 &&\n> > #               test -f clone3/.git/post-checkout.args\n> > #\n> >\n> > The post-checkout hook is:\n> > #!/usr/local/bin/bash\n> > echo \"$@\" >$GIT_DIR/post-checkout.args\n> >\n> > This looks like it is a \"bash thing\" and $GIT_DIR might have to be in\n> > quotes, and is not be specific to the platform. If I replace\n> >\n> > echo \"$@\" >$GIT_DIR/post-checkout.args\n> >\n> > with\n> >\n> > echo \"$@\" >\"$GIT_DIR/post-checkout.args\"\n> >\n> > The test passes.\n> \n> Wow, this is the second time this \"redirection to a filename with spaces\n> under Bash\" issue pops up today, see the other one here:\n> \n>   https://public-inbox.org/git/20190208031746.22683-2-\n> tmz@pobox.com/T/#u\n> \n> In short, Bash (when invoked as bash) doesn't conform to POSIX in this\n> respect; for a (too detailed) explanation see:\n> \n>   https://public-inbox.org/git/20180926121107.GH27036@localhost/\n> \n> Even our CodingGuidelines suggest the use of quotes around the\n> redirection's target.\n> \n> > I wonder I should provide this patch or whether the author would like to do\n> so.\n> \n> Well, since you didn't Cc the author, he might very well overlook this issue,\n> so I think you should ;)\n\n+ Nguyen and Orgad\n\nThanks. Fix has been submitted as a patch. This is definitely a common one. 😊\n\n"},{"id":"368874","messageId":"20190208201128.GD30548@zaya.teonanacatl.net","threadId":"50435","inReplyTo":"20190208111002.GU10587@szeder.dev","subject":"Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2019-02-08T20:11:29Z","receivedAt":"2019-02-08T20:11:40Z","isPatch":false,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"SZEDER Gábor wrote:\n> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:\n>> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is in t5403, as below:\n[...]\n>> The post-checkout hook is:\n>> #!/usr/local/bin/bash\n>> echo \"$@\" >$GIT_DIR/post-checkout.args\n>> \n>> This looks like it is a \"bash thing\" and $GIT_DIR might have to be in quotes, and is not be specific to the platform. If I replace \n>> \n>> echo \"$@\" >$GIT_DIR/post-checkout.args\n>> \n>> with\n>> \n>> echo \"$@\" >\"$GIT_DIR/post-checkout.args\"\n>> \n>> The test passes.\n> \n> Wow, this is the second time this \"redirection to a filename with\n> spaces under Bash\" issue pops up today, see the other one here:\n> \n>   https://public-inbox.org/git/20190208031746.22683-2-tmz@pobox.com/T/#u\n\nIndeed, I was surprised to see another one today.\n\nIt made me wonder how I had missed it in my own testing.\nThis one requires SHELL_PATH to be bash, while I only set\nTEST_SHELL_PATH to bash for the improved -x tracing in the\nfedora builds.\n\nI ran the tests again with SHELL_PATH as bash on fedora and\nthis was the only failure I saw (other than the one from my\nearlier message, that is).\n\n-- \nTodd\n"},{"id":"368878","messageId":"20190208203009.GC10587@szeder.dev","threadId":"50435","inReplyTo":"20190208201128.GD30548@zaya.teonanacatl.net","subject":"Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-02-08T20:30:09Z","receivedAt":"2019-02-08T20:30:19Z","isPatch":false,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote:\n> It made me wonder how I had missed it in my own testing.\n> This one requires SHELL_PATH to be bash, while I only set\n> TEST_SHELL_PATH to bash for the improved -x tracing in the\n> fedora builds.\n\nNote that you don't need Bash to use '-x' tracing since a5bf824f3b (t:\nprevent '-x' tracing from interfering with test helpers' stderr,\n2018-02-25) and the followup commits, except for 't1510-repo-setup.sh'\n(and even t1510 just falls back to ignore '-x' instead of causing\nfailures).\n\n"},{"id":"368912","messageId":"20190209064821.GG30548@zaya.teonanacatl.net","threadId":"50435","inReplyTo":"20190208203009.GC10587@szeder.dev","subject":"Re: [Breakage] Git v2.21.0-rc0 - t5403 (NonStop)","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2019-02-09T06:48:21Z","receivedAt":"2019-02-09T06:50:18Z","isPatch":false,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"[-cc: linux-kernel & git-packagers]\n\nSZEDER Gábor wrote:\n> On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote:\n>> It made me wonder how I had missed it in my own testing.\n>> This one requires SHELL_PATH to be bash, while I only set\n>> TEST_SHELL_PATH to bash for the improved -x tracing in the\n>> fedora builds.\n> \n> Note that you don't need Bash to use '-x' tracing since a5bf824f3b (t:\n> prevent '-x' tracing from interfering with test helpers' stderr,\n> 2018-02-25) and the followup commits, except for 't1510-repo-setup.sh'\n> (and even t1510 just falls back to ignore '-x' instead of causing\n> failures).\n\nHuh, cool.  I somehow missed that nice improvement.  Thanks\nfor all your fine work on the test suite!  It makes my life\nas a packager much better having a robust test suite running\nwith each build.\n\n-- \nTodd\n"}]}