{"thread":{"id":"50383","subject":"[PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","startedAt":"2019-02-02T16:34:35Z","lastAt":"2019-02-06T11:33:29Z","messageCount":9,"participants":["SZEDER Gábor","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"368418","messageId":"20190202163421.19686-1-szeder.dev@gmail.com","threadId":"50383","inReplyTo":null,"subject":"[PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-02-02T16:34:21Z","receivedAt":"2019-02-02T16:34:35Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Before installing the necessary dependencies, our OSX build jobs run\n'brew update --quiet'. This is problematic for two reasons:\n\n - This '--quiet' flag apparently broke overnight, resulting in\n errored builds:\n\n +brew update --quiet\n ==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.mavericks.bottle.tar.gz\n ######################################################################## 100.0%\n ==> Pouring portable-ruby-2.3.7.mavericks.bottle.tar.gz\n Usage: brew update_report [--preinstall]\n The Ruby implementation of brew update. Never called manually.\n --preinstall Run in 'auto-update' mode (faster, less\n output).\n -f, --force Override warnings and enable potentially\n unsafe operations.\n -d, --debug Display any debugging information.\n -v, --verbose Make some output more verbose.\n -h, --help Show this message.\n Error: invalid option: --quiet\n The command \"ci/install-dependencies.sh\" failed and exited with 1 during .\n\n I belive that this breakage will be noticed and fixed soon-ish, so\n we could probably just wait a bit for this issue to solve itself,\n but:\n\n - 'brew update --quiet' wasn't really quiet in the first place, as\n it listed over about 2000 lines worth of available packages that\n we absolutely don't care about, see e.g. one of the latest\n 'master' builds:\n\n https://travis-ci.org/git/git/jobs/486134962#L113\n\nSo drop this '--quiet' option and redirect 'brew update's standard\noutput to /dev/null to make it really quiet, thereby making the OSX\nbuilds work again despite the above mentioned breakage.\n\nSigned-off-by: SZEDER Gábor \n---\n\nNotes:\n There is no conflict with Dscho's Azure Pipelines patch series; the\n patch contexts overlap a bit, but the auto-merging results look good\n to me.\n\n ci/install-dependencies.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\nindex 06c3546e1e..5968efdbbe 100755\n--- a/ci/install-dependencies.sh\n+++ b/ci/install-dependencies.sh\n@@ -34,7 +34,7 @@ linux-clang|linux-gcc)\n \tpopd\n \t;;\n osx-clang|osx-gcc)\n-\tbrew update --quiet\n+\tbrew update >/dev/null\n \t# Uncomment this if you want to run perf tests:\n \t# brew install gnu-time\n \tbrew install git-lfs gettext\n-- \n2.20.1.642.gc55a771460\n\n"},{"id":"368447","messageId":"nycvar.QRO.7.76.6.1902041045280.41@tvgsbejvaqbjf.bet","threadId":"50383","inReplyTo":"20190202163421.19686-1-szeder.dev@gmail.com","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-04T09:49:05Z","receivedAt":"2019-02-04T09:49:14Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Gábor,\n\nOn Sat, 2 Feb 2019, SZEDER Gábor wrote:\n\n> Before installing the necessary dependencies, our OSX build jobs run\n> 'brew update --quiet'. This is problematic for two reasons:\n> \n> - This '--quiet' flag apparently broke overnight, resulting in\n> errored builds:\n> \n> +brew update --quiet\n> ==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.mavericks.bottle.tar.gz\n> ######################################################################## 100.0%\n> ==> Pouring portable-ruby-2.3.7.mavericks.bottle.tar.gz\n> Usage: brew update_report [--preinstall]\n> The Ruby implementation of brew update. Never called manually.\n> --preinstall Run in 'auto-update' mode (faster, less\n> output).\n> -f, --force Override warnings and enable potentially\n> unsafe operations.\n> -d, --debug Display any debugging information.\n> -v, --verbose Make some output more verbose.\n> -h, --help Show this message.\n> Error: invalid option: --quiet\n> The command \"ci/install-dependencies.sh\" failed and exited with 1 during .\n> \n> I belive that this breakage will be noticed and fixed soon-ish, so\n> we could probably just wait a bit for this issue to solve itself,\n> but:\n> \n> - 'brew update --quiet' wasn't really quiet in the first place, as\n> it listed over about 2000 lines worth of available packages that\n> we absolutely don't care about, see e.g. one of the latest\n> 'master' builds:\n> \n> https://travis-ci.org/git/git/jobs/486134962#L113\n> \n> So drop this '--quiet' option and redirect 'brew update's standard\n> output to /dev/null to make it really quiet, thereby making the OSX\n> builds work again despite the above mentioned breakage.\n> \n> Signed-off-by: SZEDER Gábor \n> ---\n> \n> Notes:\n> There is no conflict with Dscho's Azure Pipelines patch series; the\n> patch contexts overlap a bit, but the auto-merging results look good\n> to me.\n\nAnd this indeed also affects Azure Pipelines.\n\nSince Junio's workflow is very different from GitHub Flow (where this\nissue would be worked around with a simple, single Pull Request), we have\nno prayer at a workaround on our side, though: pretty much *all* of the\nnext builds of Junio's branches will be broken, unless he chooses to\nbackport your patch to all of the base commits he chose for those\nbranches.\n\nSo our best bet at not getting overwhelmed with failed builds is to help\nHomebrew get `brew update --quiet` to work again. I just opened a ticket\nto that end:\n\n\thttps://github.com/Homebrew/brew/issues/5666\n\nI do like your patch, though, and am very much in favor of fast-tracking\nit all the way down to `maint`.\n\nCiao,\nDscho\n\n> ci/install-dependencies.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 06c3546e1e..5968efdbbe 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -34,7 +34,7 @@ linux-clang|linux-gcc)\n> \tpopd\n> \t;;\n> osx-clang|osx-gcc)\n> -\tbrew update --quiet\n> +\tbrew update >/dev/null\n> \t# Uncomment this if you want to run perf tests:\n> \t# brew install gnu-time\n> \tbrew install git-lfs gettext\n> -- \n> 2.20.1.642.gc55a771460\n> \n> \n> "},{"id":"368468","messageId":"xmqqk1ifv296.fsf@gitster-ct.c.googlers.com","threadId":"50383","inReplyTo":"20190202163421.19686-1-szeder.dev@gmail.com","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-02-04T18:26:29Z","receivedAt":"2019-02-04T18:26:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"SZEDER Gábor writes:\n\n> Before installing the necessary dependencies, our OSX build jobs run\n> 'brew update --quiet'. This is problematic for two reasons:\n>\n> - This '--quiet' flag apparently broke overnight, resulting in\n> errored builds:\n> ...\n> I belive that this breakage will be noticed and fixed soon-ish, so\n> we could probably just wait a bit for this issue to solve itself,\n\nYuck. Well, an external influence that can break the automated\nbuild job overnight should be capable of fixing it overnight ;-)\n\n> but:\n>\n> - 'brew update --quiet' wasn't really quiet in the first place, as\n> it listed over about 2000 lines worth of available packages that\n> we absolutely don't care about, see e.g. one of the latest\n> 'master' builds:\n>\n> https://travis-ci.org/git/git/jobs/486134962#L113\n>\n> So drop this '--quiet' option and redirect 'brew update's standard\n> output to /dev/null to make it really quiet, thereby making the OSX\n> builds work again despite the above mentioned breakage.\n\nSounds good.\n\n> There is no conflict with Dscho's Azure Pipelines patch series; the\n> patch contexts overlap a bit, but the auto-merging results look good\n> to me.\n\nThanks for extra careful.\n\nIf this is truly urgent, I could merge this to 'maint' and merge the\nresult upwards to 'pu' and it would hide the issue on my four\nintegration branches. But one thing that makes me wonder is if we\ncan (or want to) do anything to help other people who test build\nwith pull requests. I guess they need to rebase on top of whatever\ncommit that has this fix? That sounds more like a tail wagging a\ndog, though. I dunno.\n\n> ci/install-dependencies.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> index 06c3546e1e..5968efdbbe 100755\n> --- a/ci/install-dependencies.sh\n> +++ b/ci/install-dependencies.sh\n> @@ -34,7 +34,7 @@ linux-clang|linux-gcc)\n> \tpopd\n> \t;;\n> osx-clang|osx-gcc)\n> -\tbrew update --quiet\n> +\tbrew update >/dev/null\n> \t# Uncomment this if you want to run perf tests:\n> \t# brew install gnu-time\n> \tbrew install git-lfs gettext\n"},{"id":"368479","messageId":"20190204193826.GH10587@szeder.dev","threadId":"50383","inReplyTo":"nycvar.QRO.7.76.6.1902041045280.41@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-02-04T19:38:26Z","receivedAt":"2019-02-04T19:38:34Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Mon, Feb 04, 2019 at 10:49:05AM +0100, Johannes Schindelin wrote:\n> Hi Gábor,\n> \n> On Sat, 2 Feb 2019, SZEDER Gábor wrote:\n> \n> > Before installing the necessary dependencies, our OSX build jobs run\n> > 'brew update --quiet'. This is problematic for two reasons:\n> > \n> > - This '--quiet' flag apparently broke overnight, resulting in\n> > errored builds:\n> > \n> > +brew update --quiet\n> > ==> Downloading https://homebrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.mavericks.bottle.tar.gz\n> > ######################################################################## 100.0%\n> > ==> Pouring portable-ruby-2.3.7.mavericks.bottle.tar.gz\n> > Usage: brew update_report [--preinstall]\n> > The Ruby implementation of brew update. Never called manually.\n> > --preinstall Run in 'auto-update' mode (faster, less\n> > output).\n> > -f, --force Override warnings and enable potentially\n> > unsafe operations.\n> > -d, --debug Display any debugging information.\n> > -v, --verbose Make some output more verbose.\n> > -h, --help Show this message.\n> > Error: invalid option: --quiet\n> > The command \"ci/install-dependencies.sh\" failed and exited with 1 during .\n> > \n> > I belive that this breakage will be noticed and fixed soon-ish, so\n> > we could probably just wait a bit for this issue to solve itself,\n> > but:\n> > \n> > - 'brew update --quiet' wasn't really quiet in the first place, as\n> > it listed over about 2000 lines worth of available packages that\n> > we absolutely don't care about, see e.g. one of the latest\n> > 'master' builds:\n> > \n> > https://travis-ci.org/git/git/jobs/486134962#L113\n> > \n> > So drop this '--quiet' option and redirect 'brew update's standard\n> > output to /dev/null to make it really quiet, thereby making the OSX\n> > builds work again despite the above mentioned breakage.\n> > \n> > Signed-off-by: SZEDER Gábor \n> > ---\n> > \n> > Notes:\n> > There is no conflict with Dscho's Azure Pipelines patch series; the\n> > patch contexts overlap a bit, but the auto-merging results look good\n> > to me.\n> \n> And this indeed also affects Azure Pipelines.\n> \n> Since Junio's workflow is very different from GitHub Flow (where this\n> issue would be worked around with a simple, single Pull Request),\n\nI doubt that a single PR could be sufficient, because it won't help\ncontributors who want to run CI builds in their own forks; they would\nhave to rebase their branches on top of the fix, or cherry-pick it, or\nwhatnot.\n\n> we have\n> no prayer at a workaround on our side, though: pretty much *all* of the\n> next builds of Junio's branches will be broken, unless he chooses to\n> backport your patch to all of the base commits he chose for those\n> branches.\n> \n> So our best bet at not getting overwhelmed with failed builds ...\n\nOh, in my long-time for-fun semi-automated CI experiment [1] all\nintegration branches and cooking topics are still just fine :) they\nall have been including this patch (among many others) for quite some\ntime now (since when the list of available Homebrew packages was\n\"only\" about 1700 lines... about a year ago).\n\nUnfortunately, I never upstreamed it, because that long list of\npackages is folded up anyway when viewing the logs, so why bother...\nIn hindsight, I should have. Oh, well.\n\n[1] https://travis-ci.org/szeder/git-cooking-topics-for-travis-ci/branches\n\n> is to help\n> Homebrew get `brew update --quiet` to work again. I just opened a ticket\n> to that end:\n> \n> \thttps://github.com/Homebrew/brew/issues/5666\n> \n> I do like your patch, though, and am very much in favor of fast-tracking\n> it all the way down to `maint`.\n> \n> Ciao,\n> Dscho\n> \n> > ci/install-dependencies.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh\n> > index 06c3546e1e..5968efdbbe 100755\n> > --- a/ci/install-dependencies.sh\n> > +++ b/ci/install-dependencies.sh\n> > @@ -34,7 +34,7 @@ linux-clang|linux-gcc)\n> > \tpopd\n> > \t;;\n> > osx-clang|osx-gcc)\n> > -\tbrew update --quiet\n> > +\tbrew update >/dev/null\n> > \t# Uncomment this if you want to run perf tests:\n> > \t# brew install gnu-time\n> > \tbrew install git-lfs gettext\n> > -- \n> > 2.20.1.642.gc55a771460\n"},{"id":"368480","messageId":"20190204193823.GA4511@szeder.dev","threadId":"50383","inReplyTo":"xmqqk1ifv296.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2019-02-04T19:38:23Z","receivedAt":"2019-02-04T19:38:36Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"On Mon, Feb 04, 2019 at 10:26:29AM -0800, Junio C Hamano wrote:\n> SZEDER Gábor writes:\n> \n> > - This '--quiet' flag apparently broke overnight, resulting in\n> > errored builds:\n> > ...\n> > I belive that this breakage will be noticed and fixed soon-ish, so\n> > we could probably just wait a bit for this issue to solve itself,\n> \n> Yuck. Well, an external influence that can break the automated\n> build job overnight should be capable of fixing it overnight ;-)\n\n> If this is truly urgent, I could merge this to 'maint' and merge the\n> result upwards to 'pu' and it would hide the issue on my four\n> integration branches. But one thing that makes me wonder is if we\n> can (or want to) do anything to help other people who test build\n> with pull requests. I guess they need to rebase on top of whatever\n> commit that has this fix? That sounds more like a tail wagging a\n> dog, though. I dunno.\n\nContributors don't have to rebase to make their PR builds work. When\nTravis CI builds a PR, it doesn't build the branch on its own, but the\nmerge of that branch into 'master' (or whatever the default branch is\ncalled), assuming can be it merged cleanly. So as soon as this fix\nlands in master, the PR builds should be fine. I suppose.\n\nHowever, they will need to rebase their WIP/not PR-ed/not upstreamable\nbranches on top of this fix if they want to run Travis CI builds in\ntheir own forks.\n\nUnless, of course, the external influence does manage to fix itself\novernight :) Under Dscho's bugreport it looks like they already\nmerged a one-liner fix, but how long will it take to tickle down to\nTravis CI, I have no idea.\n\n"},{"id":"368520","messageId":"nycvar.QRO.7.76.6.1902051229570.41@tvgsbejvaqbjf.bet","threadId":"50383","inReplyTo":"20190204193826.GH10587@szeder.dev","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-05T11:31:55Z","receivedAt":"2019-02-05T11:32:00Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Gábor,\n\nOn Mon, 4 Feb 2019, SZEDER Gábor wrote:\n\n> On Mon, Feb 04, 2019 at 10:49:05AM +0100, Johannes Schindelin wrote:\n> \n> > So our best bet at not getting overwhelmed with failed builds ...\n> \n> Oh, in my long-time for-fun semi-automated CI experiment [1] all\n> integration branches and cooking topics are still just fine :) they\n> all have been including this patch (among many others) for quite some\n> time now (since when the list of available Homebrew packages was\n> \"only\" about 1700 lines... about a year ago).\n> \n> Unfortunately, I never upstreamed it, because that long list of\n> packages is folded up anyway when viewing the logs, so why bother...\n> In hindsight, I should have. Oh, well.\n> \n> [1] https://travis-ci.org/szeder/git-cooking-topics-for-travis-ci/branches\n\nHeh, I feel ya. 70 branches in Git for Windows' patch thicket are waiting\n(for the most part) to be upstreamed.\n\n> > is to help Homebrew get `brew update --quiet` to work again. I just\n> > opened a ticket to that end:\n> > \n> > \thttps://github.com/Homebrew/brew/issues/5666\n\nAnd this ticket has been closed with a fix! Yay! I checked, and on Travis,\n`pu` is now only broken for the FUNNYNAMES issue in Elijah's t4038 that I\nalready reported.\n\nCiao,\nDscho"},{"id":"368521","messageId":"nycvar.QRO.7.76.6.1902051240080.41@tvgsbejvaqbjf.bet","threadId":"50383","inReplyTo":"20190204193823.GA4511@szeder.dev","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-05T11:41:11Z","receivedAt":"2019-02-05T11:41:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Gábor,\n\nOn Mon, 4 Feb 2019, SZEDER Gábor wrote:\n\n> Under Dscho's bugreport it looks like they already merged a one-liner\n> fix, but how long will it take to tickle down to Travis CI, I have no\n> idea.\n\nSince the fix affected a Homebrew package, it was not so much about\ntrickling down to Travis, but about trickling down into the public\nHomebrew repositories. And it seems that that trickling is complete now.\n\nCiao,\nDscho"},{"id":"368531","messageId":"xmqq4l9it946.fsf@gitster-ct.c.googlers.com","threadId":"50383","inReplyTo":"nycvar.QRO.7.76.6.1902051240080.41@tvgsbejvaqbjf.bet","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-02-05T17:53:29Z","receivedAt":"2019-02-05T17:53:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n> On Mon, 4 Feb 2019, SZEDER Gábor wrote:\n>\n>> Under Dscho's bugreport it looks like they already merged a one-liner\n>> fix, but how long will it take to tickle down to Travis CI, I have no\n>> idea.\n>\n> Since the fix affected a Homebrew package, it was not so much about\n> trickling down to Travis, but about trickling down into the public\n> Homebrew repositories. And it seems that that trickling is complete now.\n\nGood news. Thanks both for reporting and monitoring.\n\nI still think the >/dev/null thing is a good idea, so unless I hear\notherwise, let's merge it down to 'next', etc.\n"},{"id":"368581","messageId":"nycvar.QRO.7.76.6.1902061233030.41@tvgsbejvaqbjf.bet","threadId":"50383","inReplyTo":"xmqq4l9it946.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH] travis-ci: make the OSX build jobs' 'brew update' more quiet","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-02-06T11:33:22Z","receivedAt":"2019-02-06T11:33:29Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Tue, 5 Feb 2019, Junio C Hamano wrote:\n\n> Johannes Schindelin writes:\n> \n> > On Mon, 4 Feb 2019, SZEDER Gábor wrote:\n> >\n> >> Under Dscho's bugreport it looks like they already merged a one-liner\n> >> fix, but how long will it take to tickle down to Travis CI, I have no\n> >> idea.\n> >\n> > Since the fix affected a Homebrew package, it was not so much about\n> > trickling down to Travis, but about trickling down into the public\n> > Homebrew repositories. And it seems that that trickling is complete now.\n> \n> Good news. Thanks both for reporting and monitoring.\n> \n> I still think the >/dev/null thing is a good idea, so unless I hear\n> otherwise, let's merge it down to 'next', etc.\n\nYes, it is a very good idea.\n\nCiao,\nDscho"}]}