{"thread":{"id":"50331","subject":"[PATCH] trace2: fix hdr-check warnings","startedAt":"2019-01-26T21:07:10Z","lastAt":"2019-02-05T20:22:48Z","messageCount":5,"participants":["Ramsay Jones","Jeff Hostetler","Carlo Arenas"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"367718","messageId":"ba0549c5-25f1-efcc-e49a-d7e76be73fe3@ramsayjones.plus.com","threadId":"50331","inReplyTo":null,"subject":"[PATCH] trace2: fix hdr-check warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-01-26T21:07:06Z","receivedAt":"2019-01-26T21:07:10Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Jeff,\n\nIf you need to re-roll your 'jh/trace2' branch, could you please\nsquash this into the relevant patches (sorry, I didn't look to\nsee which patches need to be modified).\n\nThanks!\n\nATB,\nRamsay Jones\n\n trace2/tr2_tgt.h | 4 ++++\n trace2/tr2_tls.h | 2 ++\n 2 files changed, 6 insertions(+)\n\ndiff --git a/trace2/tr2_tgt.h b/trace2/tr2_tgt.h\nindex 4fdf253b57..8a46bbad4e 100644\n--- a/trace2/tr2_tgt.h\n+++ b/trace2/tr2_tgt.h\n@@ -1,6 +1,10 @@\n #ifndef TR2_TGT_H\n #define TR2_TGT_H\n \n+struct child_process;\n+struct repository;\n+struct json_writer;\n+\n /*\n * Function prototypes for a TRACE2 \"target\" vtable.\n */\ndiff --git a/trace2/tr2_tls.h b/trace2/tr2_tls.h\nindex 99ea9018ce..bb80e3f8e7 100644\n--- a/trace2/tr2_tls.h\n+++ b/trace2/tr2_tls.h\n@@ -1,6 +1,8 @@\n #ifndef TR2_TLS_H\n #define TR2_TLS_H\n \n+#include \"strbuf.h\"\n+\n /*\n * Arbitry limit for thread names for column alignment.\n */\n-- \n2.20.0\n"},{"id":"368123","messageId":"00e08dc3-a610-0429-e819-1d29d0ddb81a@jeffhostetler.com","threadId":"50331","inReplyTo":"ba0549c5-25f1-efcc-e49a-d7e76be73fe3@ramsayjones.plus.com","subject":"Re: [PATCH] trace2: fix hdr-check warnings","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2019-01-30T12:29:25Z","receivedAt":"2019-01-30T12:29:28Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 1/26/2019 4:07 PM, Ramsay Jones wrote:\n> \n> Signed-off-by: Ramsay Jones \n> ---\n> \n> Hi Jeff,\n> \n> If you need to re-roll your 'jh/trace2' branch, could you please\n> squash this into the relevant patches (sorry, I didn't look to\n> see which patches need to be modified).\n\nWill do. Thanks.\n\nBTW, how do you find these? I ran both \"make sparse\" and\n\"make DEVELOPER=1\" and it didn't complain about these items.\n\nJeff\n\n"},{"id":"368140","messageId":"CAPUEspgs795iM3nseKYOD0RFcAh2qCdq-zVOYkTBVjO2zPe6zw@mail.gmail.com","threadId":"50331","inReplyTo":"00e08dc3-a610-0429-e819-1d29d0ddb81a@jeffhostetler.com","subject":"Re: [PATCH] trace2: fix hdr-check warnings","fromName":"Carlo Arenas","fromEmail":"carenas@gmail.com","sentAt":"2019-01-30T15:39:42Z","receivedAt":"2019-01-30T15:39:56Z","isPatch":true,"sender":{"key":"carenas@gmail.com","avatar":"https://avatars.githubusercontent.com/u/76036?v=4"},"body":"On Wed, Jan 30, 2019 at 4:30 AM Jeff Hostetler wrote:\n> BTW, how do you find these? I ran both \"make sparse\" and\n> \"make DEVELOPER=1\" and it didn't complain about these items.\n\n$ make hdr-check\n\navailable since ebb7baf02f (\"Makefile: add a hdr-check target\", 2018-09-19)\n\nCarlo\n"},{"id":"368481","messageId":"d680fda2-7e54-2200-cd00-97772de45b47@ramsayjones.plus.com","threadId":"50331","inReplyTo":"00e08dc3-a610-0429-e819-1d29d0ddb81a@jeffhostetler.com","subject":"Re: [PATCH] trace2: fix hdr-check warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-02-04T19:44:30Z","receivedAt":"2019-02-04T19:44:35Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\n\nOn 30/01/2019 12:29, Jeff Hostetler wrote:\n> \n> \n> On 1/26/2019 4:07 PM, Ramsay Jones wrote:\n>>\n>> Signed-off-by: Ramsay Jones \n>> ---\n>>\n>> Hi Jeff,\n>>\n>> If you need to re-roll your 'jh/trace2' branch, could you please\n>> squash this into the relevant patches (sorry, I didn't look to\n>> see which patches need to be modified).\n> \n> Will do. Thanks.\n> \n> BTW, how do you find these?  I ran both \"make sparse\" and\n> \"make DEVELOPER=1\" and it didn't complain about these items.\n\nCarlo already replied about 'make hdr-check', but you seem to\nhave missed squashing half of the original patch, since the\nre-rolled series still causes 'make -k hdr-check >phcout 2>&1'\nto show:\n\n $ diff nhcout phcout\n 22a23,34\n > HDR trace2/tr2_dst.h\n > HDR trace2/tr2_cfg.h\n > HDR trace2/tr2_tgt.h\n > HDR trace2/tr2_cmd_name.h\n > HDR trace2/tr2_sid.h\n > HDR trace2/tr2_tls.h\n > trace2/tr2_tls.h:12:16: error: field ‘thread_name’ has incomplete type\n > struct strbuf thread_name;\n > ^~~~~~~~~~~\n > Makefile:2739: recipe for target 'trace2/tr2_tls.hco' failed\n > make: *** [trace2/tr2_tls.hco] Error 1\n > HDR trace2/tr2_tbuf.h\n 131c143\n < Makefile:2725: recipe for target 'sha256/gcrypt.hco' failed\n ---\n > Makefile:2739: recipe for target 'sha256/gcrypt.hco' failed\n 164a177\n > HDR trace2.h\n $ \n\nSo, quoting the last part of the original patch:\n\ndiff --git a/trace2/tr2_tls.h b/trace2/tr2_tls.h\nindex 99ea9018ce..bb80e3f8e7 100644\n--- a/trace2/tr2_tls.h\n+++ b/trace2/tr2_tls.h\n@@ -1,6 +1,8 @@\n #ifndef TR2_TLS_H\n #define TR2_TLS_H\n \n+#include \"strbuf.h\"\n+\n /*\n * Arbitry limit for thread names for column alignment.\n */\n-- \n\n\nATB,\nRamsay Jones\n\n\n\n\n"},{"id":"368542","messageId":"d91d1d89-5759-2006-7b38-4211db5988af@jeffhostetler.com","threadId":"50331","inReplyTo":"d680fda2-7e54-2200-cd00-97772de45b47@ramsayjones.plus.com","subject":"Re: [PATCH] trace2: fix hdr-check warnings","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2019-02-05T20:22:43Z","receivedAt":"2019-02-05T20:22:48Z","isPatch":true,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 2/4/2019 2:44 PM, Ramsay Jones wrote:\n> \n> \n> On 30/01/2019 12:29, Jeff Hostetler wrote:\n>>\n>>\n>> On 1/26/2019 4:07 PM, Ramsay Jones wrote:\n>>>\n>>> Signed-off-by: Ramsay Jones \n>>> ---\n>>>\n>>> Hi Jeff,\n>>>\n>>> If you need to re-roll your 'jh/trace2' branch, could you please\n>>> squash this into the relevant patches (sorry, I didn't look to\n>>> see which patches need to be modified).\n>>\n>> Will do. Thanks.\n>>\n>> BTW, how do you find these?  I ran both \"make sparse\" and\n>> \"make DEVELOPER=1\" and it didn't complain about these items.\n> \n> Carlo already replied about 'make hdr-check', but you seem to\n> have missed squashing half of the original patch, since the\n> re-rolled series still causes 'make -k hdr-check >phcout 2>&1'\n> to show:\n> \n> $ diff nhcout phcout\n> 22a23,34\n> > HDR trace2/tr2_dst.h\n> > HDR trace2/tr2_cfg.h\n> > HDR trace2/tr2_tgt.h\n> > HDR trace2/tr2_cmd_name.h\n> > HDR trace2/tr2_sid.h\n> > HDR trace2/tr2_tls.h\n> > trace2/tr2_tls.h:12:16: error: field ‘thread_name’ has incomplete type\n> > struct strbuf thread_name;\n> > ^~~~~~~~~~~\n> > Makefile:2739: recipe for target 'trace2/tr2_tls.hco' failed\n> > make: *** [trace2/tr2_tls.hco] Error 1\n> > HDR trace2/tr2_tbuf.h\n> 131c143\n> < Makefile:2725: recipe for target 'sha256/gcrypt.hco' failed\n> ---\n> > Makefile:2739: recipe for target 'sha256/gcrypt.hco' failed\n> 164a177\n> > HDR trace2.h\n> $\n> \n> So, quoting the last part of the original patch:\n> \n> diff --git a/trace2/tr2_tls.h b/trace2/tr2_tls.h\n> index 99ea9018ce..bb80e3f8e7 100644\n> --- a/trace2/tr2_tls.h\n> +++ b/trace2/tr2_tls.h\n> @@ -1,6 +1,8 @@\n> #ifndef TR2_TLS_H\n> #define TR2_TLS_H\n> \n> +#include \"strbuf.h\"\n> +\n> /*\n> * Arbitry limit for thread names for column alignment.\n> */\n> \n\nYes, it appears I missed one. I'll add it if I re-roll this.\n(I hate to send a whole new version for one line.)\n\nThanks\nJeff\n"}]}