{"thread":{"id":"50275","subject":"[PATCH 0/1] One more fix related to TEST_GIT_INSTALLED","startedAt":"2019-01-21T15:12:22Z","lastAt":"2019-01-23T11:41:34Z","messageCount":4,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"367238","messageId":"pull.111.git.gitgitgadget@gmail.com","threadId":"50275","inReplyTo":null,"subject":"[PATCH 0/1] One more fix related to TEST_GIT_INSTALLED","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-01-21T15:12:18Z","receivedAt":"2019-01-21T15:12:22Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"This fix should have gone into https://github.com/gitgitgadget/git/pull/73 \n(which was submitted as \nhttps://public-inbox.org/git/pull.73.v2.git.gitgitgadget@gmail.com and was\nintegrated into master via 2488849c7e76 (Merge branch\n'js/test-git-installed', 2018-11-19)). Ben Peart pointed out that I had\nforgotten to include it.\n\nJohannes Schindelin (1):\n tests: explicitly use `test-tool.exe` on Windows\n\n t/test-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 16a465bc018d09e9d7bbbdc5f40a7fb99c21f8ef\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-111%2Fdscho%2Ftest-git-installed-extra-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-111/dscho/test-git-installed-extra-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/111\n-- \ngitgitgadget\n"},{"id":"367239","messageId":"f396aa113ac3c50ca6a2402cedc71a37cdf63504.1548083538.git.gitgitgadget@gmail.com","threadId":"50275","inReplyTo":"pull.111.git.gitgitgadget@gmail.com","subject":"[PATCH 1/1] tests: explicitly use `test-tool.exe` on Windows","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2019-01-21T15:12:19Z","receivedAt":"2019-01-21T15:12:23Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nIn 8abfdf44c882 (tests: explicitly use `git.exe` on Windows,\n2018-11-14), we made sure to use the `.exe` file extension when\nusing an absolute path to `git.exe`, to avoid getting confused with a\nfile or directory in the same place that lacks said file extension.\n\nFor the same reason, we need to handle test-tool.exe the same way.\n\nSigned-off-by: Johannes Schindelin \n---\n t/test-lib.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex a1abb1177a..9876b4bab0 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -1154,7 +1154,7 @@ test -d \"$GIT_BUILD_DIR\"/templates/blt || {\n \terror \"You haven't built things yet, have you?\"\n }\n \n-if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool\n+if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool$X\n then\n \techo >&2 'You need to build test-tool:'\n \techo >&2 'Run \"make t/helper/test-tool\" in the source (toplevel) directory'\n-- \ngitgitgadget\n"},{"id":"367359","messageId":"xmqqpnsoe7av.fsf@gitster-ct.c.googlers.com","threadId":"50275","inReplyTo":"f396aa113ac3c50ca6a2402cedc71a37cdf63504.1548083538.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/1] tests: explicitly use `test-tool.exe` on Windows","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-22T21:00:56Z","receivedAt":"2019-01-22T21:01:01Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> From: Johannes Schindelin \n>\n> In 8abfdf44c882 (tests: explicitly use `git.exe` on Windows,\n> 2018-11-14), we made sure to use the `.exe` file extension when\n> using an absolute path to `git.exe`, to avoid getting confused with a\n> file or directory in the same place that lacks said file extension.\n>\n> For the same reason, we need to handle test-tool.exe the same way.\n>\n> Signed-off-by: Johannes Schindelin \n> ---\n> t/test-lib.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index a1abb1177a..9876b4bab0 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -1154,7 +1154,7 @@ test -d \"$GIT_BUILD_DIR\"/templates/blt || {\n> \terror \"You haven't built things yet, have you?\"\n> }\n> \n> -if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool\n> +if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool$X\n> then\n> \techo >&2 'You need to build test-tool:'\n> \techo >&2 'Run \"make t/helper/test-tool\" in the source (toplevel) directory'\n\nThanks for being thorough. Will queue.\n"},{"id":"367412","messageId":"nycvar.QRO.7.76.6.1901231239470.45@tvgsbejvaqbjf.bet","threadId":"50275","inReplyTo":"xmqqpnsoe7av.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 1/1] tests: explicitly use `test-tool.exe` on Windows","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2019-01-23T11:41:21Z","receivedAt":"2019-01-23T11:41:34Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Tue, 22 Jan 2019, Junio C Hamano wrote:\n\n> \"Johannes Schindelin via GitGitGadget\" \n> writes:\n> \n> > From: Johannes Schindelin \n> >\n> > In 8abfdf44c882 (tests: explicitly use `git.exe` on Windows,\n> > 2018-11-14), we made sure to use the `.exe` file extension when\n> > using an absolute path to `git.exe`, to avoid getting confused with a\n> > file or directory in the same place that lacks said file extension.\n> >\n> > For the same reason, we need to handle test-tool.exe the same way.\n> >\n> > Signed-off-by: Johannes Schindelin \n> > ---\n> > t/test-lib.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/t/test-lib.sh b/t/test-lib.sh\n> > index a1abb1177a..9876b4bab0 100644\n> > --- a/t/test-lib.sh\n> > +++ b/t/test-lib.sh\n> > @@ -1154,7 +1154,7 @@ test -d \"$GIT_BUILD_DIR\"/templates/blt || {\n> > \terror \"You haven't built things yet, have you?\"\n> > }\n> > \n> > -if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool\n> > +if ! test -x \"$GIT_BUILD_DIR\"/t/helper/test-tool$X\n> > then\n> > \techo >&2 'You need to build test-tool:'\n> > \techo >&2 'Run \"make t/helper/test-tool\" in the source (toplevel) directory'\n> \n> Thanks for being thorough. Will queue.\n\nThank you for the praise. In this instance, I do not deserve it, though,\nas it was the MSVC patch series (which I hope to send the mailing list's\nway soon) that identified this problem. And it was Ben's bug report\n(privately, as we're team mates) that pointed out that I forgot this in\nthe original patch series.\n\nCiao,\nDscho\n"}]}