{"thread":{"id":"50214","subject":"[PATCH] sequencer: mark file local symbols as static","startedAt":"2019-01-13T20:58:09Z","lastAt":"2019-01-13T20:58:09Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"366636","messageId":"5440ddf5-0b80-3d00-7daf-133a8611efa8@ramsayjones.plus.com","threadId":"50214","inReplyTo":null,"subject":"[PATCH] sequencer: mark file local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2019-01-13T20:58:05Z","receivedAt":"2019-01-13T20:58:09Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Alban,\n\nIf you need to re-roll your 'ag/sequencer-reduce-rewriting-todo' branch,\ncould you please squash this into the relevant patch [commit 45f215c912\n(\"rebase-interactive: use todo_list_write_to_file() in edit_todo_list()\",\n2018-12-29)].\n\nI believe this commit removes the final calls to write_message() outside\nof sequencer.c, so that this is now a file-local symbol.\n\nThanks!\n\n[another patch for this branch is just coming up ...]\n\nATB,\nRamsay Jones\n\n sequencer.c | 4 ++--\n sequencer.h | 3 ---\n 2 files changed, 2 insertions(+), 5 deletions(-)\n\ndiff --git a/sequencer.c b/sequencer.c\nindex 60beeacdeb..64753af68e 100644\n--- a/sequencer.c\n+++ b/sequencer.c\n@@ -383,8 +383,8 @@ static void print_advice(struct repository *r, int show_hint,\n \t}\n }\n \n-int write_message(const void *buf, size_t len, const char *filename,\n-\t\t  int append_eol)\n+static int write_message(const void *buf, size_t len, const char *filename,\n+\t\t\t int append_eol)\n {\n \tstruct lock_file msg_file = LOCK_INIT;\n \ndiff --git a/sequencer.h b/sequencer.h\nindex 33a6070c64..0ccbe390b2 100644\n--- a/sequencer.h\n+++ b/sequencer.h\n@@ -67,9 +67,6 @@ struct replay_opts {\n };\n #define REPLAY_OPTS_INIT { .action = -1, .current_fixups = STRBUF_INIT }\n \n-int write_message(const void *buf, size_t len, const char *filename,\n-\t\t  int append_eol);\n-\n /*\n  * Note that ordering matters in this enum. Not only must it match the mapping\n  * of todo_command_info (in sequencer.c), it is also divided into several\n-- \n2.20.0\n"}]}