{"thread":{"id":"50211","subject":"[PATCH] fetch: fix extensions.partialclone name in error message","startedAt":"2019-01-13T08:52:43Z","lastAt":"2019-01-13T09:02:50Z","messageCount":2,"participants":["Christian Couder","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"366630","messageId":"20190113085219.22993-1-chriscool@tuxfamily.org","threadId":"50211","inReplyTo":null,"subject":"[PATCH] fetch: fix extensions.partialclone name in error message","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2019-01-13T08:52:19Z","receivedAt":"2019-01-13T08:52:43Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"There is \"extensions.partialclone\" and \"core.partialCloneFilter\", but\nnot \"core.partialclone\". Only \"extensions.partialclone\" is meant to\ncontain a remote name.\n\nWhile at it, let's wrap the relevant code lines to keep them at a\nreasonable lenght.\n\nSigned-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n builtin/fetch.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex e0140327aa..c0ade48f5d 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -1478,7 +1478,8 @@ static inline void fetch_one_setup_partial(struct remote *remote)\n \t */\n \tif (strcmp(remote->name, repository_format_partial_clone)) {\n \t\tif (filter_options.choice)\n-\t\t\tdie(_(\"--filter can only be used with the remote configured in core.partialClone\"));\n+\t\t\tdie(_(\"--filter can only be used with the remote \"\n+\t\t\t      \"configured in extensions.partialclone\"));\n \t\treturn;\n \t}\n \n@@ -1646,7 +1647,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)\n \t\tresult = fetch_one(remote, argc, argv, prune_tags_ok);\n \t} else {\n \t\tif (filter_options.choice)\n-\t\t\tdie(_(\"--filter can only be used with the remote configured in core.partialClone\"));\n+\t\t\tdie(_(\"--filter can only be used with the remote \"\n+\t\t\t      \"configured in extensions.partialclone\"));\n \t\t/* TODO should this also die if we have a previous partial-clone? */\n \t\tresult = fetch_multiple(&list);\n \t}\n-- \n2.20.1.122.g9a13c7f8ea.dirty\n\n"},{"id":"366631","messageId":"CAPig+cQ+Wjif5R4gxXCcOO7ctwU-m190E6q5xi8tWLpC6JJgfA@mail.gmail.com","threadId":"50211","inReplyTo":"20190113085219.22993-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] fetch: fix extensions.partialclone name in error message","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2019-01-13T09:02:36Z","receivedAt":"2019-01-13T09:02:50Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Jan 13, 2019 at 3:52 AM Christian Couder\n<christian.couder@gmail.com> wrote:\n> There is \"extensions.partialclone\" and \"core.partialCloneFilter\", but\n> not \"core.partialclone\". Only \"extensions.partialclone\" is meant to\n> contain a remote name.\n>\n> While at it, let's wrap the relevant code lines to keep them at a\n> reasonable lenght.\n\ns/lenght/length/\n\n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n"}]}