{"thread":{"id":"50209","subject":"git blame --reverse reports on lines that were not asked for","startedAt":"2019-01-13T07:07:09Z","lastAt":"2019-01-13T07:07:09Z","messageCount":1,"participants":["Julia Lawall"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"366628","messageId":"alpine.DEB.2.21.1901130758180.4448@hadrien","threadId":"50209","inReplyTo":null,"subject":"git blame --reverse reports on lines that were not asked for","fromName":"Julia Lawall","fromEmail":"julia.lawall@lip6.fr","sentAt":"2019-01-13T07:07:04Z","receivedAt":"2019-01-13T07:07:09Z","isPatch":false,"sender":{"key":"julia.lawall@lip6.fr","avatar":null},"body":"Version: git version 2.17.1, git version 2.20.1\n\nGit tree:\nhttps://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable\n7566ec393f4161572ba6f11ad5171fd5d59b0fbd\n\nThe command git blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1176,1176 -L1173,1173 arch/mips/kvm/emulate.c\n\nProduces:\n\n693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();\n693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1174)                                     /* Blow away the shadow host TLBs */\n\nLine 1174 was not asked for, and there is no information about line 1176.\n\ngit blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1173,1173 -L1175,1175 arch/mips/kvm/emulate.c works fine:\n\n693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();\nf3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1175)                                     kvm_mips_flush_host_tlb(1);\n\ngit blame --reverse 91e4f1b6073dd680d86cdb7e42d7cccca9db39d8..HEAD -L1173,1176 arch/mips/kvm/emulate.c also works fine:\n\n693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1173)                                     preempt_disable();\nf3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1174)                                     /* Blow away the shadow host TLBs */\nf3124cc551c85 (James Hogan  2016-09-16 00:00:08 +0100 1175)                                     kvm_mips_flush_host_tlb(1);\n693dfd5a3f19e (Erez Shitrit 2017-04-27 17:01:34 +0300 1176)                                     cpu = smp_processor_id();\n\nMy impression is that git --reverse blame is not all that reliable, and we can even see that 1174 gets assigned to two different commits depending on how the command is formulated.  But I would expect it to at least report on only and exactly the lines that were asked for.\n\nthanks,\njulia\n"}]}