{"thread":{"id":"50164","subject":"[PATCH] helper/test-ref-store: fix \"new-sha1\" vs \"old-sha1\" typo","startedAt":"2019-01-06T15:47:02Z","lastAt":"2019-01-17T18:54:03Z","messageCount":4,"participants":["Christian Couder","Duy Nguyen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"366207","messageId":"20190106154637.10815-1-chriscool@tuxfamily.org","threadId":"50164","inReplyTo":null,"subject":"[PATCH] helper/test-ref-store: fix \"new-sha1\" vs \"old-sha1\" typo","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2019-01-06T15:46:37Z","receivedAt":"2019-01-06T15:47:02Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"It looks like it is a copy-paste error made in 80f2a6097c\n(t/helper: add test-ref-store to test ref-store functions,\n2017-03-26) to pass \"old-sha1\" instead of \"new-sha1\" to\nnotnull() when we get the new sha1 argument from\nconst char **argv.\n\nSigned-off-by: Christian Couder \n---\n t/helper/test-ref-store.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c\nindex e9e0541276..799fc00aa1 100644\n--- a/t/helper/test-ref-store.c\n+++ b/t/helper/test-ref-store.c\n@@ -233,7 +233,7 @@ static int cmd_update_ref(struct ref_store *refs, const char **argv)\n {\n \tconst char *msg = notnull(*argv++, \"msg\");\n \tconst char *refname = notnull(*argv++, \"refname\");\n-\tconst char *new_sha1_buf = notnull(*argv++, \"old-sha1\");\n+\tconst char *new_sha1_buf = notnull(*argv++, \"new-sha1\");\n \tconst char *old_sha1_buf = notnull(*argv++, \"old-sha1\");\n \tunsigned int flags = arg_flags(*argv++, \"flags\");\n \tstruct object_id old_oid;\n-- \n2.20.1.26.gc246996f60\n\n"},{"id":"366252","messageId":"CACsJy8B7ogYEzwDAT7v1z4T-YsTa-e3VPbCfNBmc4v5R=06meA@mail.gmail.com","threadId":"50164","inReplyTo":"20190106154637.10815-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] helper/test-ref-store: fix \"new-sha1\" vs \"old-sha1\" typo","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2019-01-07T12:53:11Z","receivedAt":"2019-01-07T12:53:41Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, Jan 6, 2019 at 10:46 PM Christian Couder\n wrote:\n>\n> It looks like it is a copy-paste error made in 80f2a6097c\n> (t/helper: add test-ref-store to test ref-store functions,\n> 2017-03-26) to pass \"old-sha1\" instead of \"new-sha1\" to\n> notnull() when we get the new sha1 argument from\n> const char **argv.\n\nAck. Definitely copy-paste error.\n\n>\n> Signed-off-by: Christian Couder \n> ---\n> t/helper/test-ref-store.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c\n> index e9e0541276..799fc00aa1 100644\n> --- a/t/helper/test-ref-store.c\n> +++ b/t/helper/test-ref-store.c\n> @@ -233,7 +233,7 @@ static int cmd_update_ref(struct ref_store *refs, const char **argv)\n> {\n> const char *msg = notnull(*argv++, \"msg\");\n> const char *refname = notnull(*argv++, \"refname\");\n> - const char *new_sha1_buf = notnull(*argv++, \"old-sha1\");\n> + const char *new_sha1_buf = notnull(*argv++, \"new-sha1\");\n> const char *old_sha1_buf = notnull(*argv++, \"old-sha1\");\n> unsigned int flags = arg_flags(*argv++, \"flags\");\n> struct object_id old_oid;\n> --\n> 2.20.1.26.gc246996f60\n>\n\n\n-- \nDuy\n"},{"id":"366814","messageId":"CAP8UFD2vLhn1_hUefKfsE8+3SDZk6qzf8eS-DUoZLhf41QiyAg@mail.gmail.com","threadId":"50164","inReplyTo":"CACsJy8B7ogYEzwDAT7v1z4T-YsTa-e3VPbCfNBmc4v5R=06meA@mail.gmail.com","subject":"Re: [PATCH] helper/test-ref-store: fix \"new-sha1\" vs \"old-sha1\" typo","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2019-01-16T11:13:10Z","receivedAt":"2019-01-16T11:13:25Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Jan 7, 2019 at 1:53 PM Duy Nguyen wrote:\n>\n> On Sun, Jan 6, 2019 at 10:46 PM Christian Couder\n> wrote:\n> >\n> > It looks like it is a copy-paste error made in 80f2a6097c\n> > (t/helper: add test-ref-store to test ref-store functions,\n> > 2017-03-26) to pass \"old-sha1\" instead of \"new-sha1\" to\n> > notnull() when we get the new sha1 argument from\n> > const char **argv.\n>\n> Ack. Definitely copy-paste error.\n\nThanks for confirming.\n\nJunio, it looks like the patch has fallen through the cracks.\n\nOr maybe I should rework the commit message?\n"},{"id":"367011","messageId":"xmqqa7jznmig.fsf@gitster-ct.c.googlers.com","threadId":"50164","inReplyTo":"CAP8UFD2vLhn1_hUefKfsE8+3SDZk6qzf8eS-DUoZLhf41QiyAg@mail.gmail.com","subject":"Re: [PATCH] helper/test-ref-store: fix \"new-sha1\" vs \"old-sha1\" typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2019-01-17T18:53:59Z","receivedAt":"2019-01-17T18:54:03Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder writes:\n\n> On Mon, Jan 7, 2019 at 1:53 PM Duy Nguyen wrote:\n>>\n>> On Sun, Jan 6, 2019 at 10:46 PM Christian Couder\n>> wrote:\n>> >\n>> > It looks like it is a copy-paste error made in 80f2a6097c\n>> > (t/helper: add test-ref-store to test ref-store functions,\n>> > 2017-03-26) to pass \"old-sha1\" instead of \"new-sha1\" to\n>> > notnull() when we get the new sha1 argument from\n>> > const char **argv.\n>>\n>> Ack. Definitely copy-paste error.\n>\n> Thanks for confirming.\n>\n> Junio, it looks like the patch has fallen through the cracks.\n\nIndeed. I did notice two smallish cleanups from you but did not\nspot this one.\n\nWill take a look and queue.\n\nThanks.\n\n\n>\n> Or maybe I should rework the commit message?\n\n"}]}