{"thread":{"id":"50121","subject":"[PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.","startedAt":"2018-12-27T22:40:28Z","lastAt":"2018-12-28T20:03:51Z","messageCount":3,"participants":["randall.s.becker@rogers.com","Eric Sunshine","Randall S. Becker"],"isPatch":true,"patchVersion":3,"patchTotal":4},"messages":[{"id":"365887","messageId":"20181227223856.18768-1-randall.s.becker@rogers.com","threadId":"50121","inReplyTo":null,"subject":"[PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.","fromName":"","fromEmail":"randall.s.becker@rogers.com","sentAt":"2018-12-27T22:38:56Z","receivedAt":"2018-12-27T22:40:28Z","isPatch":true,"sender":{"key":"randall.s.becker@rogers.com","avatar":null},"body":"From: \"Randall S. Becker\" <rsbecker@nexbridge.com>\n\nA number of configuration options are not automatically detected by\nconfigure mechanisms, including the location of Perl and Python.\n\nThere was a problem at a specific set of operating system versions\nthat caused getopt to have compile errors. Account for this by\nproviding emulation defines for those versions.\n\nSigned-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n---\n config.mak.uname | 34 +++++++++++++++++++++++++++++-----\n 1 file changed, 29 insertions(+), 5 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 3ee7da0e23..aa4432ac2f 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -441,26 +441,45 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \t# INLINE='' would just replace one set of warnings with another and\n \t# still not compile in c89 mode, due to non-const array initializations.\n \tCC = cc -c99\n+\t# Build down-rev compatible objects that don't use our new getopt_long.\n+\tifeq ($(uname_R).$(uname_V),J06.21)\n+\t\tCC += -WRVU=J06.20\n+\tendif\n+\tifeq ($(uname_R).$(uname_V),L17.02)\n+\t\tCC += -WRVU=L16.05\n+\tendif\n+\n \t# Disable all optimization, seems to result in bad code, with -O or -O2\n \t# or even -O1 (default), /usr/local/libexec/git-core/git-pack-objects\n \t# abends on \"git push\". Needs more investigation.\n-\tCFLAGS = -g -O0\n+\tCFLAGS = -g -O0 -Winline\n \t# We'd want it to be here.\n \tprefix = /usr/local\n- \t# Our's are in ${prefix}/bin (perl might also be in /usr/bin/perl).\n+\t# perl and python must be in /usr/bin on NonStop - supplied by HPE\n+\t# with operating system in that managed directory.\n-\tPERL_PATH = ${prefix}/bin/perl\n-\tPYTHON_PATH = ${prefix}/bin/python\n-\n+\tPERL_PATH = /usr/bin/perl\n+\tPYTHON_PATH = /usr/bin/python\n+\t# The current /usr/coreutils/rm at lowest support level does not work\n+\t# with the git test structure. Long paths cause nftw as in\n+\t# 'trash directory...' cause rm to terminate prematurely without fully\n+\t# removing the directory at OS releases J06.21 and L17.02.\n+\t# Default to the older rm until those two releases are deprecated.\n+\tRM = /bin/rm -f\n \t# As detected by './configure'.\n \t# Missdetected, hence commented out, see below.\n \t#NO_CURL = YesPlease\n \t# Added manually, see above.\n+\tNEEDS_SSL_WITH_CURL = YesPlease\n+\tNEEDS_CRYPTO_WITH_SSL = YesPlease\n+\tHAVE_DEV_TTY = YesPlease\n \tHAVE_LIBCHARSET_H = YesPlease\n \tHAVE_STRINGS_H = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n \tNEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n \tNO_SYS_SELECT_H = UnfortunatelyYes\n \tNO_D_TYPE_IN_DIRENT = YesPlease\n+\tNO_GETTEXT = YesPlease\n \tNO_HSTRERROR = YesPlease\n \tNO_STRCASESTR = YesPlease\n \tNO_MEMMEM = YesPlease\n@@ -470,8 +489,13 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tNO_MKDTEMP = YesPlease\n \t# Currently libiconv-1.9.1.\n \tOLD_ICONV = UnfortunatelyYes\n-\tNO_REGEX = YesPlease\n+\tNO_REGEX=NeedsStartEnd\n \tNO_PTHREADS = UnfortunatelyYes\n\n \t# Not detected (nor checked for) by './configure'.\n \t# We don't have SA_RESTART on NonStop, unfortunalety.\n-- \n2.17.0.10.gb132f7033\n\n"},{"id":"365911","messageId":"CAPig+cTjn4je8dOANs-xHhU_NYRw-Twm22HSnSLNXTkDB-qRYw@mail.gmail.com","threadId":"50121","inReplyTo":"20181227223856.18768-1-randall.s.becker@rogers.com","subject":"Re: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-12-28T19:42:50Z","receivedAt":"2018-12-28T19:43:04Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Dec 27, 2018 at 5:39 PM <randall.s.becker@rogers.com> wrote:\n> A number of configuration options are not automatically detected by\n> configure mechanisms, including the location of Perl and Python.\n>\n> There was a problem at a specific set of operating system versions\n> that caused getopt to have compile errors. Account for this by\n> providing emulation defines for those versions.\n\nThis version of the patch looks much better and addresses my comments\non previous attempts. One note below...\n\n> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n> ---\n> diff --git a/config.mak.uname b/config.mak.uname\n> @@ -441,26 +441,45 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> +       # The current /usr/coreutils/rm at lowest support level does not work\n> +       # with the git test structure. Long paths cause nftw as in\n> +       # 'trash directory...' cause rm to terminate prematurely without fully\n> +       # removing the directory at OS releases J06.21 and L17.02.\n> +       # Default to the older rm until those two releases are deprecated.\n> +       RM = /bin/rm -f\n\nThanks, this comment does a much better job of explaining the actual\nproblem and selling the solution.\n\nThere is a slight grammatical problem:\n\n    Long paths _cause_ ... _cause_ rm to terminate...\n\nwhich might deserve fixing.\n"},{"id":"365917","messageId":"000c01d49ee8$6ea2a0a0$4be7e1e0$@nexbridge.com","threadId":"50121","inReplyTo":"CAPig+cTjn4je8dOANs-xHhU_NYRw-Twm22HSnSLNXTkDB-qRYw@mail.gmail.com","subject":"RE: [PATCH v3 2/4] config.mak.uname: support for modern HPE NonStop config.","fromName":"Randall S. Becker","fromEmail":"rsbecker@nexbridge.com","sentAt":"2018-12-28T20:03:36Z","receivedAt":"2018-12-28T20:03:51Z","isPatch":true,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On December 28, 2018 14:43, Eric Sunshine wrote:\n> On Thu, Dec 27, 2018 at 5:39 PM <randall.s.becker@rogers.com> wrote:\n> > A number of configuration options are not automatically detected by\n> > configure mechanisms, including the location of Perl and Python.\n> >\n> > There was a problem at a specific set of operating system versions\n> > that caused getopt to have compile errors. Account for this by\n> > providing emulation defines for those versions.\n> \n> This version of the patch looks much better and addresses my comments on\n> previous attempts. One note below...\n> \n> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>\n> > ---\n> > diff --git a/config.mak.uname b/config.mak.uname @@ -441,26 +441,45\n> @@\n> > ifeq ($(uname_S),NONSTOP_KERNEL)\n> > +       # The current /usr/coreutils/rm at lowest support level does not work\n> > +       # with the git test structure. Long paths cause nftw as in\n> > +       # 'trash directory...' cause rm to terminate prematurely without fully\n> > +       # removing the directory at OS releases J06.21 and L17.02.\n> > +       # Default to the older rm until those two releases are deprecated.\n> > +       RM = /bin/rm -f\n> \n> Thanks, this comment does a much better job of explaining the actual\n> problem and selling the solution.\n> \n> There is a slight grammatical problem:\n> \n>     Long paths _cause_ ... _cause_ rm to terminate...\n> \n> which might deserve fixing.\n\nRerolled. Thanks.\n\n"}]}