{"thread":{"id":"50118","subject":"[PATCH v2 2/4] config.mak.uname: support for modern HPE NonStop config.","startedAt":"2018-12-27T18:36:20Z","lastAt":"2018-12-27T20:03:22Z","messageCount":2,"participants":["randall.s.becker@rogers.com","Eric Sunshine"],"isPatch":true,"patchVersion":2,"patchTotal":4},"messages":[{"id":"365875","messageId":"20181227183513.2860-1-randall.s.becker@rogers.com","threadId":"50118","inReplyTo":null,"subject":"[PATCH v2 2/4] config.mak.uname: support for modern HPE NonStop config.","fromName":"","fromEmail":"randall.s.becker@rogers.com","sentAt":"2018-12-27T18:35:13Z","receivedAt":"2018-12-27T18:36:20Z","isPatch":true,"sender":{"key":"randall.s.becker@rogers.com","avatar":null},"body":"From: \"Randall S. Becker\" \n\nA number of configuration options are not automatically detected by\nconfigure mechanisms, including the location of Perl and Python.\n\nThere was a problem at a specific set of operating system versions\nthat caused getopt to have compile errors. Accounted for this by\nproviding emulation defines for those versions.\n\nSigned-off-by: Randall S. Becker \n---\n config.mak.uname | 34 +++++++++++++++++++++++++++++-----\n 1 file changed, 29 insertions(+), 5 deletions(-)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 3ee7da0e23..aa4432ac2f 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -441,26 +441,45 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \t# INLINE='' would just replace one set of warnings with another and\n \t# still not compile in c89 mode, due to non-const array initializations.\n \tCC = cc -c99\n+\t# Build down-rev compatible objects that don't use our new getopt_long.\n+\tifeq ($(uname_R).$(uname_V),J06.21)\n+\t\tCC += -WRVU=J06.20\n+\tendif\n+\tifeq ($(uname_R).$(uname_V),L17.02)\n+\t\tCC += -WRVU=L16.05\n+\tendif\n+\n \t# Disable all optimization, seems to result in bad code, with -O or -O2\n \t# or even -O1 (default), /usr/local/libexec/git-core/git-pack-objects\n \t# abends on \"git push\". Needs more investigation.\n-\tCFLAGS = -g -O0\n+\tCFLAGS = -g -O0 -Winline\n \t# We'd want it to be here.\n \tprefix = /usr/local\n \t# Our's are in ${prefix}/bin (perl might also be in /usr/bin/perl).\n-\tPERL_PATH = ${prefix}/bin/perl\n-\tPYTHON_PATH = ${prefix}/bin/python\n-\n+\tPERL_PATH = /usr/bin/perl\n+\tPYTHON_PATH = /usr/bin/python\n+\t# The current /usr/coreutils/rm at lowest support level does not work\n+\t# with the git test structure. Long paths cause nftw as in\n+\t# 'trash directory...' break at OS releases J06.21 and L17.02.\n+\t# Default to the older rm until those two releases are deprecated.\n+\tRM = /bin/rm -f\n \t# As detected by './configure'.\n \t# Missdetected, hence commented out, see below.\n \t#NO_CURL = YesPlease\n \t# Added manually, see above.\n+\tNEEDS_SSL_WITH_CURL = YesPlease\n+\tNEEDS_CRYPTO_WITH_SSL = YesPlease\n+\tHAVE_DEV_TTY = YesPlease\n \tHAVE_LIBCHARSET_H = YesPlease\n \tHAVE_STRINGS_H = YesPlease\n \tNEEDS_LIBICONV = YesPlease\n \tNEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease\n \tNO_SYS_SELECT_H = UnfortunatelyYes\n \tNO_D_TYPE_IN_DIRENT = YesPlease\n+\tNO_GETTEXT = YesPlease\n \tNO_HSTRERROR = YesPlease\n \tNO_STRCASESTR = YesPlease\n \tNO_MEMMEM = YesPlease\n@@ -470,8 +489,13 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n \tNO_MKDTEMP = YesPlease\n \t# Currently libiconv-1.9.1.\n \tOLD_ICONV = UnfortunatelyYes\n-\tNO_REGEX = YesPlease\n+\tNO_REGEX=NeedsStartEnd\n \tNO_PTHREADS = UnfortunatelyYes\n\n \t# Not detected (nor checked for) by './configure'.\n \t# We don't have SA_RESTART on NonStop, unfortunalety.\n-- \n2.17.0.10.gb132f7033\n\n"},{"id":"365880","messageId":"CAPig+cSv6CiP0gzdnJgK8jHqibEPoUneUXoO0p9q0fHsvBDj7Q@mail.gmail.com","threadId":"50118","inReplyTo":"20181227183513.2860-1-randall.s.becker@rogers.com","subject":"Re: [PATCH v2 2/4] config.mak.uname: support for modern HPE NonStop config.","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-12-27T20:03:08Z","receivedAt":"2018-12-27T20:03:22Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Dec 27, 2018 at 1:35 PM wrote:\n> A number of configuration options are not automatically detected by\n> configure mechanisms, including the location of Perl and Python.\n>\n> There was a problem at a specific set of operating system versions\n> that caused getopt to have compile errors. Accounted for this by\n\ns/Accounted/Account/\n\n> providing emulation defines for those versions.\n>\n> Signed-off-by: Randall S. Becker \n> ---\n> diff --git a/config.mak.uname b/config.mak.uname\n> @@ -441,26 +441,45 @@ ifeq ($(uname_S),NONSTOP_KERNEL)\n> # Our's are in ${prefix}/bin (perl might also be in /usr/bin/perl).\n> - PERL_PATH = ${prefix}/bin/perl\n> - PYTHON_PATH = ${prefix}/bin/python\n> + PERL_PATH = /usr/bin/perl\n> + PYTHON_PATH = /usr/bin/python\n\nReferring to your answer[1] to my question about ${prefix}, should the\ncomment above these lines, which talks about ${prefix}, be removed by\nthis patch?\n\n[1]: https://public-inbox.org/git/000601d49e0b$e11d7520$a3585f60$@rogers.com/\n\n> + # The current /usr/coreutils/rm at lowest support level does not work\n> + # with the git test structure. Long paths cause nftw as in\n> + # 'trash directory...' break at OS releases J06.21 and L17.02.\n\n\"break\" in what fashion? What is the actual incorrect behavior?\n\nI'm not asking for my own edification particularly, but rather to help\nthe person who comes after you supporting this platform. That person\nwill need to understand the exact nature of the problem in order to\ndetermine if this work-around is still needed or if it can be retired\nor somehow conditionalized. Stated another way, the reason behind this\nchange still seems like a black-box, mysterious and under-explained.\nThere is nothing concrete here upon which to grasp to gain an\nunderstanding of the problem.\n\n> + # Default to the older rm until those two releases are deprecated.\n> + RM = /bin/rm -f\n"}]}