{"thread":{"id":"50112","subject":"[PATCH] Specify -Wformat along with -Wformat-security","startedAt":"2018-12-27T06:59:09Z","lastAt":"2018-12-27T18:46:49Z","messageCount":3,"participants":["Masaya Suzuki","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"365833","messageId":"20181227065855.68632-1-masayasuzuki@google.com","threadId":"50112","inReplyTo":null,"subject":"[PATCH] Specify -Wformat along with -Wformat-security","fromName":"Masaya Suzuki","fromEmail":"masayasuzuki@google.com","sentAt":"2018-12-27T06:58:55Z","receivedAt":"2018-12-27T06:59:09Z","isPatch":true,"sender":{"key":"masayasuzuki@google.com","avatar":"https://avatars.githubusercontent.com/u/21878?v=4"},"body":"Without -Wformat, -Wformat-security won't work.\n\n> cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]\n\nSigned-off-by: Masaya Suzuki <masayasuzuki@google.com>\n---\n config.mak.dev | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.dev b/config.mak.dev\nindex bbeeff44f..aae9db67d 100644\n--- a/config.mak.dev\n+++ b/config.mak.dev\n@@ -7,6 +7,7 @@ CFLAGS += -pedantic\n CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0\n endif\n CFLAGS += -Wdeclaration-after-statement\n+CFLAGS += -Wformat\n CFLAGS += -Wformat-security\n CFLAGS += -Wno-format-zero-length\n CFLAGS += -Wold-style-definition\n-- \n2.20.1.415.g653613c723-goog\n\n"},{"id":"365876","messageId":"CACsJy8CM=H1njP3ZzuReS0u_YRPTS6pGhFWWMBHoaKVNBYiXXA@mail.gmail.com","threadId":"50112","inReplyTo":"20181227065855.68632-1-masayasuzuki@google.com","subject":"Re: [PATCH] Specify -Wformat along with -Wformat-security","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-12-27T18:35:48Z","receivedAt":"2018-12-27T18:36:20Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki <masayasuzuki@google.com> wrote:\n>\n> Without -Wformat, -Wformat-security won't work.\n>\n> > cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]\n\nCompiler name and version?\n\n>\n> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>\n> ---\n>  config.mak.dev | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.dev b/config.mak.dev\n> index bbeeff44f..aae9db67d 100644\n> --- a/config.mak.dev\n> +++ b/config.mak.dev\n> @@ -7,6 +7,7 @@ CFLAGS += -pedantic\n>  CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0\n>  endif\n>  CFLAGS += -Wdeclaration-after-statement\n> +CFLAGS += -Wformat\n>  CFLAGS += -Wformat-security\n>  CFLAGS += -Wno-format-zero-length\n>  CFLAGS += -Wold-style-definition\n> --\n> 2.20.1.415.g653613c723-goog\n>\n\n\n-- \nDuy\n"},{"id":"365877","messageId":"CAJB1erVmZQd_kLU1fqL7cURrEUz2EJ4Br0kgVQt7T-mk3s95dQ@mail.gmail.com","threadId":"50112","inReplyTo":"CACsJy8CM=H1njP3ZzuReS0u_YRPTS6pGhFWWMBHoaKVNBYiXXA@mail.gmail.com","subject":"Re: [PATCH] Specify -Wformat along with -Wformat-security","fromName":"Masaya Suzuki","fromEmail":"masayasuzuki@google.com","sentAt":"2018-12-27T18:46:34Z","receivedAt":"2018-12-27T18:46:49Z","isPatch":true,"sender":{"key":"masayasuzuki@google.com","avatar":"https://avatars.githubusercontent.com/u/21878?v=4"},"body":"On Thu, Dec 27, 2018 at 10:36 AM Duy Nguyen <pclouds@gmail.com> wrote:\n>\n> On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki <masayasuzuki@google.com> wrote:\n> >\n> > Without -Wformat, -Wformat-security won't work.\n> >\n> > > cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]\n>\n> Compiler name and version?\n\nI'm not familar with the tools, so please be patient.\n\nAccording to Makefile, `CC = cc`. With `cc --version`, it says:\n\ncc (Debian 7.3.0-5) 7.3.0\nCopyright (C) 2017 Free Software Foundation, Inc.\nThis is free software; see the source for copying conditions.  There is NO\nwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n\nJonathan said there was the same patch. Looks like\nhttps://public-inbox.org/git/20181012184037.15076-1-t.gummerer@gmail.com/.\nI'll check my config again.\n"}]}