{"thread":{"id":"50039","subject":"[PATCH] doc: improve grammar in git-update-index","startedAt":"2018-12-14T21:39:45Z","lastAt":"2018-12-26T18:12:22Z","messageCount":4,"participants":["Anthony Sottile","Philip Oakley","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"365383","messageId":"20181214212504.3164-1-asottile@umich.edu","threadId":"50039","inReplyTo":null,"subject":"[PATCH] doc: improve grammar in git-update-index","fromName":"Anthony Sottile","fromEmail":"asottile@umich.edu","sentAt":"2018-12-14T21:25:04Z","receivedAt":"2018-12-14T21:39:45Z","isPatch":true,"sender":{"key":"asottile@umich.edu","avatar":"https://avatars.githubusercontent.com/u/1810591?v=4"},"body":"Signed-off-by: Anthony Sottile \n---\n Documentation/git-update-index.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\nindex 1c4d146a4..9c03ca167 100644\n--- a/Documentation/git-update-index.txt\n+++ b/Documentation/git-update-index.txt\n@@ -326,7 +326,7 @@ inefficient `lstat(2)`. If your filesystem is one of them, you\n can set \"assume unchanged\" bit to paths you have not changed to\n cause Git not to do this check. Note that setting this bit on a\n path does not mean Git will check the contents of the file to\n-see if it has changed -- it makes Git to omit any checking and\n+see if it has changed -- it means Git will skip any checking and\n assume it has *not* changed. When you make changes to working\n tree files, you have to explicitly tell Git about it by dropping\n \"assume unchanged\" bit, either before or after you modify them.\n-- \n2.17.1\n\n"},{"id":"365434","messageId":"bfe22381-864a-4a6b-8dd9-78e268e52c36@iee.org","threadId":"50039","inReplyTo":"20181214212504.3164-1-asottile@umich.edu","subject":"Re: [PATCH] doc: improve grammar in git-update-index","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.org","sentAt":"2018-12-15T17:06:54Z","receivedAt":"2018-12-15T17:18:03Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 14/12/2018 21:25, Anthony Sottile wrote:\n> Signed-off-by: Anthony Sottile \n> ---\n> Documentation/git-update-index.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n> index 1c4d146a4..9c03ca167 100644\n> --- a/Documentation/git-update-index.txt\n> +++ b/Documentation/git-update-index.txt\n> @@ -326,7 +326,7 @@ inefficient `lstat(2)`. If your filesystem is one of them, you\n> can set \"assume unchanged\" bit to paths you have not changed to\n> cause Git not to do this check. Note that setting this bit on a\n> path does not mean Git will check the contents of the file to\n> -see if it has changed -- it makes Git to omit any checking and\n> +see if it has changed -- it means Git will skip any checking and\n> assume it has *not* changed. When you make changes to working\n> tree files, you have to explicitly tell Git about it by dropping\n> \"assume unchanged\" bit, either before or after you modify them.\n\nDoesn't this also need the caveat that it is _a promise by the user_ \nthat they will not change the file, such that Git doesn't need to keep \nchecking, and that occasionally Git will check, or may perform \nunexpected actions if the user has the wrong mental model.\n\n-- \n\nPhilip\n\n\n"},{"id":"365439","messageId":"CA+dzEBnDGt-yUtExX+ExNPbDeNTuJ+G1D62uwmfOA6MOic0NHw@mail.gmail.com","threadId":"50039","inReplyTo":"bfe22381-864a-4a6b-8dd9-78e268e52c36@iee.org","subject":"Re: [PATCH] doc: improve grammar in git-update-index","fromName":"Anthony Sottile","fromEmail":"asottile@umich.edu","sentAt":"2018-12-16T00:21:34Z","receivedAt":"2018-12-16T00:21:44Z","isPatch":true,"sender":{"key":"asottile@umich.edu","avatar":"https://avatars.githubusercontent.com/u/1810591?v=4"},"body":"On Sat, Dec 15, 2018 at 9:18 AM Philip Oakley wrote:\n>\n> On 14/12/2018 21:25, Anthony Sottile wrote:\n> > Signed-off-by: Anthony Sottile \n> > ---\n> > Documentation/git-update-index.txt | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n> > index 1c4d146a4..9c03ca167 100644\n> > --- a/Documentation/git-update-index.txt\n> > +++ b/Documentation/git-update-index.txt\n> > @@ -326,7 +326,7 @@ inefficient `lstat(2)`. If your filesystem is one of them, you\n> > can set \"assume unchanged\" bit to paths you have not changed to\n> > cause Git not to do this check. Note that setting this bit on a\n> > path does not mean Git will check the contents of the file to\n> > -see if it has changed -- it makes Git to omit any checking and\n> > +see if it has changed -- it means Git will skip any checking and\n> > assume it has *not* changed. When you make changes to working\n> > tree files, you have to explicitly tell Git about it by dropping\n> > \"assume unchanged\" bit, either before or after you modify them.\n>\n> Doesn't this also need the caveat that it is _a promise by the user_\n> that they will not change the file, such that Git doesn't need to keep\n> checking, and that occasionally Git will check, or may perform\n> unexpected actions if the user has the wrong mental model.\n>\n> --\n>\n> Philip\n>\n>\n\nyep, the rest of the documentation in this file explains that in\ndetail -- I'm just fixing up a sentence that doesn't read well :)\n"},{"id":"365813","messageId":"xmqqimzgrwch.fsf@gitster-ct.c.googlers.com","threadId":"50039","inReplyTo":"bfe22381-864a-4a6b-8dd9-78e268e52c36@iee.org","subject":"Re: [PATCH] doc: improve grammar in git-update-index","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-12-26T18:12:14Z","receivedAt":"2018-12-26T18:12:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Philip Oakley writes:\n\n> On 14/12/2018 21:25, Anthony Sottile wrote:\n>> Signed-off-by: Anthony Sottile \n>> ---\n>> Documentation/git-update-index.txt | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n>> index 1c4d146a4..9c03ca167 100644\n>> --- a/Documentation/git-update-index.txt\n>> +++ b/Documentation/git-update-index.txt\n>> @@ -326,7 +326,7 @@ inefficient `lstat(2)`. If your filesystem is one of them, you\n>> can set \"assume unchanged\" bit to paths you have not changed to\n>> cause Git not to do this check. Note that setting this bit on a\n>> path does not mean Git will check the contents of the file to\n>> -see if it has changed -- it makes Git to omit any checking and\n>> +see if it has changed -- it means Git will skip any checking and\n>> assume it has *not* changed. When you make changes to working\n>> tree files, you have to explicitly tell Git about it by dropping\n>> \"assume unchanged\" bit, either before or after you modify them.\n>\n> Doesn't this also need the caveat that it is _a promise by the user_\n> that they will not change the file, such that Git doesn't need to keep\n> checking, and that occasionally Git will check, or may perform\n> unexpected actions if the user has the wrong mental model.\n\nTrue. \n\nSetting bit _allows_, not necessarily \"makes\", Git to assume that\nthe path will not be modified by the user when it is convenient for\nGit to make that assumption (e.g. instead of reading a blob out of\nthe object database, Git may mmap the corresponding working tree\nfile when they are the same and Git thinks using the latter is more\nefficient). When Git finds it more convenient to check if they are\nthe same, the bit does not stop Git from doing so.\n\nSo in that sense, both the text before and after the patch is bad.\n\n\tNote that setting this bit on a path does not mean Git will\n\talways check, or will never check, the contents of the file\n\tto see if it has changed. The bit allows Git to assume that\n\tthe file in the working tree is identical to what is in the\n\tindex when it is convenient to do so. When you make\n\tchanges...\n\nor something like that.\n\n"}]}