{"thread":{"id":"49955","subject":"Bug: git add --patch does not honor \"diff.noprefix\"","startedAt":"2018-12-06T10:42:16Z","lastAt":"2018-12-09T01:30:48Z","messageCount":2,"participants":["Christian Weiske","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"364680","messageId":"c165fc5f-c452-fb2e-8ac3-d2afb12948bc@cweiske.de","threadId":"49955","inReplyTo":null,"subject":"Bug: git add --patch does not honor \"diff.noprefix\"","fromName":"Christian Weiske","fromEmail":"cweiske@cweiske.de","sentAt":"2018-12-06T10:34:43Z","receivedAt":"2018-12-06T10:42:16Z","isPatch":false,"sender":{"key":"cweiske@cweiske.de","avatar":"https://gravatar.com/avatar/baa4e986ac6bb3f3715de5b08727be61d33afb4b03e792eb6db2f184a61626d6?d=mp&s=160"},"body":"Hi,\n\n\nWhen running \"git add -p\" on git version 2.19.2 and \"diff.noprefix\" set\nto true, it still shows the \"a/\" and \"b/\" prefixes.\n\nThis issue has been reported in 2016 already[1], but is still there in\n2.19.2.\n\n\n[1]\nhttps://public-inbox.org/git/E1D7329A-A54B-4D09-A72A-62ECA8005752@gmail.com/T/\n\n-- \nRegards/Mit freundlichen Grüßen\nChristian Weiske\n\n-=≡ Geeking around in the name of science since 1982 ≡=-\n"},{"id":"364827","messageId":"xmqqsgz75vwd.fsf@gitster-ct.c.googlers.com","threadId":"49955","inReplyTo":"c165fc5f-c452-fb2e-8ac3-d2afb12948bc@cweiske.de","subject":"Re: Bug: git add --patch does not honor \"diff.noprefix\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-12-09T01:30:42Z","receivedAt":"2018-12-09T01:30:48Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Weiske <cweiske@cweiske.de> writes:\n\n> When running \"git add -p\" on git version 2.19.2 and \"diff.noprefix\" set\n> to true, it still shows the \"a/\" and \"b/\" prefixes.\n>\n> This issue has been reported in 2016 already[1], but is still there in\n> 2.19.2.\n\nIt is very likely because it is a non-issue.  \n\nThe reason why prefixes are customizable is to match the convention\nused to show your patch to others, but the patch to be immediately\nconsumed within an \"add -i/-p\" session is viewed only by the user,\nso it is much much lower priority to change the code.  I guess the\nreason why no such change was made is because nobody felt it worth\nthe trouble to change the code to use a non-standard prefix when\nproducing the patch to be shown, and then also change the code to\naccept a non-standard prefix when using the chosen patch to be\napplied.\n"}]}